github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5593] [MERGED] [Redux] Move category states from queriesSlice to budgetSlice #47838

New Issue
Closed
opened 2026-04-26 09:48:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 09:48:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5593
Author: @joel-jeremy
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @joel-jeremy

Base: master ← Head: split-up-queriesSlice-categories

📝 Commits (10+)

  • 07498e0 Update packages/desktop-client/src/queries/queriesSlice.ts
  • c339669 [autofix.ci] apply automated fixes
  • d50b9f4 Move getAccountsById to accountsSlice
  • 8fbe526 [autofix.ci] apply automated fixes
  • 8dadddc Fix merge error
  • ca3a227 [autofix.ci] apply automated fixes
  • 950881f [Redux] Move category states from queriesSlice to budgetSlice
  • cc06640 Move getCategoriesById to budgetSlice + fix lint
  • 0699546 Fix lint
  • ecd5cc4 [autofix.ci] apply automated fixes

📊 Changes

42 files changed (+707 additions, -655 deletions)

View changed files

📝 packages/desktop-client/src/auth/ProtectedRoute.tsx (+1 -1)
➕ packages/desktop-client/src/budget/budgetSlice.ts (+594 -0)
📝 packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts (+6 -6)
📝 packages/desktop-client/src/components/App.tsx (+4 -1)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/index.tsx (+10 -10)
📝 packages/desktop-client/src/components/manager/BudgetFileSelection.tsx (+3 -3)
📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/ManagementApp.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/WelcomeScreen.tsx (+1 -1)
📝 packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/budget/BudgetPage.tsx (+9 -9)
📝 packages/desktop-client/src/components/mobile/budget/ExpenseCategoryList.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/budget/ExpenseGroupList.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/budget/IncomeCategoryList.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/BudgetFileSelectionModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/CreateEncryptionKeyModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/LoadBackupModal.tsx (+4 -1)
📝 packages/desktop-client/src/components/modals/OpenIDEnableModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/OutOfSyncMigrationsModal.tsx (+1 -1)

...and 22 more files

📄 Description

https://github.com/actualbudget/actual/pull/5592 needs to be merged first

Changes:

  1. Renamed budgetsSlice.ts to budgetfilesSlice.ts
  • This slice has states and actions more related to the budget files i.e. opening/closing budget files rather than budgeting
  1. Moved category states to budgetSlice.ts
  • Budgeting related states and actions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5593 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `split-up-queriesSlice-categories` --- ### 📝 Commits (10+) - [`07498e0`](https://github.com/actualbudget/actual/commit/07498e035d39c153fbd0bcd86b3444c74bc81368) Update packages/desktop-client/src/queries/queriesSlice.ts - [`c339669`](https://github.com/actualbudget/actual/commit/c3396691179b2bdf5bcc412c9e6ae5cb814ab86d) [autofix.ci] apply automated fixes - [`d50b9f4`](https://github.com/actualbudget/actual/commit/d50b9f431e0c38d8457ecd8463943330255e889d) Move getAccountsById to accountsSlice - [`8fbe526`](https://github.com/actualbudget/actual/commit/8fbe526e920b2b6a15df70235422454b32fb92fb) [autofix.ci] apply automated fixes - [`8dadddc`](https://github.com/actualbudget/actual/commit/8dadddce106337bfb486b6d2f3760a669d509e3a) Fix merge error - [`ca3a227`](https://github.com/actualbudget/actual/commit/ca3a227bf20e171686bb457c598953acf3525388) [autofix.ci] apply automated fixes - [`950881f`](https://github.com/actualbudget/actual/commit/950881fcc8bf6e3828023c51975e120e302e2688) [Redux] Move category states from queriesSlice to budgetSlice - [`cc06640`](https://github.com/actualbudget/actual/commit/cc06640a85d905fb824005c0fc15cea6a7314cb8) Move getCategoriesById to budgetSlice + fix lint - [`0699546`](https://github.com/actualbudget/actual/commit/0699546b82c10de870fcce1fe89f6485fbf3da18) Fix lint - [`ecd5cc4`](https://github.com/actualbudget/actual/commit/ecd5cc47f95c81e71fd6d7f64177de216d42b3bf) [autofix.ci] apply automated fixes ### 📊 Changes **42 files changed** (+707 additions, -655 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/auth/ProtectedRoute.tsx` (+1 -1) ➕ `packages/desktop-client/src/budget/budgetSlice.ts` (+594 -0) 📝 `packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts` (+6 -6) 📝 `packages/desktop-client/src/components/App.tsx` (+4 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+10 -10) 📝 `packages/desktop-client/src/components/manager/BudgetFileSelection.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ManagementApp.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/WelcomeScreen.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/Bootstrap.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetPage.tsx` (+9 -9) 📝 `packages/desktop-client/src/components/mobile/budget/ExpenseCategoryList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/budget/ExpenseGroupList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/budget/IncomeCategoryList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/BudgetFileSelectionModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKeyModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/LoadBackupModal.tsx` (+4 -1) 📝 `packages/desktop-client/src/components/modals/OpenIDEnableModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/OutOfSyncMigrationsModal.tsx` (+1 -1) _...and 22 more files_ </details> ### 📄 Description ~~https://github.com/actualbudget/actual/pull/5592 needs to be merged first~~ Changes: 1. Renamed `budgetsSlice.ts` to `budgetfilesSlice.ts` - This slice has states and actions more related to the budget files i.e. opening/closing budget files rather than budgeting 2. Moved category states to `budgetSlice.ts` - Budgeting related states and actions <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 09:48:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#47838