mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
[Tech Debt] Refactor "Select" component usage to "CustomSelect" #477
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#477
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MatissJanis on GitHub (Jul 4, 2023).
We currently have 2x Select components - Select & CustomSelect.
The goal would be to remove the Select component in favor of CustomSelect/Autocomplete.
This would make all the select-s in the app have a consistent UI and UX.
@biohzrddd commented on GitHub (Jul 4, 2023):
Agreed we need just one. The CustomSelect component from the reach package is quite a pain to style (e.g. I can't figure out how to get rid of the blue flashes in #922) and doesn't offer much that I can see over the built-in Select. Can we not style the built-in good enough?
@j-f1 commented on GitHub (Jul 9, 2023):
Still one more:
927c859456/packages/desktop-client/src/components/modals/ConfirmCategoryDelete.js (L80-L99)927c859456/packages/desktop-client/src/components/autocomplete/CategorySelect.tsx (L22-L44)