github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3137] [CLOSED] Refactor TypeScript types in goal templates. #4701

New Issue
Closed
opened 2026-02-28 20:59:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:59:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3137
Author: @samwightt
Created: 7/25/2024
Status: ❌ Closed

Base: master ← Head: sw/add-type-params

📝 Commits (4)

  • 7451a0a Add first shot at TypeScript types for template in goals.
  • 92ab822 Clean up ESLint warnings.
  • 12e3794 Merge branch 'master' into sw/add-type-params
  • 1d7f913 Add release note.

📊 Changes

10 files changed (+132 additions, -25 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goals/goalsAverage.ts (+2 -1)
📝 packages/loot-core/src/server/budget/goals/goalsBy.ts (+5 -5)
📝 packages/loot-core/src/server/budget/goals/goalsPercentage.ts (+2 -1)
📝 packages/loot-core/src/server/budget/goals/goalsRemainder.ts (+3 -1)
📝 packages/loot-core/src/server/budget/goals/goalsSimple.ts (+17 -8)
📝 packages/loot-core/src/server/budget/goals/goalsSpend.ts (+2 -1)
📝 packages/loot-core/src/server/budget/goals/goalsWeek.ts (+2 -1)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+11 -7)
➕ packages/loot-core/src/server/budget/template.types.ts (+82 -0)
➕ upcoming-release-notes/3137.md (+6 -0)

📄 Description

This PR tries to add TypeScript types for templates in goalTemplates. This is just a first shot and my best guess at what the actual TypeScript types are. This PR also adds some argument types to functions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3137 **Author:** [@samwightt](https://github.com/samwightt) **Created:** 7/25/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `sw/add-type-params` --- ### 📝 Commits (4) - [`7451a0a`](https://github.com/actualbudget/actual/commit/7451a0ac8b459b87f36f5c8670995f76d771f90b) Add first shot at TypeScript types for template in goals. - [`92ab822`](https://github.com/actualbudget/actual/commit/92ab8224627b38a3cc498802ab676f9f5ea7c1b7) Clean up ESLint warnings. - [`12e3794`](https://github.com/actualbudget/actual/commit/12e37942d2f7ecdc5c42a08de4ab796a0c0678e9) Merge branch 'master' into sw/add-type-params - [`1d7f913`](https://github.com/actualbudget/actual/commit/1d7f91355326a394c0c2c850562aed8dc03510fc) Add release note. ### 📊 Changes **10 files changed** (+132 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goals/goalsAverage.ts` (+2 -1) 📝 `packages/loot-core/src/server/budget/goals/goalsBy.ts` (+5 -5) 📝 `packages/loot-core/src/server/budget/goals/goalsPercentage.ts` (+2 -1) 📝 `packages/loot-core/src/server/budget/goals/goalsRemainder.ts` (+3 -1) 📝 `packages/loot-core/src/server/budget/goals/goalsSimple.ts` (+17 -8) 📝 `packages/loot-core/src/server/budget/goals/goalsSpend.ts` (+2 -1) 📝 `packages/loot-core/src/server/budget/goals/goalsWeek.ts` (+2 -1) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+11 -7) ➕ `packages/loot-core/src/server/budget/template.types.ts` (+82 -0) ➕ `upcoming-release-notes/3137.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> This PR tries to add TypeScript types for templates in goalTemplates. This is just a first shot and my best guess at what the actual TypeScript types are. This PR also adds some argument types to functions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:59:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4701
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?