github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #3427] [MERGED] ♻️ (synced-prefs) move budget type to synced prefs #46667

New Issue
Closed
opened 2026-04-26 08:42:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:42:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3427
Author: @MatissJanis
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/17/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/synced-prefs-7

📝 Commits (7)

  • 59224da ♻️ (synced-prefs) moving the prefs from metadata.json to the db
  • 233dc57 Unit test fix
  • 1180c58 Different test patch
  • c4cfb1e Different test patch
  • ebaa6b2 ♻️ (synced-prefs) move budget type to synced prefs
  • 648bdee Fix UT
  • ee477a2 Merge branch 'master' into matiss/synced-prefs-7

📊 Changes

17 files changed (+49 additions, -100 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/index.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/util.ts (+3 -17)
📝 packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (+3 -3)
📝 packages/desktop-client/src/components/mobile/budget/index.tsx (+1 -2)
📝 packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx (+8 -39)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+1 -2)
📝 packages/loot-core/migrations/1723665565000_prefs.js (+1 -1)
📝 packages/loot-core/src/server/budget/actions.ts (+5 -4)
📝 packages/loot-core/src/server/main.ts (+5 -15)
📝 packages/loot-core/src/server/prefs.ts (+1 -1)
📝 packages/loot-core/src/server/sheet.ts (+4 -2)
📝 packages/loot-core/src/server/sync/index.ts (+5 -5)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -2)
📝 packages/loot-core/src/types/server-handlers.d.ts (+0 -2)
📝 upcoming-release-notes/3352.md (+1 -1)
➕ upcoming-release-notes/3427.md (+6 -0)

📄 Description

Depends on https://github.com/actualbudget/actual/pull/3423

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced synchronization of budget type preferences across devices and sessions.
    • Added support for translations in the BalanceWithCarryover component to improve accessibility for international users.

  • Bug Fixes

    • Improved reliability of budget type retrieval by sourcing directly from the database.

  • Refactor

    • Simplified budget type management by consolidating multiple hooks into a single synchronized preference approach.
    • Removed outdated budget type setting handler to streamline functionality.

  • Chores

    • Updated preference management system to ensure consistency and reliability in user settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3427 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/17/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/synced-prefs-7` --- ### 📝 Commits (7) - [`59224da`](https://github.com/actualbudget/actual/commit/59224dac0da8f711b596dfcee517b7166f68f1fd) :recycle: (synced-prefs) moving the prefs from metadata.json to the db - [`233dc57`](https://github.com/actualbudget/actual/commit/233dc5750bfd91659f2dc6f4d082750024b5928f) Unit test fix - [`1180c58`](https://github.com/actualbudget/actual/commit/1180c58d3fb95487998015b9ebb3739fe0c32bed) Different test patch - [`c4cfb1e`](https://github.com/actualbudget/actual/commit/c4cfb1e1b2dcf52e08cdf58bc2c882f2340de6eb) Different test patch - [`ebaa6b2`](https://github.com/actualbudget/actual/commit/ebaa6b2f0fa40a6d408472c27c11c4d4ca369ed1) :recycle: (synced-prefs) move budget type to synced prefs - [`648bdee`](https://github.com/actualbudget/actual/commit/648bdee7293fe1163647ff1df9ace4a2665f583e) Fix UT - [`ee477a2`](https://github.com/actualbudget/actual/commit/ee477a20ec07838b571508c57de1d4e03abf1254) Merge branch 'master' into matiss/synced-prefs-7 ### 📊 Changes **17 files changed** (+49 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/util.ts` (+3 -17) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/budget/index.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx` (+8 -39) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+1 -2) 📝 `packages/loot-core/migrations/1723665565000_prefs.js` (+1 -1) 📝 `packages/loot-core/src/server/budget/actions.ts` (+5 -4) 📝 `packages/loot-core/src/server/main.ts` (+5 -15) 📝 `packages/loot-core/src/server/prefs.ts` (+1 -1) 📝 `packages/loot-core/src/server/sheet.ts` (+4 -2) 📝 `packages/loot-core/src/server/sync/index.ts` (+5 -5) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -2) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+0 -2) 📝 `upcoming-release-notes/3352.md` (+1 -1) ➕ `upcoming-release-notes/3427.md` (+6 -0) </details> ### 📄 Description Depends on https://github.com/actualbudget/actual/pull/3423 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced synchronization of budget type preferences across devices and sessions. - Added support for translations in the BalanceWithCarryover component to improve accessibility for international users. - **Bug Fixes** - Improved reliability of budget type retrieval by sourcing directly from the database. - **Refactor** - Simplified budget type management by consolidating multiple hooks into a single synchronized preference approach. - Removed outdated budget type setting handler to streamline functionality. - **Chores** - Updated preference management system to ensure consistency and reliability in user settings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:42:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46667
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?