github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3078] [CLOSED] Added Pay Distribution Template to Goal-templates #4666

New Issue
Closed
opened 2026-02-28 20:59:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:59:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3078
Author: @Midgetwombat
Created: 7/17/2024
Status: ❌ Closed

Base: master ← Head: goalTemplate-AdditionFeature

📝 Commits (10+)

  • 458b7a6 Added feature to Goal-template, so when triggered adds value to budgeted instead of replacing.
  • 06a804c Update goaltemplates.ts
  • 52cc78d Create 3078.md
  • 4ee6312 Merge branch 'master' into goalTemplate-AdditionFeature
  • e359708 Merge branch 'master' into goalTemplate-AdditionFeature
  • 7b73626 Updated How the Pay Distribution worked as to not effect goals set.
  • 5208bd1 Fixed a merge error
  • de8c6f5 Merge branch 'master' into goalTemplate-AdditionFeature
  • f338ea1 Delete packages/loot-core/src/server/budget/goals/payDistribution.ts
  • d2d805b Delete packages/loot-core/src/server/budget/goal-template.pegjs

📊 Changes

20 files changed (+220 additions, -223 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/index.tsx (+2 -1)
📝 packages/desktop-client/src/components/mobile/budget/index.tsx (+2 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+1 -5)
📝 packages/desktop-client/src/components/reports/graphs/SpendingGraph.tsx (+8 -21)
📝 packages/desktop-client/src/components/reports/reports/Spending.tsx (+17 -90)
📝 packages/desktop-client/src/components/reports/reports/SpendingCard.tsx (+4 -11)
📝 packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts (+8 -40)
📝 packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx (+1 -1)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+1 -1)
📝 packages/loot-core/src/server/budget/goal-template.pegjs (+6 -1)
📝 packages/loot-core/src/server/budget/goals/goalsRemainder.ts (+6 -2)
➕ packages/loot-core/src/server/budget/goals/payDistribution.ts (+53 -0)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+103 -20)
📝 packages/loot-core/src/types/models/reports.d.ts (+1 -9)
📝 packages/loot-core/src/types/prefs.d.ts (+0 -1)
➕ upcoming-release-notes/3078.md (+6 -0)
➖ upcoming-release-notes/3132.md (+0 -6)
➖ upcoming-release-notes/3168.md (+0 -6)
➖ upcoming-release-notes/3169.md (+0 -6)

📄 Description

THIS PR HAS BEEN REPLACED WITH PR #3176. Please read here for comments and explanation. And review code at 3176.

Added a new Template type called Pay Distribution, which is designed to be triggered every time the apply template is clicked. if a Pay Distribution template is applied to a category then instead of adding to the goal the distribution template will just add its value to the currently budgeted amount. if a normal template is applied to the category as well, then that template will add to the goal but will not change the value of the budgeted column.

The purpose of this new template is for people who budget by paycheck which may not be monthly, or for those who are still working on building up their funds to have enough to budget for a month.

The pay Distribution Template has two operations either a set amount OR a percentage of the remaining available funds.
Additionally, if the pay distribution template is added to the same category as the remainder template, then the remaining budget will be added to that category also. Otherwise, the remainder template will retain its normal functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3078 **Author:** [@Midgetwombat](https://github.com/Midgetwombat) **Created:** 7/17/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `goalTemplate-AdditionFeature` --- ### 📝 Commits (10+) - [`458b7a6`](https://github.com/actualbudget/actual/commit/458b7a687457c15e1d5c22070ee8b300d882f91e) Added feature to Goal-template, so when triggered adds value to budgeted instead of replacing. - [`06a804c`](https://github.com/actualbudget/actual/commit/06a804cc9bd5297242473b20d003dd4a9c55c334) Update goaltemplates.ts - [`52cc78d`](https://github.com/actualbudget/actual/commit/52cc78d257aae63bf1b69d391bc84a2a85745971) Create 3078.md - [`4ee6312`](https://github.com/actualbudget/actual/commit/4ee63122c1f77fa0b0b5726f5b3ce5cb94c4de9e) Merge branch 'master' into goalTemplate-AdditionFeature - [`e359708`](https://github.com/actualbudget/actual/commit/e3597084a209f6749e8433a1f9f37e53acf01d02) Merge branch 'master' into goalTemplate-AdditionFeature - [`7b73626`](https://github.com/actualbudget/actual/commit/7b736267e96405eae4328c0758733d95c385adcf) Updated How the Pay Distribution worked as to not effect goals set. - [`5208bd1`](https://github.com/actualbudget/actual/commit/5208bd1a261e4c1f008244d07256e6db56076624) Fixed a merge error - [`de8c6f5`](https://github.com/actualbudget/actual/commit/de8c6f53cc3037b933fc103020ac06f5a9f7e7d8) Merge branch 'master' into goalTemplate-AdditionFeature - [`f338ea1`](https://github.com/actualbudget/actual/commit/f338ea14196b9bf1f722ffddeeb1203c45997743) Delete packages/loot-core/src/server/budget/goals/payDistribution.ts - [`d2d805b`](https://github.com/actualbudget/actual/commit/d2d805b78ab48aa780606f5e5d1bdabd7ff6e148) Delete packages/loot-core/src/server/budget/goal-template.pegjs ### 📊 Changes **20 files changed** (+220 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/mobile/budget/index.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+1 -5) 📝 `packages/desktop-client/src/components/reports/graphs/SpendingGraph.tsx` (+8 -21) 📝 `packages/desktop-client/src/components/reports/reports/Spending.tsx` (+17 -90) 📝 `packages/desktop-client/src/components/reports/reports/SpendingCard.tsx` (+4 -11) 📝 `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts` (+8 -40) 📝 `packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+1 -1) 📝 `packages/loot-core/src/server/budget/goal-template.pegjs` (+6 -1) 📝 `packages/loot-core/src/server/budget/goals/goalsRemainder.ts` (+6 -2) ➕ `packages/loot-core/src/server/budget/goals/payDistribution.ts` (+53 -0) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+103 -20) 📝 `packages/loot-core/src/types/models/reports.d.ts` (+1 -9) 📝 `packages/loot-core/src/types/prefs.d.ts` (+0 -1) ➕ `upcoming-release-notes/3078.md` (+6 -0) ➖ `upcoming-release-notes/3132.md` (+0 -6) ➖ `upcoming-release-notes/3168.md` (+0 -6) ➖ `upcoming-release-notes/3169.md` (+0 -6) </details> ### 📄 Description THIS PR HAS BEEN REPLACED WITH [PR #3176](https://github.com/actualbudget/actual/pull/3176#issue-comment-box). Please read here for comments and explanation. And review code at 3176. Added a new Template type called Pay Distribution, which is designed to be triggered every time the apply template is clicked. if a Pay Distribution template is applied to a category then instead of adding to the goal the distribution template will just add its value to the currently budgeted amount. if a normal template is applied to the category as well, then that template will add to the goal but will not change the value of the budgeted column. The purpose of this new template is for people who budget by paycheck which may not be monthly, or for those who are still working on building up their funds to have enough to budget for a month. The pay Distribution Template has two operations either a set amount OR a percentage of the remaining available funds. Additionally, if the pay distribution template is added to the same category as the remainder template, then the remaining budget will be added to that category also. Otherwise, the remainder template will retain its normal functionality. <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:59:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4666
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?