github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2834] [MERGED] Reapply rules to split transactions when the parent changes #46358

New Issue
Closed
opened 2026-04-26 08:25:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:25:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2834
Author: @jfdoming
Created: 6/4/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @youngcw

Base: master ← Head: jfdoming/auto-apply-rules-to-split-transaction-entry

📝 Commits (4)

  • d2d3a97 Reapply rules to split transactions when the parent changes
  • e74643b Add release notes
  • 342ec20 Fix bug in first field below parent transaction
  • 3fa13b0 Update vrt

📊 Changes

6 files changed (+59 additions, -20 deletions)

View changed files

📝 packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-split-transaction-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/table.tsx (+6 -0)
📝 packages/desktop-client/src/components/transactions/TransactionList.jsx (+35 -16)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+9 -3)
📝 packages/loot-core/src/shared/transactions.ts (+3 -1)
➕ upcoming-release-notes/2834.md (+6 -0)

📄 Description

Concretely, this enables the "standard" workflow for split-transaction-entry on desktop, where you enter the payee first, and then edit the amount afterwards (and expect splits in a rule to apply when you edit the amount).

After adding payee:
image

After updating the amount:
image

Note that this doesn't affect transaction editing within the transaction table, since rules are intentionally not run there.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2834 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 6/4/2024 **Status:** ✅ Merged **Merged:** 7/3/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `jfdoming/auto-apply-rules-to-split-transaction-entry` --- ### 📝 Commits (4) - [`d2d3a97`](https://github.com/actualbudget/actual/commit/d2d3a979ed517b2ba91dc7662355484bcdbbb69c) Reapply rules to split transactions when the parent changes - [`e74643b`](https://github.com/actualbudget/actual/commit/e74643bb1ede17054f9b267f8458e6046462bca6) Add release notes - [`342ec20`](https://github.com/actualbudget/actual/commit/342ec205454cb85aa92f91977004aa7223fd5a52) Fix bug in first field below parent transaction - [`3fa13b0`](https://github.com/actualbudget/actual/commit/3fa13b0f3e56cc18abd9e814162509370b2bc1d9) Update vrt ### 📊 Changes **6 files changed** (+59 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-split-transaction-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/table.tsx` (+6 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionList.jsx` (+35 -16) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+9 -3) 📝 `packages/loot-core/src/shared/transactions.ts` (+3 -1) ➕ `upcoming-release-notes/2834.md` (+6 -0) </details> ### 📄 Description Concretely, this enables the "standard" workflow for split-transaction-entry on desktop, where you enter the payee first, and then edit the amount afterwards (and expect splits in a rule to apply when you edit the amount). After adding payee: <img width="1200" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/bf7e0c4c-7398-4293-bfe6-fa87b8ab7607"> After updating the amount: <img width="1198" alt="image" src="https://github.com/actualbudget/actual/assets/9922514/8401de94-0c5b-461c-ad83-1d635041c5aa"> Note that this doesn't affect transaction _editing_ within the transaction table, since rules are intentionally _not_ run there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:25:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46358
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?