github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 08:52:49 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3001] [MERGED] reorders 'Rename' above 'Hide' in menu popovers, adds debounce to sidebar animation #4630

New Issue
Closed
opened 2026-02-28 20:58:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3001
Author: @YusefOuda
Created: 7/7/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @joel-jeremy

Base: master ← Head: bugfix/reorder-hide-in-menus

📝 Commits (10+)

📊 Changes

5 files changed (+19 additions, -11 deletions)

View changed files

📝 packages/desktop-client/src/components/Titlebar.tsx (+0 -5)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+1 -1)
📝 packages/desktop-client/src/components/sidebar/index.tsx (+11 -4)
➕ upcoming-release-notes/3001.md (+6 -0)

📄 Description

Issue 1: NA

Description: More than once now, I've accidentally clicked "Hide" on the popovers for categories and category groups (and not even noticed they were gone). This PR moves "Rename" above "Hide", since it's less destructive (and Hide + Delete make sense to be next to each other for UX)

image
image

Issue 2: NA

Description: It also adds a debounce (350ms) to the sidebar closing animation to allow the user some time before the sidebar starts to close. Also removed event listener from titlebar icon to resolve some quirkiness with setting hidden state of the sidebar

https://github.com/actualbudget/actual/assets/5180063/639862a5-9db1-4cae-8c16-4acff60e62ba

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3001 **Author:** [@YusefOuda](https://github.com/YusefOuda) **Created:** 7/7/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `bugfix/reorder-hide-in-menus` --- ### 📝 Commits (10+) - [`beb6cf7`](https://github.com/actualbudget/actual/commit/beb6cf79090806d09151e33b519eaab363c10f37) reorders 'Rename' above 'Hide' in menu popovers - [`e2a1557`](https://github.com/actualbudget/actual/commit/e2a1557994000d466141648677e4c7cbe56b183c) release notes - [`f48c127`](https://github.com/actualbudget/actual/commit/f48c12717fbc9eaae4cd7b69734c6f727cd76271) adds debounce to sidebar animation - [`41f8eac`](https://github.com/actualbudget/actual/commit/41f8eac197a9921a0c11757c7ef44547aa47f951) bump debounce time - [`cade104`](https://github.com/actualbudget/actual/commit/cade1041a04daf40b6b72a833449ff0ca70df03f) Merge branch 'master' into bugfix/reorder-hide-in-menus - [`5921988`](https://github.com/actualbudget/actual/commit/5921988f91e1afe46014642c1cfd9eeba4fc0cd0) release notes - [`4d06a83`](https://github.com/actualbudget/actual/commit/4d06a83ed951c19de0ffffb1551d2ac3397841b3) release notes - [`608e64a`](https://github.com/actualbudget/actual/commit/608e64a4927843a9f9e0c902f6dac076dd3a0590) Update debounce import - [`2c82fd2`](https://github.com/actualbudget/actual/commit/2c82fd224ef7352e49b97ecf7ff1b87b105bbd66) Update index.tsx - [`1e9cc84`](https://github.com/actualbudget/actual/commit/1e9cc84723e96ca38bd254fa17e369ee5b80cb4c) Update index.tsx ### 📊 Changes **5 files changed** (+19 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+0 -5) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/sidebar/index.tsx` (+11 -4) ➕ `upcoming-release-notes/3001.md` (+6 -0) </details> ### 📄 Description **Issue 1:** NA **Description:** More than once now, I've accidentally clicked "Hide" on the popovers for categories and category groups (and not even noticed they were gone). This PR moves "Rename" above "Hide", since it's less destructive (and Hide + Delete make sense to be next to each other for UX) ![image](https://github.com/actualbudget/actual/assets/5180063/9f4f2fc7-4c79-4e6e-8a82-5290d3a7edeb) ![image](https://github.com/actualbudget/actual/assets/5180063/64954696-66d1-40da-9e22-1a6a4a984c8a) --- **Issue 2:** NA **Description:** It also adds a debounce (350ms) to the sidebar closing animation to allow the user some time before the sidebar starts to close. Also removed event listener from titlebar icon to resolve some quirkiness with setting hidden state of the sidebar https://github.com/actualbudget/actual/assets/5180063/639862a5-9db1-4cae-8c16-4acff60e62ba --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4630
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?