github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2618] [CLOSED] fix(#2562): Prevent transaction deduplication for imported transactions #46230

New Issue
Closed
opened 2026-04-26 08:18:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:18:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2618
Author: @ttlgeek
Created: 4/16/2024
Status: ❌ Closed

Base: master ← Head: fix-2526

📝 Commits (10+)

  • a5ebcc6 fix(#2562): Prevent transaction deduplication for imported transactions
  • 17159e8 chore(): eslint fixes
  • 9905c47 chore(): Add release note file
  • 3fd1321 Merge branch 'master' into fix-2526
  • 372d38c Merge branch 'master' into fix-2526
  • 351bccf Merge branch 'master' into fix-2526
  • a4f1203 Merge branch 'master' into fix-2526
  • 5449df3 Merge branch 'master' into fix-2526
  • fe33ef0 Merge branch 'master' into fix-2526
  • 3139f79 Merge branch 'master' into fix-2526

📊 Changes

3 files changed (+63 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/sync.test.ts (+56 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+1 -1)
➕ upcoming-release-notes/2618.md (+6 -0)

📄 Description

Hello,

After looking into the issue, it seems that the transaction deduplication is due to the two transactions having the same amount and account and the second transaction happened within 7 days of the first one.

After reading the import transaction code, the fuzzy matching matching uses the 7 days method to try to match similar transactions and merge them.

Proposed solution: prevent the fuzzy matching from matching imported transactions (where import_id is not null) to prevent this behavior.

@MatissJanis what do you think ?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2618 **Author:** [@ttlgeek](https://github.com/ttlgeek) **Created:** 4/16/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-2526` --- ### 📝 Commits (10+) - [`a5ebcc6`](https://github.com/actualbudget/actual/commit/a5ebcc6a7301c2815acfe4040a377cb7594494d3) fix(#2562): Prevent transaction deduplication for imported transactions - [`17159e8`](https://github.com/actualbudget/actual/commit/17159e82311b4b04c99753272547054520cdbe7e) chore(): eslint fixes - [`9905c47`](https://github.com/actualbudget/actual/commit/9905c4729f67a066a4dc212094b025b2ddb1a17a) chore(): Add release note file - [`3fd1321`](https://github.com/actualbudget/actual/commit/3fd13216bc7933664ebeea5dc96c9fbaa6029859) Merge branch 'master' into fix-2526 - [`372d38c`](https://github.com/actualbudget/actual/commit/372d38c57c00ff0e38163df261bf799ddd4a9a79) Merge branch 'master' into fix-2526 - [`351bccf`](https://github.com/actualbudget/actual/commit/351bccfc81e65e41dedd4ded73128c8039b6a330) Merge branch 'master' into fix-2526 - [`a4f1203`](https://github.com/actualbudget/actual/commit/a4f120378a9742db337d9b36123e982b0040593a) Merge branch 'master' into fix-2526 - [`5449df3`](https://github.com/actualbudget/actual/commit/5449df3eb07661c5ceaad31a2d3a6c3be81450fe) Merge branch 'master' into fix-2526 - [`fe33ef0`](https://github.com/actualbudget/actual/commit/fe33ef0baae02bf5b3c77814174a379c0d048e22) Merge branch 'master' into fix-2526 - [`3139f79`](https://github.com/actualbudget/actual/commit/3139f79bd2aa8bed761798a8233c3d7cdc65e107) Merge branch 'master' into fix-2526 ### 📊 Changes **3 files changed** (+63 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+56 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+1 -1) ➕ `upcoming-release-notes/2618.md` (+6 -0) </details> ### 📄 Description Hello, After looking into the issue, it seems that the transaction deduplication is due to the two transactions having the same amount and account and the second transaction happened within 7 days of the first one. After reading the import transaction code, the fuzzy matching matching uses the 7 days method to try to match similar transactions and merge them. Proposed solution: prevent the fuzzy matching from matching imported transactions (where import_id is not null) to prevent this behavior. @MatissJanis what do you think ? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:18:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?