github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-14 21:15:41 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #2603] [CLOSED] [WIP] ♻️ (tooltip) refactoring to react-aria (vol.4) #46216

New Issue
Closed
opened 2026-04-26 08:17:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:17:56 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2603
Author: @MatissJanis
Created: 4/14/2024
Status: ❌ Closed

Base: master ← Head: matiss/tooltip-3

📝 Commits (10+)

📊 Changes

25 files changed (+762 additions, -778 deletions)

View changed files

📝 packages/desktop-client/e2e/transactions.test.js (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+109 -113)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+9 -5)
📝 packages/desktop-client/src/components/budget/BudgetTotals.tsx (+39 -39)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+34 -32)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+36 -34)
📝 packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx (+15 -32)
📝 packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx (+5 -32)
📝 packages/desktop-client/src/components/budget/rollover/HoldTooltip.tsx (+5 -17)
📝 packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx (+57 -48)
📝 packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx (+9 -38)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx (+0 -1)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx (+43 -52)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx (+14 -20)
📝 packages/desktop-client/src/components/common/Input.tsx (+2 -2)
📝 packages/desktop-client/src/components/common/Popover.tsx (+20 -1)
📝 packages/desktop-client/src/components/common/Select.tsx (+1 -1)
📝 packages/desktop-client/src/components/filters/FilterExpression.tsx (+14 -3)
📝 packages/desktop-client/src/components/filters/FilterMenu.tsx (+29 -34)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+226 -199)

...and 5 more files

📄 Description

Follow up to https://github.com/actualbudget/actual/pull/2493

This should move the majority (if not all) of the Tooltip components used in the reports page.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2603 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/14/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `matiss/tooltip-3` --- ### 📝 Commits (10+) - [`8ee3521`](https://github.com/actualbudget/actual/commit/8ee3521e16b78e7a81199bcdd55e6432b6b0dd70) :recycle: (tooltip) refactoring to react-aria (vol.3) - [`ec1f9e7`](https://github.com/actualbudget/actual/commit/ec1f9e7a6d54586829cd9c6f1309a5b4dbdbafb6) Release notes - [`219a63a`](https://github.com/actualbudget/actual/commit/219a63aca6f6b5981d6083869206ab772380207d) Unit test patches - [`09d3076`](https://github.com/actualbudget/actual/commit/09d30768cc2f7cae03ccc03182d4f21a68436e55) More unit test patches - [`12a9480`](https://github.com/actualbudget/actual/commit/12a9480b04e238b54ed6f11cd1a0380f15518d70) Port over filters too to patch e2e tests - [`fdb1098`](https://github.com/actualbudget/actual/commit/fdb109832044a78d7848444f7517afff41cf1d58) Various patches - [`559c159`](https://github.com/actualbudget/actual/commit/559c1597eb06ca625afe0872e81063668fe6dd4a) More patches - [`7412e8f`](https://github.com/actualbudget/actual/commit/7412e8f4bf8fab7f6e2ac0ecaa9cffe9d5e49a8b) Update autocomplete width - [`7cb081b`](https://github.com/actualbudget/actual/commit/7cb081be593b272efdb86cd9a7d113f6cc472395) Unit test patch - [`9c2893f`](https://github.com/actualbudget/actual/commit/9c2893fecd1ee11bd6eb7e92ef04c5948f496d22) Patch e2e? ### 📊 Changes **25 files changed** (+762 additions, -778 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/transactions.test.js` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+109 -113) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+9 -5) 📝 `packages/desktop-client/src/components/budget/BudgetTotals.tsx` (+39 -39) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+34 -32) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+36 -34) 📝 `packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx` (+15 -32) 📝 `packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx` (+5 -32) 📝 `packages/desktop-client/src/components/budget/rollover/HoldTooltip.tsx` (+5 -17) 📝 `packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx` (+57 -48) 📝 `packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx` (+9 -38) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx` (+43 -52) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx` (+14 -20) 📝 `packages/desktop-client/src/components/common/Input.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/common/Popover.tsx` (+20 -1) 📝 `packages/desktop-client/src/components/common/Select.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/filters/FilterExpression.tsx` (+14 -3) 📝 `packages/desktop-client/src/components/filters/FilterMenu.tsx` (+29 -34) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+226 -199) _...and 5 more files_ </details> ### 📄 Description Follow up to https://github.com/actualbudget/actual/pull/2493 This should move the majority (if not all) of the `Tooltip` components used in the reports page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:17:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46216