github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2559] [MERGED] Ensure api types are included in the npm package #46188

New Issue
Closed
opened 2026-04-26 08:16:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:16:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2559
Author: @turt2live
Created: 4/6/2024
Status: ✅ Merged
Merged: 5/18/2024
Merged by: @twk3

Base: master ← Head: travis/ts

📝 Commits (3)

  • 7166ef3 Ensure api types are included in the npm package
  • f3f5c29 changelog
  • 0c89565 Merge branch 'master' into travis/ts

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 packages/api/package.json (+2 -1)
➕ upcoming-release-notes/2559.md (+6 -0)

📄 Description

Starting fresh with a TypeScript project results in error TS7016: Could not find a declaration file for module '@actual-app/api', but the types are in fact generated during build/release. The @types directory feels unintentionally excluded from the package.

It is worth noting that the @types directory has a bit of noise to it, but on balance having types feels more beneficial.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2559 **Author:** [@turt2live](https://github.com/turt2live) **Created:** 4/6/2024 **Status:** ✅ Merged **Merged:** 5/18/2024 **Merged by:** [@twk3](https://github.com/twk3) **Base:** `master` ← **Head:** `travis/ts` --- ### 📝 Commits (3) - [`7166ef3`](https://github.com/actualbudget/actual/commit/7166ef30b30916a3d68c8fc618739fc1956843fc) Ensure api types are included in the npm package - [`f3f5c29`](https://github.com/actualbudget/actual/commit/f3f5c296f0d6e3abcd73c451b6729001edf73767) changelog - [`0c89565`](https://github.com/actualbudget/actual/commit/0c89565f177eb47dd6330092922f0a2c6a66f98b) Merge branch 'master' into travis/ts ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/package.json` (+2 -1) ➕ `upcoming-release-notes/2559.md` (+6 -0) </details> ### 📄 Description Starting fresh with a TypeScript project results in `error TS7016: Could not find a declaration file for module '@actual-app/api'`, but the types are in fact generated during build/release. The `@types` directory feels unintentionally excluded from the package. It is worth noting that the `@types` directory has a bit of noise to it, but on balance having types feels more beneficial. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:16:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?