github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2534] [MERGED] ♻️ (bank-sync) unify the sync/reconciliation logic for internal & external sync #46172

New Issue
Closed
opened 2026-04-26 08:15:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:15:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2534
Author: @MatissJanis
Created: 3/31/2024
Status: ✅ Merged
Merged: 4/9/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/gocardless-unify

📝 Commits (10+)

  • a9039e8 ♻️ (bank-sync) unify the sync/reconciliation logic for interal & external sync
  • 54d2ee8 Release notes
  • 967c837 Remove unused TransactionEntity import
  • 28fbe78 Merge branch 'master' into matiss/gocardless-unify
  • 698ed1f Merge branch 'master' into matiss/gocardless-unify
  • 0edcd09 Feedback: update date only for internal accounts
  • df35270 Patch linter
  • c8a741a Rename external -> bankSync and a bit of cleanup
  • 25d278d Remove plaid sync tests
  • d0f0b92 Remove more dead code

📊 Changes

9 files changed (+66 additions, -3290 deletions)

View changed files

📝 packages/loot-core/src/client/actions/account.ts (+0 -20)
📝 packages/loot-core/src/server/accounts/__snapshots__/sync.test.ts.snap (+0 -2503)
📝 packages/loot-core/src/server/accounts/link.ts (+1 -49)
📝 packages/loot-core/src/server/accounts/sync.test.ts (+2 -282)
📝 packages/loot-core/src/server/accounts/sync.ts (+54 -302)
📝 packages/loot-core/src/server/main.test.ts (+0 -58)
📝 packages/loot-core/src/server/main.ts (+3 -62)
📝 packages/loot-core/src/types/server-handlers.d.ts (+0 -14)
➕ upcoming-release-notes/2534.md (+6 -0)

📄 Description

Unifying the reconciliation and syncing logic to reduce duplication.

Previously we had reconcileTransactions, reconcileExternalTransactions, syncAccount and syncExternalAccount. Now we have only one of each.

The logic there is still not exactly clean. But at least now we have a single place for it instead of copy&paste duplication.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2534 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/31/2024 **Status:** ✅ Merged **Merged:** 4/9/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/gocardless-unify` --- ### 📝 Commits (10+) - [`a9039e8`](https://github.com/actualbudget/actual/commit/a9039e825d6b2eafce0469f51a01f41c0c5a3c14) :recycle: (bank-sync) unify the sync/reconciliation logic for interal & external sync - [`54d2ee8`](https://github.com/actualbudget/actual/commit/54d2ee84cf284fdf255a93cb9ee65db8591d8094) Release notes - [`967c837`](https://github.com/actualbudget/actual/commit/967c837007b0d36fad77cc739bf9ba6f57022e0d) Remove unused TransactionEntity import - [`28fbe78`](https://github.com/actualbudget/actual/commit/28fbe7802b61acd9eb7bff219024c6fed21d274e) Merge branch 'master' into matiss/gocardless-unify - [`698ed1f`](https://github.com/actualbudget/actual/commit/698ed1fbc0bf2e635ff1b65a5a7967b92a5df082) Merge branch 'master' into matiss/gocardless-unify - [`0edcd09`](https://github.com/actualbudget/actual/commit/0edcd096d18c436e29d95ad2bb19131f317d743f) Feedback: update date only for internal accounts - [`df35270`](https://github.com/actualbudget/actual/commit/df35270b438f7126561ce53a69cb18141e942d07) Patch linter - [`c8a741a`](https://github.com/actualbudget/actual/commit/c8a741a9543898e36eaa17b498cc0a03a714dd75) Rename external -> bankSync and a bit of cleanup - [`25d278d`](https://github.com/actualbudget/actual/commit/25d278d5bd07f38cf61bf7972c2c833f42638f37) Remove plaid sync tests - [`d0f0b92`](https://github.com/actualbudget/actual/commit/d0f0b9237aa7c14f453d204721b7737b9f21e50f) Remove more dead code ### 📊 Changes **9 files changed** (+66 additions, -3290 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/client/actions/account.ts` (+0 -20) 📝 `packages/loot-core/src/server/accounts/__snapshots__/sync.test.ts.snap` (+0 -2503) 📝 `packages/loot-core/src/server/accounts/link.ts` (+1 -49) 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+2 -282) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+54 -302) 📝 `packages/loot-core/src/server/main.test.ts` (+0 -58) 📝 `packages/loot-core/src/server/main.ts` (+3 -62) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+0 -14) ➕ `upcoming-release-notes/2534.md` (+6 -0) </details> ### 📄 Description Unifying the reconciliation and syncing logic to reduce duplication. Previously we had `reconcileTransactions`, `reconcileExternalTransactions`, `syncAccount` and `syncExternalAccount`. Now we have only one of each. The logic there is still not exactly _clean_. But at least now we have a single place for it instead of copy&paste duplication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:15:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?