github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 04:32:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2973] [MERGED] update split transaction handling for csv export #4616

New Issue
Closed
opened 2026-02-28 20:58:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2973
Author: @wdpk
Created: 7/3/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @twk3

Base: master ← Head: csv-export-split-handling

📝 Commits (10+)

  • 35af118 Split transaction handling for csv export (#2973)
  • 2c4420d Merge branch 'master' into csv-export-split-handling
  • 1974632 Merge branch 'master' into csv-export-split-handling
  • 7801988 Merge branch 'master' into csv-export-split-handling
  • e851be9 refactor, zero-amt parents and add split_amount
  • 947ba1c build error fix
  • 8dcda9d Update export-to-csv.ts
  • 4bc2f81 Merge branch 'actualbudget:master' into csv-export-split-handling
  • 5fd408e change loop to go through an number series length of the parentsChildCound
  • 03c87b6 spelling whoospie-doodle

📊 Changes

2 files changed (+40 additions, -11 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/export-to-csv.ts (+34 -11)
➕ upcoming-release-notes/2973.md (+6 -0)

📄 Description

Fixes #522

Current behavior: when exporting to CSV, any splits (child) transactions, Payee overridden by the parent transaction, and parent transactions are specifically ignored when exporting.

This PR changes the behavior so children have a "(SPLIT x OF y) " note prefixed to their Notes, parents have a "(SPLIT INTO X) " prefixed to their Notes, and Parents are included in the export. Splits are counted by using the inverse of the sort_order.

There also seemed to be a typo. In my transactions table, it's "isChild" and "isParent" but existing logic appears to expect "is_parent". UPDATE: the "is_parent" logic is correct, but it shows as "isParent" in sqllitestudio.

Question: Do all split children have payees? I may have been a little too overzealous if not. Seems like yes though.

category: Bugfix
authors: [wdpk]

Fix exporting split transactions to CSV by including top-line transactions and noting the split.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2973 **Author:** [@wdpk](https://github.com/wdpk) **Created:** 7/3/2024 **Status:** ✅ Merged **Merged:** 7/18/2024 **Merged by:** [@twk3](https://github.com/twk3) **Base:** `master` ← **Head:** `csv-export-split-handling` --- ### 📝 Commits (10+) - [`35af118`](https://github.com/actualbudget/actual/commit/35af11809d2cc830372243ca0563cb99c7670d43) Split transaction handling for csv export (#2973) - [`2c4420d`](https://github.com/actualbudget/actual/commit/2c4420d54efd1f6e85ba32b254324ebabac750e6) Merge branch 'master' into csv-export-split-handling - [`1974632`](https://github.com/actualbudget/actual/commit/197463228931eeb32ba3629cd63110790f916285) Merge branch 'master' into csv-export-split-handling - [`7801988`](https://github.com/actualbudget/actual/commit/78019881917aa55ded2c0ea6fd7d9229cc55cc0f) Merge branch 'master' into csv-export-split-handling - [`e851be9`](https://github.com/actualbudget/actual/commit/e851be9f394cc3b90db9298e4fe3208fd0a8f4a4) refactor, zero-amt parents and add split_amount - [`947ba1c`](https://github.com/actualbudget/actual/commit/947ba1cb02a899246a0a8d37f5ae75fa38c92f7d) build error fix - [`8dcda9d`](https://github.com/actualbudget/actual/commit/8dcda9d9aecb067ee4002aac826818c3d996a32d) Update export-to-csv.ts - [`4bc2f81`](https://github.com/actualbudget/actual/commit/4bc2f81ee596044111a27b23cc6a164b1aaca671) Merge branch 'actualbudget:master' into csv-export-split-handling - [`5fd408e`](https://github.com/actualbudget/actual/commit/5fd408eea0995eed67977e2a84635b39c9bf794b) change loop to go through an number series length of the parentsChildCound - [`03c87b6`](https://github.com/actualbudget/actual/commit/03c87b699cc9b7e582ee4953ac5bc8285fbc406b) spelling whoospie-doodle ### 📊 Changes **2 files changed** (+40 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/export-to-csv.ts` (+34 -11) ➕ `upcoming-release-notes/2973.md` (+6 -0) </details> ### 📄 Description Fixes #522 Current behavior: when exporting to CSV, any splits (child) transactions, Payee overridden by the parent transaction, and parent transactions are specifically ignored when exporting. This PR changes the behavior so children have a "(SPLIT x OF y) " note prefixed to their `Notes`, parents have a "(SPLIT INTO X) " prefixed to their `Notes`, and Parents are included in the export. Splits are counted by using the inverse of the sort_order. There also seemed to be a typo. In my transactions table, it's "isChild" and "isParent" but existing logic appears to expect "is_parent". UPDATE: the "is_parent" logic is correct, but it shows as "isParent" in sqllitestudio. Question: Do all split children have payees? I may have been a little too overzealous if not. Seems like yes though. --- category: Bugfix authors: [wdpk] --- Fix exporting split transactions to CSV by including top-line transactions and noting the split. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4616
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?