github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 12:28:57 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2493] [MERGED] ♻️ (tooltip) refactored tooltip to react-aria #46152

New Issue
Closed
opened 2026-04-26 08:14:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:14:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2493
Author: @MatissJanis
Created: 3/22/2024
Status: ✅ Merged
Merged: 4/8/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-2091

📝 Commits (10+)

  • a6f1764 ♻️ (tooltip) refactored tooltip to react-aria
  • 2277b5f Release notes
  • 8cb58c0 Merge branch 'master' into matiss/fix-2091
  • 3f059ca Fix: delay when opening
  • 6198676 Refactor: better handling of hide event
  • 3c493bf Merge branch 'master' into matiss/fix-2091
  • 69a05bf Typechecker: patch duplicate import after merge
  • d8d198e Merge branch 'master' into matiss/fix-2091
  • 6fcde53 Feedback: yarn dedupe
  • 82e97f8 Merge branch 'master' into matiss/fix-2091

📊 Changes

17 files changed (+1815 additions, -365 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/components/NotesButton.tsx (+56 -82)
📝 packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx (+1 -1)
➕ packages/desktop-client/src/components/common/Tooltip.tsx (+76 -0)
📝 packages/desktop-client/src/components/common/View.tsx (+7 -4)
📝 packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx (+5 -2)
📝 packages/desktop-client/src/components/modals/CategoryMenuModal.tsx (+5 -2)
📝 packages/desktop-client/src/components/modals/Notes.tsx (+5 -1)
📝 packages/desktop-client/src/components/select/DateSelect.tsx (+7 -7)
📝 packages/desktop-client/src/components/tooltips.tsx (+3 -1)
📝 packages/desktop-client/src/style/styles.ts (+12 -3)
📝 packages/loot-core/src/client/query-hooks.tsx (+4 -1)
📝 packages/loot-core/src/types/models/index.d.ts (+1 -0)
➕ packages/loot-core/src/types/models/note.d.ts (+4 -0)
➕ upcoming-release-notes/2493.md (+6 -0)
📝 yarn.lock (+1621 -260)

📄 Description

Related to: https://github.com/actualbudget/actual/issues/2091

This refactors the Tooltip component we use internally to instead use react-aria. Initially I am refactoring only the Notes button, but the goal is to continue this migration after the initial PR is released.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2493 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/22/2024 **Status:** ✅ Merged **Merged:** 4/8/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-2091` --- ### 📝 Commits (10+) - [`a6f1764`](https://github.com/actualbudget/actual/commit/a6f176493367158b4e5fa5887f893216b4d3104c) :recycle: (tooltip) refactored tooltip to react-aria - [`2277b5f`](https://github.com/actualbudget/actual/commit/2277b5ff9985daaa658969b4581b415bd8de0779) Release notes - [`8cb58c0`](https://github.com/actualbudget/actual/commit/8cb58c083410c1463585114ef21dd3b578b7c0a6) Merge branch 'master' into matiss/fix-2091 - [`3f059ca`](https://github.com/actualbudget/actual/commit/3f059ca34e1d77ad9b715ead0ae757def553c97c) Fix: delay when opening - [`6198676`](https://github.com/actualbudget/actual/commit/619867661d88a0cc589831c804d6088a3744182f) Refactor: better handling of hide event - [`3c493bf`](https://github.com/actualbudget/actual/commit/3c493bfc2b1dc0b82a4f596ed2e465bcbf8e24f7) Merge branch 'master' into matiss/fix-2091 - [`69a05bf`](https://github.com/actualbudget/actual/commit/69a05bfdf177c1a8ae3093656c3830e06c3bc8fa) Typechecker: patch duplicate import after merge - [`d8d198e`](https://github.com/actualbudget/actual/commit/d8d198efbfa11a82a59bd222deed2ec963b2584b) Merge branch 'master' into matiss/fix-2091 - [`6fcde53`](https://github.com/actualbudget/actual/commit/6fcde538dc4e42ce46ac3a35b8420ce383959607) Feedback: yarn dedupe - [`82e97f8`](https://github.com/actualbudget/actual/commit/82e97f8e0c210dc8e3e6599931661a0c5c164f16) Merge branch 'master' into matiss/fix-2091 ### 📊 Changes **17 files changed** (+1815 additions, -365 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+56 -82) 📝 `packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx` (+1 -1) ➕ `packages/desktop-client/src/components/common/Tooltip.tsx` (+76 -0) 📝 `packages/desktop-client/src/components/common/View.tsx` (+7 -4) 📝 `packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/modals/CategoryMenuModal.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/modals/Notes.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/select/DateSelect.tsx` (+7 -7) 📝 `packages/desktop-client/src/components/tooltips.tsx` (+3 -1) 📝 `packages/desktop-client/src/style/styles.ts` (+12 -3) 📝 `packages/loot-core/src/client/query-hooks.tsx` (+4 -1) 📝 `packages/loot-core/src/types/models/index.d.ts` (+1 -0) ➕ `packages/loot-core/src/types/models/note.d.ts` (+4 -0) ➕ `upcoming-release-notes/2493.md` (+6 -0) 📝 `yarn.lock` (+1621 -260) </details> ### 📄 Description Related to: https://github.com/actualbudget/actual/issues/2091 This refactors the `Tooltip` component we use internally to instead use react-aria. Initially I am refactoring only the `Notes` button, but the goal is to continue this migration after the initial PR is released. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:14:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46152
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?