[PR #2416] [MERGED] (bank-sync) quality of life improvements for sync #46113

Closed
opened 2026-04-26 08:12:56 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2416
Author: @MatissJanis
Created: 3/3/2024
Status: Merged
Merged: 3/4/2024
Merged by: @MatissJanis

Base: masterHead: matiss/sync-qol


📝 Commits (3)

  • 48707e7 (bank-sync) quality of life improvements for sync
  • cca10c2 Remove unused redux action
  • 696fc07 Release notes

📊 Changes

17 files changed (+121 additions, -142 deletions)

View changed files

📝 packages/desktop-client/src/components/BankSyncStatus.tsx (+15 -14)
📝 packages/desktop-client/src/components/accounts/Account.jsx (+1 -1)
📝 packages/desktop-client/src/components/accounts/Header.jsx (+3 -2)
📝 packages/desktop-client/src/components/sidebar/Account.tsx (+7 -3)
📝 packages/desktop-client/src/components/sidebar/Accounts.tsx (+7 -0)
📝 packages/desktop-client/src/style/themes/dark.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/development.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/light.ts (+1 -0)
📝 packages/desktop-client/src/style/themes/midnight.ts (+1 -0)
📝 packages/loot-core/src/client/actions/account.ts (+68 -84)
📝 packages/loot-core/src/client/actions/sync.ts (+1 -1)
📝 packages/loot-core/src/client/constants.ts (+0 -1)
📝 packages/loot-core/src/client/reducers/account.ts (+2 -13)
📝 packages/loot-core/src/client/state-types/account.d.ts (+3 -15)
📝 packages/loot-core/src/server/main.ts (+3 -7)
📝 packages/loot-core/src/types/server-handlers.d.ts (+1 -1)
upcoming-release-notes/2416.md (+6 -0)

📄 Description

Small quality of life improvements for bank-sync and a bit of refactoring to facilitate this functionality.

  • added a counter to the toast popover so it's easy to follow the sync progress
  • account transactions get pulled in immediately after sync (as opposed to having sit and wait for all accounts to finish)
  • show yellow progress indicator in the sidebar for accounts that are not yet synced
Screenshot 2024-03-03 at 21 24 27 Screenshot 2024-03-03 at 21 24 19

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2416 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/sync-qol` --- ### 📝 Commits (3) - [`48707e7`](https://github.com/actualbudget/actual/commit/48707e7eda3c8aba7d213f056d725b9a7551966a) :sparkles: (bank-sync) quality of life improvements for sync - [`cca10c2`](https://github.com/actualbudget/actual/commit/cca10c29fb6fcf570e0dfac24bdb295efef7e45e) Remove unused redux action - [`696fc07`](https://github.com/actualbudget/actual/commit/696fc074289b7fc02e538561851e377fd2194726) Release notes ### 📊 Changes **17 files changed** (+121 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/BankSyncStatus.tsx` (+15 -14) 📝 `packages/desktop-client/src/components/accounts/Account.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Header.jsx` (+3 -2) 📝 `packages/desktop-client/src/components/sidebar/Account.tsx` (+7 -3) 📝 `packages/desktop-client/src/components/sidebar/Accounts.tsx` (+7 -0) 📝 `packages/desktop-client/src/style/themes/dark.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/development.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/light.ts` (+1 -0) 📝 `packages/desktop-client/src/style/themes/midnight.ts` (+1 -0) 📝 `packages/loot-core/src/client/actions/account.ts` (+68 -84) 📝 `packages/loot-core/src/client/actions/sync.ts` (+1 -1) 📝 `packages/loot-core/src/client/constants.ts` (+0 -1) 📝 `packages/loot-core/src/client/reducers/account.ts` (+2 -13) 📝 `packages/loot-core/src/client/state-types/account.d.ts` (+3 -15) 📝 `packages/loot-core/src/server/main.ts` (+3 -7) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+1 -1) ➕ `upcoming-release-notes/2416.md` (+6 -0) </details> ### 📄 Description Small quality of life improvements for bank-sync and a bit of refactoring to facilitate this functionality. - added a counter to the toast popover so it's easy to follow the sync progress - account transactions get pulled in immediately after sync (as opposed to having sit and wait for all accounts to finish) - show yellow progress indicator in the sidebar for accounts that are not yet synced <img width="150" alt="Screenshot 2024-03-03 at 21 24 27" src="https://github.com/actualbudget/actual/assets/886567/92180c91-16d3-4b52-84f9-4529a0394551"> <img width="256" alt="Screenshot 2024-03-03 at 21 24 19" src="https://github.com/actualbudget/actual/assets/886567/b1e64d84-d8ad-4ef9-bcbc-4c10bea95d0c"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:12:56 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#46113