github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2073] [MERGED] [TS migration] Reafactor tooltips.js to use typescript #45921

New Issue
Closed
opened 2026-04-26 08:01:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 08:01:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2073
Author: @IzStriker
Created: 12/12/2023
Status: ✅ Merged
Merged: 12/17/2023
Merged by: @MatissJanis

Base: master ← Head: reafactor-tooltips

📝 Commits (10+)

  • 9badcd3 refactor tooltips: wip
  • b4cae6b refactor: convert tooltip.js to tsx
  • 6e4bcc1 fix: type errors
  • e640c6c fix: fix type errors
  • 5419676 Merge branch 'master' into reafactor-tooltips
  • 6c52660 refactor: remove declare
  • 96ba312 Merge branch 'reafactor-tooltips' of github.com:IzStriker/actual into reafactor-tooltips
  • 0889f2c chore: update release notes
  • a571f9e Merge branch 'master' into reafactor-tooltips
  • 1b85ed2 fix: implement feedback

📊 Changes

3 files changed (+83 additions, -14 deletions)

View changed files

📝 packages/desktop-client/src/components/NotesButton.tsx (+3 -3)
📝 packages/desktop-client/src/components/tooltips.tsx (+74 -11)
➕ upcoming-release-notes/2073.md (+6 -0)

📄 Description

Link to: #1483

Converted tooltips.js to tooltips.tsx and created types where I was able to work them out.

Let me know if you have any feedback

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2073 **Author:** [@IzStriker](https://github.com/IzStriker) **Created:** 12/12/2023 **Status:** ✅ Merged **Merged:** 12/17/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `reafactor-tooltips` --- ### 📝 Commits (10+) - [`9badcd3`](https://github.com/actualbudget/actual/commit/9badcd312834fed986228cfa1343549f7672f56f) refactor tooltips: wip - [`b4cae6b`](https://github.com/actualbudget/actual/commit/b4cae6ba3410ebc825ebbf29f05fcce91e3e300a) refactor: convert tooltip.js to tsx - [`6e4bcc1`](https://github.com/actualbudget/actual/commit/6e4bcc1fbaf221d95f47e2d65fae175f64ab1a6a) fix: type errors - [`e640c6c`](https://github.com/actualbudget/actual/commit/e640c6cb49897c8e744fa05fca6df948d8d2ab58) fix: fix type errors - [`5419676`](https://github.com/actualbudget/actual/commit/5419676564443d601c374f980c3324322b6b4f6b) Merge branch 'master' into reafactor-tooltips - [`6c52660`](https://github.com/actualbudget/actual/commit/6c52660fde94765c40d248a21cc92f4faf60e7ca) refactor: remove declare - [`96ba312`](https://github.com/actualbudget/actual/commit/96ba312a9e044620cadab5948e2b2bcfe24b5ff6) Merge branch 'reafactor-tooltips' of github.com:IzStriker/actual into reafactor-tooltips - [`0889f2c`](https://github.com/actualbudget/actual/commit/0889f2c09a4f6172c428a8dabea6f509ff64d301) chore: update release notes - [`a571f9e`](https://github.com/actualbudget/actual/commit/a571f9eda94873092c7a4b095e015c432590e567) Merge branch 'master' into reafactor-tooltips - [`1b85ed2`](https://github.com/actualbudget/actual/commit/1b85ed220ac34adcacfb8a3c4971d61313ba8a4a) fix: implement feedback ### 📊 Changes **3 files changed** (+83 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/tooltips.tsx` (+74 -11) ➕ `upcoming-release-notes/2073.md` (+6 -0) </details> ### 📄 Description Link to: #1483 Converted tooltips.js to tooltips.tsx and created types where I was able to work them out. Let me know if you have any feedback --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 08:01:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#45921
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?