github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2905] [MERGED] ♻️ refactoring Select component to use existing Menu #4582

New Issue
Closed
opened 2026-02-28 20:58:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:58:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2905
Author: @MatissJanis
Created: 6/19/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/remove-reach-listbox

📝 Commits (8)

  • aaa41a2 ♻️ refactoring Select component to use existing Menu
  • f8118be Patches & release notes
  • 13a72e5 Fix lint
  • c625fe9 Add missing features
  • 34e8be9 Patch e2e tests
  • b4ae93f Merge branch 'master' into matiss/remove-reach-listbox
  • 63a2b58 Update placement
  • ceec1c1 Merge branch 'master' into matiss/remove-reach-listbox

📊 Changes

26 files changed (+159 additions, -339 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/rules-page.js (+3 -3)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/package.json (+0 -1)
📝 packages/desktop-client/src/components/common/Popover.tsx (+0 -8)
📝 packages/desktop-client/src/components/common/Select.tsx (+90 -121)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+0 -2)
📝 packages/desktop-client/src/components/modals/EditRule.jsx (+30 -20)
📝 packages/desktop-client/src/components/modals/ImportTransactions.jsx (+3 -5)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+16 -10)

...and 6 more files

📄 Description

Refactoring the Select component to use the existing Menu, Popover and Button components. This allows us to remove the @reach/listbox dependency.

There is a slight visual difference. I think the new variation looks better (and more consistent), but LMK if you disagree and we can style it to match the old one.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2905 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 6/19/2024 **Status:** ✅ Merged **Merged:** 7/3/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/remove-reach-listbox` --- ### 📝 Commits (8) - [`aaa41a2`](https://github.com/actualbudget/actual/commit/aaa41a24d371cfa2731bf1a7141638aa7915f6ed) :recycle: refactoring Select component to use existing Menu - [`f8118be`](https://github.com/actualbudget/actual/commit/f8118be0a1eadb932e0358f627b5da4b46b9dbce) Patches & release notes - [`13a72e5`](https://github.com/actualbudget/actual/commit/13a72e513dd3d57edea4ebaf946be8e091a5f00e) Fix lint - [`c625fe9`](https://github.com/actualbudget/actual/commit/c625fe9a5273cd643e42e0ed71cb5e75dbeef88e) Add missing features - [`34e8be9`](https://github.com/actualbudget/actual/commit/34e8be91a16ee25c79efdb54722b85f9ae5e3936) Patch e2e tests - [`b4ae93f`](https://github.com/actualbudget/actual/commit/b4ae93f47b8956600a48ee20bfca9555833824f5) Merge branch 'master' into matiss/remove-reach-listbox - [`63a2b58`](https://github.com/actualbudget/actual/commit/63a2b58b684cac49c9437a2a0374f78840fe70f6) Update placement - [`ceec1c1`](https://github.com/actualbudget/actual/commit/ceec1c115111248a6ef4024737b1f173c74ef07a) Merge branch 'master' into matiss/remove-reach-listbox ### 📊 Changes **26 files changed** (+159 additions, -339 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/rules-page.js` (+3 -3) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.test.js-snapshots/Transactions-filters-transactions-by-date-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/package.json` (+0 -1) 📝 `packages/desktop-client/src/components/common/Popover.tsx` (+0 -8) 📝 `packages/desktop-client/src/components/common/Select.tsx` (+90 -121) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+0 -2) 📝 `packages/desktop-client/src/components/modals/EditRule.jsx` (+30 -20) 📝 `packages/desktop-client/src/components/modals/ImportTransactions.jsx` (+3 -5) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+16 -10) _...and 6 more files_ </details> ### 📄 Description Refactoring the `Select` component to use the existing `Menu`, `Popover` and `Button` components. This allows us to remove the `@reach/listbox` dependency. There is a slight visual difference. I think the new variation looks better (and more consistent), but LMK if you disagree and we can style it to match the old one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:58:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?