github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 12:30:06 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2891] [MERGED] Timeout SimpleFIN sync calls after 60 seconds #4571

New Issue
Closed
opened 2026-02-28 20:57:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:57:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2891
Author: @psybers
Created: 6/16/2024
Status: ✅ Merged
Merged: 6/18/2024
Merged by: @MatissJanis

Base: master ← Head: timeout-sync

📝 Commits (10+)

📊 Changes

6 files changed (+69 additions, -34 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx (+6 -0)
📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+35 -25)
📝 packages/loot-core/src/server/accounts/sync.ts (+1 -0)
📝 packages/loot-core/src/server/main.ts (+15 -8)
📝 packages/loot-core/src/server/post.ts (+6 -1)
➕ upcoming-release-notes/2891.md (+6 -0)

📄 Description

Currently, if something goes wrong with the bank sync, the client essentially just 'hangs' while trying to sync and shows the account(s) as trying to sync forever. They do not seem to time out.

This places a 60-second limit on the call, and if it times out it then proceeds to indicate the link might be broken and users should relink the account.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2891 **Author:** [@psybers](https://github.com/psybers) **Created:** 6/16/2024 **Status:** ✅ Merged **Merged:** 6/18/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `timeout-sync` --- ### 📝 Commits (10+) - [`15d36da`](https://github.com/actualbudget/actual/commit/15d36da6f90ec9ad5039b8ffee59fcca94de93f1) Timeout SimpleFIN sync calls after 60 seconds - [`3575d3c`](https://github.com/actualbudget/actual/commit/3575d3ca374472af81e78581d1ba6b55818fe9f1) add release note - [`b4a5b5d`](https://github.com/actualbudget/actual/commit/b4a5b5d8d4712b8c5fc21d62a6d27fa8c3b687bf) Show better error message. - [`a3ab8e1`](https://github.com/actualbudget/actual/commit/a3ab8e19cee2e3f30077f70815c943086d7a1eeb) Fix linter - [`9809e48`](https://github.com/actualbudget/actual/commit/9809e48462950ea0a1db192d7a0f65e6ca8d33f4) Better error messages - [`d52fec0`](https://github.com/actualbudget/actual/commit/d52fec0cd669020a3b10324044764d11e655281a) Make sure account linking times out too. - [`9178f88`](https://github.com/actualbudget/actual/commit/9178f88eda6620149ddee4a69fca583c681505da) one error, ask for a new token - [`d419c99`](https://github.com/actualbudget/actual/commit/d419c990fa9246dacec433cfa3d89fed14d385c3) Set timeout to 60 seconds - [`2677a57`](https://github.com/actualbudget/actual/commit/2677a5746cd6a461a72d97ead001da63703a04d2) Add error message - [`3a2a37b`](https://github.com/actualbudget/actual/commit/3a2a37bf918ea708473dfba076c7499f1d4ff41f) fix linter ### 📊 Changes **6 files changed** (+69 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx` (+6 -0) 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+35 -25) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+1 -0) 📝 `packages/loot-core/src/server/main.ts` (+15 -8) 📝 `packages/loot-core/src/server/post.ts` (+6 -1) ➕ `upcoming-release-notes/2891.md` (+6 -0) </details> ### 📄 Description Currently, if something goes wrong with the bank sync, the client essentially just 'hangs' while trying to sync and shows the account(s) as trying to sync forever. They do not seem to time out. This places a 60-second limit on the call, and if it times out it then proceeds to indicate the link might be broken and users should relink the account. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:57:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?