[PR #1657] [MERGED] 🐛 (signup) fix setting up for the first time with missing protocol #45696

Closed
opened 2026-04-26 07:50:06 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1657
Author: @MatissJanis
Created: 9/5/2023
Status: Merged
Merged: 9/7/2023
Merged by: @MatissJanis

Base: masterHead: matiss/fix-signup


📝 Commits (2)

  • 2cc49a8 🐛 (signup) fix setting up for the first time with missing protocol
  • 32ac1af Release notes

📊 Changes

4 files changed (+14 additions, -5 deletions)

View changed files

📝 packages/desktop-client/src/components/manager/ConfigServer.tsx (+1 -1)
📝 packages/loot-core/src/server/main.ts (+6 -2)
📝 packages/loot-core/src/server/server-config.ts (+1 -2)
upcoming-release-notes/1657.md (+6 -0)

📄 Description

Reproduction:

  1. open demo
  2. when prompted for server: enter xxxxxxxx.fly.dev (important: WITHOUT http/https protocol)
  3. click "login"
  4. branch demo link will work; master demo link will blow up

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1657 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/5/2023 **Status:** ✅ Merged **Merged:** 9/7/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-signup` --- ### 📝 Commits (2) - [`2cc49a8`](https://github.com/actualbudget/actual/commit/2cc49a8c341e666de7b8cdd22872b668cb1d380c) :bug: (signup) fix setting up for the first time with missing protocol - [`32ac1af`](https://github.com/actualbudget/actual/commit/32ac1afb2b34c8963df9dbde69ec5529ac82d027) Release notes ### 📊 Changes **4 files changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/manager/ConfigServer.tsx` (+1 -1) 📝 `packages/loot-core/src/server/main.ts` (+6 -2) 📝 `packages/loot-core/src/server/server-config.ts` (+1 -2) ➕ `upcoming-release-notes/1657.md` (+6 -0) </details> ### 📄 Description Reproduction: 1. open demo 2. when prompted for server: enter `xxxxxxxx.fly.dev` (important: WITHOUT http/https protocol) 3. click "login" 4. branch demo link will work; master demo link will blow up --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 07:50:06 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#45696