[PR #2871] [MERGED] Custom Reports: Adjust Net values #4563

New Issue

2026-02-28T20:57:42-06:00

GiteaMirror commented

2026-02-28 20:57:42 -06:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2871
Author: @carkom
Created: 6/12/2024
Status: ✅ Merged
Merged: 6/24/2024
Merged by: @carkom

Base: master ← Head: CR-AddNet

📝 Commits (10+)

ff8f07f Add Net value
ffca82b notes
f41198a fix
2de1288 Merge branch 'master' into CR-AddNet
57109d0 revert changes
7512ff4 balanceTypeOpType
6c2eb34 lint fix
da9485b add net numbers
ab73080 Merge branch 'master' into CR-AddNet
e10406c bar fix

📊 Changes

22 files changed (+210 additions, -52 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+2 -0)
📝 packages/desktop-client/src/components/reports/ReportSummary.tsx (+12 -5)
📝 packages/desktop-client/src/components/reports/disabledList.ts (+4 -4)
📝 packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx (+21 -4)
📝 packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (+28 -7)
📝 packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx (+6 -3)
📝 packages/desktop-client/src/components/reports/graphs/LineGraph.tsx (+5 -2)
📝 packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx (+6 -2)
📝 packages/desktop-client/src/components/reports/graphs/showActivity.ts (+7 -5)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx (+2 -1)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableHeader.tsx (+5 -2)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableList.tsx (+2 -0)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx (+5 -2)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx (+2 -0)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+3 -2)
📝 packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts (+2 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts (+39 -6)
📝 packages/desktop-client/src/components/reports/spreadsheets/filterEmptyRows.ts (+5 -2)
📝 packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts (+24 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/recalculate.ts (+11 -3)

...and 2 more files

📄 Description

There have been many comments - both in github and discord - that a net number is needed. I agree with this sentiment so I'm trying to find the best way to fix it.

~~This is a POC. There's many little visual/UI issues currently - I'll fix those once the implementation is agreed on.~~

I'm looking for feedback at a high level. How do you think this feature should work?
Current state: Payments/Deposits are separated and the "Net" number is only available on certain graphs.
Proposal: Payments/Deposits should act as "Net Payments" and "Net Deposits" while constraining the value to only positive or negative final values. "Net" shows all transactions together. Current state can be mimicked by using a filter (inflow/outflow greater than zero).
Alternate option: Leave current state unchanged and add options under the "Type" drop down for "Net Payment" and "Net Deposit".

Please have a look, play around with it and let me know what you think!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2871 **Author:** [@carkom](https://github.com/carkom) **Created:** 6/12/2024 **Status:** ✅ Merged **Merged:** 6/24/2024 **Merged by:** [@carkom](https://github.com/carkom) **Base:** `master` ← **Head:** `CR-AddNet` --- ### 📝 Commits (10+) - [`ff8f07f`](https://github.com/actualbudget/actual/commit/ff8f07fba6f7514fe13e358677dd81e53e826749) Add Net value - [`ffca82b`](https://github.com/actualbudget/actual/commit/ffca82b93d86701d64e954b5091aa2f1746695e6) notes - [`f41198a`](https://github.com/actualbudget/actual/commit/f41198a7e39f3adc71b4704e97d5d3c3d4c51e1f) fix - [`2de1288`](https://github.com/actualbudget/actual/commit/2de1288043268fd0e2ad5f46dfe783a0b53b5411) Merge branch 'master' into CR-AddNet - [`57109d0`](https://github.com/actualbudget/actual/commit/57109d08e2ee4cb571b9767a143364f8a02a21db) revert changes - [`7512ff4`](https://github.com/actualbudget/actual/commit/7512ff4dc37d077ad82c3eebffcaff4b1f83b2bf) balanceTypeOpType - [`6c2eb34`](https://github.com/actualbudget/actual/commit/6c2eb344b2a7973a7b1186acc9f4236cede6da1a) lint fix - [`da9485b`](https://github.com/actualbudget/actual/commit/da9485b187557f590f736cf3b3eaa1fac3eb054c) add net numbers - [`ab73080`](https://github.com/actualbudget/actual/commit/ab73080e747db01601bf12a4e417b8ecfb82198f) Merge branch 'master' into CR-AddNet - [`e10406c`](https://github.com/actualbudget/actual/commit/e10406cddbfe6a242c323b39c2adf6d50bab9574) bar fix ### 📊 Changes **22 files changed** (+210 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+2 -0) 📝 `packages/desktop-client/src/components/reports/ReportSummary.tsx` (+12 -5) 📝 `packages/desktop-client/src/components/reports/disabledList.ts` (+4 -4) 📝 `packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx` (+21 -4) 📝 `packages/desktop-client/src/components/reports/graphs/BarGraph.tsx` (+28 -7) 📝 `packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx` (+6 -3) 📝 `packages/desktop-client/src/components/reports/graphs/LineGraph.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx` (+6 -2) 📝 `packages/desktop-client/src/components/reports/graphs/showActivity.ts` (+7 -5) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableHeader.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableList.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx` (+5 -2) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/reports/spreadsheets/calculateLegend.ts` (+2 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts` (+39 -6) 📝 `packages/desktop-client/src/components/reports/spreadsheets/filterEmptyRows.ts` (+5 -2) 📝 `packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts` (+24 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/recalculate.ts` (+11 -3) _...and 2 more files_ </details> ### 📄 Description There have been many comments - both in github and discord - that a net number is needed. I agree with this sentiment so I'm trying to find the best way to fix it. ~~This is a POC. There's many little visual/UI issues currently - I'll fix those once the implementation is agreed on.~~ ~~I'm looking for feedback at a high level. How do you think this feature should work? **Current state:** Payments/Deposits are separated and the "Net" number is only available on certain graphs. **Proposal:** Payments/Deposits should act as "Net Payments" and "Net Deposits" while constraining the value to only positive or negative final values. "Net" shows all transactions together. Current state can be mimicked by using a filter (inflow/outflow greater than zero). **Alternate option:** Leave current state unchanged and add options under the "Type" drop down for "Net Payment" and "Net Deposit".~~ Please have a look, play around with it and let me know what you think! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-02-28 20:57:42 -06:00

GiteaMirror closed this issue