github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1350] [MERGED] Add per-category button to fill budget cells, including Goal template support #45502

New Issue
Closed
opened 2026-04-26 07:36:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 07:36:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1350
Author: @shall0pass
Created: 7/16/2023
Status: ✅ Merged
Merged: 7/27/2023
Merged by: @j-f1

Base: master ← Head: applySingleCategoryGoal

📝 Commits (10+)

📊 Changes

8 files changed (+449 additions, -126 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/report/components.tsx (+144 -48)
📝 packages/desktop-client/src/components/budget/rollover/rollover-components.tsx (+142 -47)
📝 packages/loot-core/src/client/actions/queries.ts (+35 -8)
📝 packages/loot-core/src/server/budget/actions.ts (+27 -0)
📝 packages/loot-core/src/server/budget/app.ts (+9 -0)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+68 -19)
📝 packages/loot-core/src/server/budget/types/handlers.d.ts (+18 -4)
➕ upcoming-release-notes/1350.md (+6 -0)

📄 Description

I don't think this will pass code review as is and will need some input to get it finished. I added a button to the category drop down "Apply Goal Template" to apply a single template to the budget.

I wasn't sure exactly sure how the UX should be interpreted if multiple months are shown, so currently it will only calculate for the current month.
I think a button in the budget cell makes more sense.

If we can get this to work, it'll close https://github.com/actualbudget/actual/issues/958 and
https://github.com/actualbudget/actual/issues/682

This PR has changed significantly since I started it. It now includes per category options that were previously only found in the budget summary menu. I've added a few more, but happy to remove or modify what I have. In light of these changes, I'm going to change the PR title.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1350 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 7/16/2023 **Status:** ✅ Merged **Merged:** 7/27/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `applySingleCategoryGoal` --- ### 📝 Commits (10+) - [`7e36ea2`](https://github.com/actualbudget/actual/commit/7e36ea2bbd7f4628673eefa577f0a740e278c7ee) speed improvements - [`26f35d4`](https://github.com/actualbudget/actual/commit/26f35d4baaa2e85b0be503cf19d83b30e9d8e117) initial single category goal apply - [`3fb74c8`](https://github.com/actualbudget/actual/commit/3fb74c82811037c6142553c35d3443ffb70e5a19) lint - [`5669142`](https://github.com/actualbudget/actual/commit/5669142febf146716144f22623785319b92bac8c) Merge branch 'master' into applySingleCategoryGoal - [`5705ee3`](https://github.com/actualbudget/actual/commit/5705ee3674a5cacf424df53f748e2a3e2f48d53f) fixup / simplify function reuse - [`f3081a2`](https://github.com/actualbudget/actual/commit/f3081a23319e3aa53ef93de7243b988ba9a329e5) remove console log - [`61e174d`](https://github.com/actualbudget/actual/commit/61e174d2d4a3656dcf78bd23fc25a42bfc8b70cf) update button text to match other buttons - [`86d0d91`](https://github.com/actualbudget/actual/commit/86d0d91f8bec7a8534919cc1bcf76ea4ab34a5da) release note - [`8af1966`](https://github.com/actualbudget/actual/commit/8af1966eefa1c6da171ccf8f73cb39cb59cb15df) initial - [`e658563`](https://github.com/actualbudget/actual/commit/e658563a7ff913e9c0db380ecce857f6357125c9) chevrons in budget cells ### 📊 Changes **8 files changed** (+449 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/report/components.tsx` (+144 -48) 📝 `packages/desktop-client/src/components/budget/rollover/rollover-components.tsx` (+142 -47) 📝 `packages/loot-core/src/client/actions/queries.ts` (+35 -8) 📝 `packages/loot-core/src/server/budget/actions.ts` (+27 -0) 📝 `packages/loot-core/src/server/budget/app.ts` (+9 -0) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+68 -19) 📝 `packages/loot-core/src/server/budget/types/handlers.d.ts` (+18 -4) ➕ `upcoming-release-notes/1350.md` (+6 -0) </details> ### 📄 Description I don't think this will pass code review as is and will need some input to get it finished. I added a button to the category drop down "Apply Goal Template" to apply a single template to the budget. ~~I wasn't sure exactly sure how the UX should be interpreted if multiple months are shown, so currently it will only calculate for the current month.~~ I think a button in the budget cell makes more sense. If we can get this to work, it'll close https://github.com/actualbudget/actual/issues/958 and https://github.com/actualbudget/actual/issues/682 This PR has changed significantly since I started it. It now includes per category options that were previously only found in the budget summary menu. I've added a few more, but happy to remove or modify what I have. In light of these changes, I'm going to change the PR title. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 07:36:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#45502
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?