github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2836] [MERGED] Handle Null Org Domain in SimpleFIN for bank_id #4540

New Issue
Closed
opened 2026-02-28 20:57:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:57:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2836
Author: @duplaja
Created: 6/4/2024
Status: ✅ Merged
Merged: 6/10/2024
Merged by: @youngcw

Base: master ← Head: actual-fix-missing-simplefi-bank-id

📝 Commits (7)

  • 8e51f6e Update main.ts - Handle Null Org Domain in SimpleFIN
  • 48fa228 Create 2836.md
  • 6927767 Fix release notes format.
  • 86f454d Small change to release note.
  • eb3d396 Merge branch 'master' into actual-fix-missing-simplefi-bank-id
  • d6f23cc Change to use new org Id as fallback for bank_id
  • 07e8b37 Add orgId property, for new org id from SimpleFIN

📊 Changes

3 files changed (+9 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+2 -0)
📝 packages/loot-core/src/server/main.ts (+1 -1)
➕ upcoming-release-notes/2836.md (+6 -0)

📄 Description

SimpleFIN (currently) uses the org domain as the bank ID. According to SimpleFIN docs, this can possibly be a null value, as can the org name. However, at least one of the two must be present. (See: https://www.simplefin.org/protocol.html#organization )

In Actual, org name is set to "Unknown" if it comes in as null, but the bank_id (previously just set to the org domain) was not, resulting in a null bank_id value at times.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2836 **Author:** [@duplaja](https://github.com/duplaja) **Created:** 6/4/2024 **Status:** ✅ Merged **Merged:** 6/10/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `actual-fix-missing-simplefi-bank-id` --- ### 📝 Commits (7) - [`8e51f6e`](https://github.com/actualbudget/actual/commit/8e51f6e52cb752f9972b8b6eb70c6722f2f0885d) Update main.ts - Handle Null Org Domain in SimpleFIN - [`48fa228`](https://github.com/actualbudget/actual/commit/48fa22894e6bf72ab012304cae9b8e6fc062a311) Create 2836.md - [`6927767`](https://github.com/actualbudget/actual/commit/69277672d1fb0f5c34b40068aa77e33952e6f19e) Fix release notes format. - [`86f454d`](https://github.com/actualbudget/actual/commit/86f454dca7a2e82c1a571cf077e83dadd53e62d9) Small change to release note. - [`eb3d396`](https://github.com/actualbudget/actual/commit/eb3d3963252558e01df2eff1639c9303a29b46ee) Merge branch 'master' into actual-fix-missing-simplefi-bank-id - [`d6f23cc`](https://github.com/actualbudget/actual/commit/d6f23ccb279d89f680f0123b9196c4f76799b9af) Change to use new org Id as fallback for bank_id - [`07e8b37`](https://github.com/actualbudget/actual/commit/07e8b37fe5c857bc45b7076b775fac9b14630840) Add orgId property, for new org id from SimpleFIN ### 📊 Changes **3 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+2 -0) 📝 `packages/loot-core/src/server/main.ts` (+1 -1) ➕ `upcoming-release-notes/2836.md` (+6 -0) </details> ### 📄 Description SimpleFIN (currently) uses the org domain as the bank ID. According to SimpleFIN docs, this can possibly be a null value, as can the org name. However, at least one of the two must be present. (See: https://www.simplefin.org/protocol.html#organization ) In Actual, org name is set to "Unknown" if it comes in as null, but the bank_id (previously just set to the org domain) was not, resulting in a null bank_id value at times. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:57:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?