[PR #2643] Fix amount filter to include both incoming and outgoing amounts #4429

Closed
opened 2026-02-28 20:55:42 -06:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/actualbudget/actual/pull/2643

State: closed
Merged: Yes


Hi folks, this address #1935, which had some confusing UX. I also added some simple tests to verify the behavior.

I want to acknowledge that changing it in the transaction rules may not be the best spot, I don't have a ton of context on this repo yet. I also considered updating the filter to allow using oneOf behind the scenes for the number type, but that seemed to have more knock on effects that weren't as obvious.

Happy to update the logic if there is a better approach. Thank you!

**Original Pull Request:** https://github.com/actualbudget/actual/pull/2643 **State:** closed **Merged:** Yes --- <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Hi folks, this address #1935, which had some confusing UX. I also added some simple tests to verify the behavior. I want to acknowledge that changing it in the transaction rules may not be the best spot, I don't have a ton of context on this repo yet. I also considered updating the filter to allow using `oneOf` behind the scenes for the number type, but that seemed to have more knock on effects that weren't as obvious. Happy to update the logic if there is a better approach. Thank you!
GiteaMirror added the pull-request label 2026-02-28 20:55:42 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4429