github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-15 15:52:00 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[GH-ISSUE #5739] [Bug]: 1Password autofilling split transactions #44140

New Issue
Closed
opened 2026-04-26 05:05:43 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-26 05:05:43 -05:00
Owner
Copy Link

Originally created by @cavazos-apps on GitHub (Sep 17, 2025).
Original GitHub issue: https://github.com/actualbudget/actual/issues/5739

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When entering amounts for a split transaction, 1Password tries to autofill.

Image

How can we reproduce the issue?

Install 1Password, enter split transaction amounts.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Windows 11

Originally created by @cavazos-apps on GitHub (Sep 17, 2025). Original GitHub issue: https://github.com/actualbudget/actual/issues/5739 ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? When entering amounts for a split transaction, 1Password tries to autofill. <img width="748" height="89" alt="Image" src="https://github.com/user-attachments/assets/0bf54f21-1656-485d-8814-bed97b2c1aa2" /> ### How can we reproduce the issue? Install 1Password, enter split transaction amounts. ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox ### Operating System Windows 11
GiteaMirror added the upstreambuggood first issue labels 2026-04-26 05:05:43 -05:00
GiteaMirror commented 2026-04-26 05:05:45 -05:00
Author
Owner
Copy Link

@joel-jeremy commented on GitHub (Sep 18, 2025):

A PR to add data-1p-ignore HTML attribute can be done to instruct 1Password to ignore autofill

<!-- gh-comment-id:3308745554 --> @joel-jeremy commented on GitHub (Sep 18, 2025): A PR to add `data-1p-ignore` HTML attribute can be done to instruct 1Password to ignore autofill
GiteaMirror commented 2026-04-26 05:05:45 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Sep 23, 2025):

@cursor fix this issue by adding data-1p-ignore attribute to the amounts input fields in the transaction table

<!-- gh-comment-id:3325428513 --> @MatissJanis commented on GitHub (Sep 23, 2025): @cursor fix this issue by adding `data-1p-ignore` attribute to the amounts input fields in the transaction table
GiteaMirror commented 2026-04-26 05:05:46 -05:00
Author
Owner
Copy Link

@cursor[bot] commented on GitHub (Sep 23, 2025):

Create PR

I modified the TransactionsTable component to enhance user experience by preventing password managers from interfering with the debit and credit amount input fields. This ensures a smoother data entry process for financial transactions.

  • In packages/desktop-client/src/components/transactions/TransactionsTable.tsx, I added the data-1p-ignore: true attribute to the inputProps object for both the debit and credit CurrencyInput components within the Transaction row.
  • This change explicitly tells password managers (e.g., 1Password) to ignore these specific input fields, preventing them from attempting to autofill or suggest values in sensitive financial entry fields.

4 tasks completed

  • Explore the codebase structure to understand where transaction components are located
  • Find the transaction table component and specifically the split transaction input fields
  • Add data-1p-ignore attribute to the amounts input fields in split transactions
  • Test the changes to ensure they work correctly
    Open in Cursor Open in Web

Learn more about Cursor Agents

<!-- gh-comment-id:3325428736 --> @cursor[bot] commented on GitHub (Sep 23, 2025): [Create PR](https://github.com/actualbudget/actual/compare/master...cursor/add-data-1p-ignore-to-transaction-amounts-4ca3?expand=1&title=Add%20data-1p-ignore%20to%20transaction%20amounts&body=%3C!--%20Thank%20you%20for%20submitting%20a%20pull%20request!%20Make%20sure%20to%20follow%20the%20instructions%20to%20write%20release%20notes%20for%20your%20PR%20%E2%80%94%20it%20should%20only%20take%20a%20minute%20or%20two%3A%20https%3A%2F%2Fgithub.com%2Factualbudget%2Fdocs%23writing-good-release-notes.%20Try%20running%20yarn%20generate%3Arelease-notes%20*before*%20pushing%20your%20PR%20for%20an%20interactive%20experience.%20--%3E%0A%0AThis%20PR%20resolves%20the%20issue%20where%201Password%20attempts%20to%20autofill%20amount%20fields%20in%20split%20transactions.%0A%0ABy%20adding%20the%20%60data-1p-ignore%60%20attribute%20to%20the%20debit%20and%20credit%20input%20fields%20in%20the%20transaction%20table%2C%20we%20instruct%201Password%20to%20ignore%20these%20fields%2C%20preventing%20unwanted%20autofill%20behavior.%20Type%20assertions%20(%60as%20Record%3Cstring%2C%20unknown%3E%60)%20were%20used%20for%20TypeScript%20compatibility.%0A%0A---%0A%3Ca%20href%3D%22https%3A%2F%2Fcursor.com%2Fbackground-agent%3FbcId%3Dbc-8d6e17c1-2869-4191-bce2-0bb77738f34a%22%3E%3Cpicture%3E%3Csource%20media%3D%22(prefers-color-scheme%3A%20dark)%22%20srcset%3D%22https%3A%2F%2Fcursor.com%2Fopen-in-cursor-dark.svg%22%3E%3Csource%20media%3D%22(prefers-color-scheme%3A%20light)%22%20srcset%3D%22https%3A%2F%2Fcursor.com%2Fopen-in-cursor-light.svg%22%3E%3Cimg%20alt%3D%22Open%20in%20Cursor%22%20src%3D%22https%3A%2F%2Fcursor.com%2Fopen-in-cursor.svg%22%3E%3C%2Fpicture%3E%3C%2Fa%3E%26nbsp%3B%3Ca%20href%3D%22https%3A%2F%2Fcursor.com%2Fagents%3Fid%3Dbc-8d6e17c1-2869-4191-bce2-0bb77738f34a%22%3E%3Cpicture%3E%3Csource%20media%3D%22(prefers-color-scheme%3A%20dark)%22%20srcset%3D%22https%3A%2F%2Fcursor.com%2Fopen-in-web-dark.svg%22%3E%3Csource%20media%3D%22(prefers-color-scheme%3A%20light)%22%20srcset%3D%22https%3A%2F%2Fcursor.com%2Fopen-in-web-light.svg%22%3E%3Cimg%20alt%3D%22Open%20in%20Web%22%20src%3D%22https%3A%2F%2Fcursor.com%2Fopen-in-web.svg%22%3E%3C%2Fpicture%3E%3C%2Fa%3E) I modified the `TransactionsTable` component to enhance user experience by preventing password managers from interfering with the debit and credit amount input fields. This ensures a smoother data entry process for financial transactions. - In `packages/desktop-client/src/components/transactions/TransactionsTable.tsx`, I added the `data-1p-ignore: true` attribute to the `inputProps` object for both the debit and credit `CurrencyInput` components within the `Transaction` row. - This change explicitly tells password managers (e.g., 1Password) to ignore these specific input fields, preventing them from attempting to autofill or suggest values in sensitive financial entry fields. --- **4 tasks completed** - [x] Explore the codebase structure to understand where transaction components are located - [x] Find the transaction table component and specifically the split transaction input fields - [x] Add `data-1p-ignore` attribute to the amounts input fields in split transactions - [x] Test the changes to ensure they work correctly <a href="https://cursor.com/background-agent?bcId=bc-8d6e17c1-2869-4191-bce2-0bb77738f34a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-8d6e17c1-2869-4191-bce2-0bb77738f34a"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> <sub>[Learn more](https://docs.cursor.com/background-agent/web-and-mobile) about Cursor Agents</sub>
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue upstream
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#44140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?