github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2534] ♻️ (bank-sync) unify the sync/reconciliation logic for internal & external sync #4352

New Issue
Closed
opened 2026-02-28 20:54:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:54:46 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/2534

State: closed
Merged: Yes

Unifying the reconciliation and syncing logic to reduce duplication.

Previously we had reconcileTransactions, reconcileExternalTransactions, syncAccount and syncExternalAccount. Now we have only one of each.

The logic there is still not exactly clean. But at least now we have a single place for it instead of copy&paste duplication.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/2534 **State:** closed **Merged:** Yes --- Unifying the reconciliation and syncing logic to reduce duplication. Previously we had `reconcileTransactions`, `reconcileExternalTransactions`, `syncAccount` and `syncExternalAccount`. Now we have only one of each. The logic there is still not exactly _clean_. But at least now we have a single place for it instead of copy&paste duplication.
GiteaMirror added the pull-request label 2026-02-28 20:54:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?