[GH-ISSUE #2294] [Bug]: End of month cleanup should ignore rollover categories #42557

Closed
opened 2026-04-26 02:30:37 -05:00 by GiteaMirror · 2 comments
Owner

Originally created by @kymckay on GitHub (Jan 28, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2294

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I have checked my server logs and could not see any errors there
  • I will be attaching my server logs to this issue
  • I will be attaching my client-side (browser) logs to this issue
  • I understand that this issue will be automatically closed if insufficient information is provided

What happened?

  1. Overspend a category and set it to roll over.
  2. Add #cleanup source to the category.
  3. Create another category with #cleanup sink.
  4. Run end of month clean up. The overspend is covered by putting the sink category into overspend instead.

Perhaps this is desirable? I can't decide, but it didn't feel intuitive to me since I explicitly set the overspend to roll over. With the intention of covering it with reimbursement the following month.

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

Originally created by @kymckay on GitHub (Jan 28, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/2294 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### Is this related to GoCardless, Simplefin or another bank-sync provider? - [ ] I have checked my server logs and could not see any errors there - [ ] I will be attaching my server logs to this issue - [ ] I will be attaching my client-side (browser) logs to this issue - [ ] I understand that this issue will be automatically closed if insufficient information is provided ### What happened? 1. Overspend a category and set it to roll over. 2. Add `#cleanup source` to the category. 3. Create another category with `#cleanup sink`. 4. Run end of month clean up. The overspend is covered by putting the sink category into overspend instead. Perhaps this is desirable? I can't decide, but it didn't feel intuitive to me since I explicitly set the overspend to roll over. With the intention of covering it with reimbursement the following month. ### What error did you receive? _No response_ ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox ### Operating System Linux
GiteaMirror added the bug label 2026-04-26 02:30:37 -05:00
Author
Owner

@shall0pass commented on GitHub (Jan 28, 2024):

I see what you're saying. And I think the behavior exists for both rollover and non-rollover categories.

I could potentially see a use case to change add a negative value to a rollover category to fund another category. Specifically, I'm thinking about a 'credit debt' type category. But I think I agree with you that maybe shouldn't be the default behavior but could possibly be specified by a flag.

We can and should add a check for 'source' categories to make sure the balance is positive before taking money from it.

<!-- gh-comment-id:1913656894 --> @shall0pass commented on GitHub (Jan 28, 2024): I see what you're saying. And I think the behavior exists for both rollover and non-rollover categories. I could potentially see a use case to change add a negative value to a rollover category to fund another category. Specifically, I'm thinking about a 'credit debt' type category. But I think I agree with you that maybe shouldn't be the default behavior but could possibly be specified by a flag. We can and should add a check for 'source' categories to make sure the balance is positive before taking money from it.
Author
Owner

@shall0pass commented on GitHub (Jan 29, 2024):

@kymckay Would you mind trying #2295 . I added additional logic for rollover categories (where the documentation would need to be changed), so I could remove that if it breaks peoples workflows.

<!-- gh-comment-id:1914935279 --> @shall0pass commented on GitHub (Jan 29, 2024): @kymckay Would you mind trying #2295 . I added additional logic for rollover categories (where the documentation would need to be changed), so I could remove that if it breaks peoples workflows.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#42557