github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-22 12:12:11 -05:00
Code Issues 2.1k Packages Projects Releases 57 Wiki Activity

[GH-ISSUE #1520] [Bug]: Mobile entry will enter positive value instead of negative #42227

New Issue
Closed
opened 2026-04-26 01:53:43 -05:00 by GiteaMirror · 13 comments
GiteaMirror commented 2026-04-26 01:53:43 -05:00
Owner
Copy Link

Originally created by @shall0pass on GitHub (Aug 12, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1520

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When entering data on the new Mobile entry page, a transaction may be entered as a deposit rather than a payment without toggling the - to + button.

To reproduce:
Go to an account.
Enter the mobile entry screen.

  1. Fill in the Payee
  2. Fill in the amount (don't remove focus from the amount cell before step 3)
  3. Add transaction

You'll see the entry is a deposit rather than the default payment.

If you remove focus from the amount cell before adding the transaction, it will add the transaction correctly.

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox, Chrome

Operating System

Mobile Device

Originally created by @shall0pass on GitHub (Aug 12, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1520 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? When entering data on the new Mobile entry page, a transaction may be entered as a deposit rather than a payment without toggling the - to + button. To reproduce: Go to an account. Enter the mobile entry screen. 1. Fill in the Payee 2. Fill in the amount (don't remove focus from the amount cell before step 3) 3. Add transaction You'll see the entry is a deposit rather than the default payment. If you remove focus from the amount cell before adding the transaction, it will add the transaction correctly. ### What error did you receive? _No response_ ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Firefox, Chrome ### Operating System Mobile Device
GiteaMirror added the responsivebug labels 2026-04-26 01:53:43 -05:00
GiteaMirror commented 2026-04-26 01:53:45 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Aug 13, 2023):

I must be doing something wrong! I have tried over and over again in mobile Firefox and Safari without being able to reproduce this bug. The act of selecting “add transaction” removes focus from the amount for me.

<!-- gh-comment-id:1676247379 --> @Kidglove57 commented on GitHub (Aug 13, 2023): I must be doing something wrong! I have tried over and over again in mobile Firefox and Safari without being able to reproduce this bug. The act of selecting “add transaction” removes focus from the amount for me.
GiteaMirror commented 2026-04-26 01:53:45 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 13, 2023):

This is using the edge image.

https://github.com/actualbudget/actual/assets/20625555/7e864c46-2367-4a7a-b241-48fc95c89b3b

<!-- gh-comment-id:1676301212 --> @shall0pass commented on GitHub (Aug 13, 2023): This is using the edge image. https://github.com/actualbudget/actual/assets/20625555/7e864c46-2367-4a7a-b241-48fc95c89b3b
GiteaMirror commented 2026-04-26 01:53:45 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 13, 2023):

This is if I remove focus first. It's working normally.

https://github.com/actualbudget/actual/assets/20625555/13dba97e-6185-43a8-af5f-3725c23093ca

<!-- gh-comment-id:1676302304 --> @shall0pass commented on GitHub (Aug 13, 2023): This is if I remove focus first. It's working normally. https://github.com/actualbudget/actual/assets/20625555/13dba97e-6185-43a8-af5f-3725c23093ca
GiteaMirror commented 2026-04-26 01:53:45 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Aug 13, 2023):

Thanks for the visual explanations @shall0pass. I have tried and tried (on latest Edge) but still cant make it happen. I'm on iOS but I can't see what difference that would make?

<!-- gh-comment-id:1676352604 --> @Kidglove57 commented on GitHub (Aug 13, 2023): Thanks for the visual explanations @shall0pass. I have tried and tried (on latest Edge) but still cant make it happen. I'm on iOS but I can't see what difference that would make?
GiteaMirror commented 2026-04-26 01:53:46 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 13, 2023):

Strange. Both of those demos were using chrome on android. I can get the same results by using the demo site.

<!-- gh-comment-id:1676353255 --> @shall0pass commented on GitHub (Aug 13, 2023): Strange. Both of those demos were using chrome on android. I can get the same results by using the demo site.
GiteaMirror commented 2026-04-26 01:53:46 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Aug 13, 2023):

Maybe a silly question but how do you enter the transaction without switching focus to the “add tranasction” button?

As an aside I probably would not normally come across this as I follow the screen entry sequence ie amount/payee/category.

<!-- gh-comment-id:1676355149 --> @Kidglove57 commented on GitHub (Aug 13, 2023): Maybe a silly question but how do you enter the transaction without switching focus to the “add tranasction” button? As an aside I probably would not normally come across this as I follow the screen entry sequence ie amount/payee/category.
GiteaMirror commented 2026-04-26 01:53:46 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 13, 2023):

Maybe a silly question but how do you enter the transaction without switching focus to the “add tranasction” button?

There is a button on the keyboard to stow it away. It's in the bottom left of my keyboard when it's open.

As an aside I probably would not normally come across this as I follow the screen entry sequence ie amount/payee/category.

I found this at the grocery store yesterday. I was waiting for the cashier to finish ringing up my items, so I didn't have the total amount yet but I had the payee and the category. I was just waiting for the amount to be filled before entering.

<!-- gh-comment-id:1676355792 --> @shall0pass commented on GitHub (Aug 13, 2023): > Maybe a silly question but how do you enter the transaction without switching focus to the “add tranasction” button? There is a button on the keyboard to stow it away. It's in the bottom left of my keyboard when it's open. > As an aside I probably would not normally come across this as I follow the screen entry sequence ie amount/payee/category. I found this at the grocery store yesterday. I was waiting for the cashier to finish ringing up my items, so I didn't have the total amount yet but I had the payee and the category. I was just waiting for the amount to be filled before entering.
GiteaMirror commented 2026-04-26 01:53:47 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Aug 13, 2023):

Ah got it thanks for your patience - the reason I was lost is because there is no equivalent keyboard "enter" button on the Apple iOS keyboard in transaction mode, so I have to physically select "add transaction.

<!-- gh-comment-id:1676356966 --> @Kidglove57 commented on GitHub (Aug 13, 2023): Ah got it thanks for your patience - the reason I was lost is because there is no equivalent keyboard "enter" button on the Apple iOS keyboard in transaction mode, so I have to physically select "add transaction.
GiteaMirror commented 2026-04-26 01:53:47 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 13, 2023):

Just to clarify, I did use the "add transaction" button, but when I selected it the amount box still had focus. I did not use the enter button on my keyboard at any time.

<!-- gh-comment-id:1676362962 --> @shall0pass commented on GitHub (Aug 13, 2023): Just to clarify, I did use the "add transaction" button, but when I selected it the amount box still had focus. I did not use the enter button on my keyboard at any time.
GiteaMirror commented 2026-04-26 01:53:47 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Aug 13, 2023):

Thanks for clarifying! It maybe does not help resolve this but I have now entered test transactions a dozen times or more without any of my payments turning into deposits.🫢

<!-- gh-comment-id:1676396112 --> @Kidglove57 commented on GitHub (Aug 13, 2023): Thanks for clarifying! It maybe does not help resolve this but I have now entered test transactions a dozen times or more without any of my payments turning into deposits.🫢
GiteaMirror commented 2026-04-26 01:53:48 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 13, 2023):

I am able to replicate this on my laptop. If no one else is able to replicate this, I may dig into it later. It must have something to do with touch events. This laptop is running Win 11.

mobile_entry

<!-- gh-comment-id:1676399741 --> @shall0pass commented on GitHub (Aug 13, 2023): I am able to replicate this on my laptop. If no one else is able to replicate this, I may dig into it later. It must have something to do with touch events. This laptop is running Win 11. ![mobile_entry](https://github.com/actualbudget/actual/assets/20625555/07564828-9b4f-47af-ac74-3a60cb746daa)
GiteaMirror commented 2026-04-26 01:53:48 -05:00
Author
Owner
Copy Link

@trevdor commented on GitHub (Aug 20, 2023):

Think I got to the bottom of it! onBlur is applying the negation we rely on. More details in the description of the PR I just linked.

@shall0pass mind verifying the fix on the linked PR preview addresses it for you?

<!-- gh-comment-id:1685282334 --> @trevdor commented on GitHub (Aug 20, 2023): Think I got to the bottom of it! `onBlur` is applying the negation we rely on. More details in the description of the PR I just linked. @shall0pass mind verifying the fix on the linked PR preview addresses it for you?
GiteaMirror commented 2026-04-26 01:53:49 -05:00
Author
Owner
Copy Link

@shall0pass commented on GitHub (Aug 20, 2023):

This solves it! Thanks!

<!-- gh-comment-id:1685283309 --> @shall0pass commented on GitHub (Aug 20, 2023): This solves it! Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug responsive
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#42227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?