github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2211] [CLOSED] [WIP] Category autocomplete: allow user to toggle making group name searchable #4182

New Issue
Closed
opened 2026-02-28 20:52:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:52:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2211
Author: @postonsundays
Created: 1/10/2024
Status: ❌ Closed

Base: master ← Head: feature-category-autocomplete-group-names

📝 Commits (4)

📊 Changes

5 files changed (+76 additions, -14 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+27 -14)
➕ packages/desktop-client/src/components/settings/AccountSettings.tsx (+40 -0)
📝 packages/desktop-client/src/components/settings/index.tsx (+2 -0)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -0)
➕ upcoming-release-notes/2211.md (+6 -0)

📄 Description

A bit of user friction I've encountered when categorizing a transaction is not being able to see all the categories I have under a certain group (e.g. Health). The app used to have the group name to the list of values being searched so that by simply typing "Health", I can see all the possible sub-categories in one place, but was removed following a discussion around UX in #1615.

A potential solution is giving users the choice whether they want this extra bit of functionality. This PR will add the option to toggle including group names in the categories in the dashboard settings and creates a more comprehensive filterCategorySuggestions function in the CategoryAutocomplete component to check if the user has enabled this feature.

Main changes

  • adds ui.categorySuggestionsGroupNames to local preferences
  • creates new "Accounts" panel in settings where including groups name in suggestions can be toggled - open to suggestions on the wording of the title / checkbox

Extra work

  • Adds a CategorySuggestion type in the file so the expanded object with group component can be used in more methods

Screenshot 2024-01-10 at 17 00 14
Screenshot 2024-01-10 at 19 50 54

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2211 **Author:** [@postonsundays](https://github.com/postonsundays) **Created:** 1/10/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature-category-autocomplete-group-names` --- ### 📝 Commits (4) - [`bbbcef1`](https://github.com/actualbudget/actual/commit/bbbcef106241dd37b624f55051c61854c8dd7a9a) Update CategoryAutocomplete.tsx - [`a8a5287`](https://github.com/actualbudget/actual/commit/a8a5287f7560a5eb144cc8ece2a574bd35020eea) Create 2211.md - [`1bb2f12`](https://github.com/actualbudget/actual/commit/1bb2f12da2ecbc8750386e7af614da814865612e) enable settings toggle from users - [`c105458`](https://github.com/actualbudget/actual/commit/c105458b1ea2e7a28b24a2185099d3a4ed993ec2) fix lint ### 📊 Changes **5 files changed** (+76 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+27 -14) ➕ `packages/desktop-client/src/components/settings/AccountSettings.tsx` (+40 -0) 📝 `packages/desktop-client/src/components/settings/index.tsx` (+2 -0) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -0) ➕ `upcoming-release-notes/2211.md` (+6 -0) </details> ### 📄 Description A bit of user friction I've encountered when categorizing a transaction is not being able to see all the categories I have under a certain group (e.g. Health). The app used to have the group name to the list of values being searched so that by simply typing "Health", I can see all the possible sub-categories in one place, but was removed following a discussion around UX in #1615. A potential solution is giving users the choice whether they want this extra bit of functionality. This PR will add the option to toggle including group names in the categories in the dashboard settings and creates a more comprehensive `filterCategorySuggestions` function in the `CategoryAutocomplete` component to check if the user has enabled this feature. ### Main changes - adds `ui.categorySuggestionsGroupNames` to local preferences - creates new "Accounts" panel in settings where including groups name in suggestions can be toggled - open to suggestions on the wording of the title / checkbox ### Extra work - Adds a `CategorySuggestion` type in the file so the expanded object with `group` component can be used in more methods ![Screenshot 2024-01-10 at 17 00 14](https://github.com/actualbudget/actual/assets/98259928/ee873b20-73fd-4aba-9882-888bcd21b2f2) ![Screenshot 2024-01-10 at 19 50 54](https://github.com/actualbudget/actual/assets/98259928/328bb1fd-95d2-497e-a6aa-7a51e2069611) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:52:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?