github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2182] [MERGED] 🔧 (electron) release electron app to app store (osx) #4163

New Issue
Closed
opened 2026-02-28 20:52:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:52:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2182
Author: @MatissJanis
Created: 1/6/2024
Status: ✅ Merged
Merged: 1/9/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/electron-app

📝 Commits (10+)

  • e91bbb1 🔧 (electron) release electron app to app store (osx)
  • 786561e Fix linter
  • 34bcaf2 Merge branch 'master' into matiss/electron-app
  • fd90f27 Fix for functional e2e tests
  • 85d73e5 Updated VRT screenshots
  • e8f1750 Add env vars for code signing
  • 2b46974 Attempt to notarize too
  • eab07c0 Remove insecure CSC_FOR_PULL_REQUEST
  • 2266b88 Merge branch 'master' into matiss/electron-app
  • 303d9f8 Move back to test buttons

📊 Changes

15 files changed (+140 additions, -137 deletions)

View changed files

📝 .github/workflows/electron.yml (+5 -0)
➕ .secret-tokens.example (+2 -0)
📝 bin/package-electron (+2 -5)
📝 packages/api/package.json (+1 -1)
📝 packages/desktop-client/README.md (+4 -3)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/manager/WelcomeScreen.tsx (+16 -5)
📝 packages/desktop-electron/about/index.js (+0 -1)
➖ packages/desktop-electron/afterSignHook.js (+0 -44)
📝 packages/desktop-electron/index.js (+1 -1)
📝 packages/desktop-electron/package.json (+13 -9)
📝 packages/loot-core/package.json (+1 -1)
➕ upcoming-release-notes/2182.md (+6 -0)
📝 yarn.lock (+89 -67)

📄 Description

Code-sign and notarize the electron apps. This should allow us to publish the app to the app store (mac).

Also added a "view demo" button to the very first screen of the desktop app. This will allow for desktop users to quickly jump into the app if they just want to play around with it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2182 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/6/2024 **Status:** ✅ Merged **Merged:** 1/9/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/electron-app` --- ### 📝 Commits (10+) - [`e91bbb1`](https://github.com/actualbudget/actual/commit/e91bbb184d79e07309da482572f25720dc6eec35) :wrench: (electron) release electron app to app store (osx) - [`786561e`](https://github.com/actualbudget/actual/commit/786561e38798454de158de494e899367784532a3) Fix linter - [`34bcaf2`](https://github.com/actualbudget/actual/commit/34bcaf294650436b4ed563bdfcd69393a2ad6108) Merge branch 'master' into matiss/electron-app - [`fd90f27`](https://github.com/actualbudget/actual/commit/fd90f2728ab0c475ac92116034987a4d557968c9) Fix for functional e2e tests - [`85d73e5`](https://github.com/actualbudget/actual/commit/85d73e55c71270a5662da467c971f413916dc03a) Updated VRT screenshots - [`e8f1750`](https://github.com/actualbudget/actual/commit/e8f17503c52a64123af5831135eb9c957e546840) Add env vars for code signing - [`2b46974`](https://github.com/actualbudget/actual/commit/2b4697496d8c532322c6979cf4887ebcb32abac1) Attempt to notarize too - [`eab07c0`](https://github.com/actualbudget/actual/commit/eab07c00f55481a80db818ab08736847e679f07d) Remove insecure CSC_FOR_PULL_REQUEST - [`2266b88`](https://github.com/actualbudget/actual/commit/2266b88aaa3ccc92c5cc457c1d353731b7cdb4b6) Merge branch 'master' into matiss/electron-app - [`303d9f8`](https://github.com/actualbudget/actual/commit/303d9f873ac83dee9a8214ff1a87e85196c7fbec) Move back to test buttons ### 📊 Changes **15 files changed** (+140 additions, -137 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/electron.yml` (+5 -0) ➕ `.secret-tokens.example` (+2 -0) 📝 `bin/package-electron` (+2 -5) 📝 `packages/api/package.json` (+1 -1) 📝 `packages/desktop-client/README.md` (+4 -3) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/manager/WelcomeScreen.tsx` (+16 -5) 📝 `packages/desktop-electron/about/index.js` (+0 -1) ➖ `packages/desktop-electron/afterSignHook.js` (+0 -44) 📝 `packages/desktop-electron/index.js` (+1 -1) 📝 `packages/desktop-electron/package.json` (+13 -9) 📝 `packages/loot-core/package.json` (+1 -1) ➕ `upcoming-release-notes/2182.md` (+6 -0) 📝 `yarn.lock` (+89 -67) </details> ### 📄 Description Code-sign and notarize the electron apps. This should allow us to publish the app to the app store (mac). Also added a "view demo" button to the very first screen of the desktop app. This will allow for desktop users to quickly jump into the app if they just want to play around with it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:52:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?