[PR #7528] [MERGED] clean up more unused dependencies #41628

Closed
opened 2026-04-23 14:25:46 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7528
Author: @matt-fidd
Created: 4/16/2026
Status: Merged
Merged: 4/16/2026
Merged by: @matt-fidd

Base: masterHead: deps/unused


📝 Commits (4)

📊 Changes

8 files changed (+15 additions, -265 deletions)

View changed files

📝 package.json (+0 -2)
📝 packages/desktop-client/package.json (+1 -7)
📝 packages/docs/package.json (+0 -1)
📝 packages/loot-core/package.json (+0 -2)
packages/sync-server/babel.config.json (+0 -3)
📝 packages/sync-server/package.json (+0 -3)
upcoming-release-notes/7528.md (+6 -0)
📝 yarn.lock (+8 -247)

📄 Description

Description

I'll put another couple of hours staring at dependencies on my timesheet...

https://github.com/actualbudget/actual/pull/7519#issuecomment-4262137055 prompted me to go and look for this, because we've found a fair few in the past and that PR was kind of highlighting deps defined in the wrong package. I found most of these with depcheck, which gave a fair few false positives but some of them were accurate! Most are just unused in that workspace, but used somewhere else. Eg. html-to-image is used in desktop-client, but was defined in the root package too, xml2js is used in loot-core, but was also defined in desktop-client.

Mac:actual:master% yarn workspaces foreach -A exec sh -c "npx depcheck || true"
[@actual-app/api]: Process started
[@actual-app/api]: Unused dependencies
[@actual-app/api]: * @actual-app/crdt
[@actual-app/api]: * better-sqlite3
[@actual-app/api]: * uuid
[@actual-app/api]: Process exited (exit code 0), completed in 1s 845ms

[@actual-app/ci-actions]: Process started
[@actual-app/ci-actions]: Unused devDependencies
[@actual-app/ci-actions]: * extensionless
[@actual-app/ci-actions]: Missing dependencies
[@actual-app/ci-actions]: * @types/node: ./tsconfig.json
[@actual-app/ci-actions]: Process exited (exit code 0), completed in 1s 680ms

[@actual-app/cli]: Process started
[@actual-app/cli]: No depcheck issue
[@actual-app/cli]: Process exited (exit code 0), completed in 1s 674ms

[@actual-app/components]: Process started
[@actual-app/components]: Unused devDependencies
[@actual-app/components]: * @chromatic-com/storybook
[@actual-app/components]: * @storybook/addon-a11y
[@actual-app/components]: * @storybook/addon-docs
[@actual-app/components]: * eslint-plugin-storybook
[@actual-app/components]: Missing dependencies
[@actual-app/components]: * vite-plugin-peggy-loader: ./vitest.web.config.ts
[@actual-app/components]: * @actual-app/components: ./src/Card.stories.tsx
[@actual-app/components]: * @testing-library/react: ./src/InitialFocus.web.test.tsx
[@actual-app/components]: * @babel/template: ./src/icons/add-attribute.ts
[@actual-app/components]: * @babel/traverse: ./src/icons/add-attribute.ts
[@actual-app/components]: * @babel/types: ./src/icons/add-attribute.ts
[@actual-app/components]: * @svgr/core: ./src/icons/template.ts
[@actual-app/components]: Process exited (exit code 0), completed in 2s 615ms

[@actual-app/core]: Process started
[@actual-app/core]: Unused devDependencies
[@actual-app/core]: * @types/emscripten
[@actual-app/core]: * assert
[@actual-app/core]: * browserify-zlib
[@actual-app/core]: * buffer
[@actual-app/core]: * cross-env
[@actual-app/core]: * crypto-browserify
[@actual-app/core]: * path-browserify
[@actual-app/core]: * stream-browserify
[@actual-app/core]: * timers-browserify
[@actual-app/core]: * util
[@actual-app/core]: Process exited (exit code 0), completed in 2s 446ms

[@actual-app/crdt]: Process started
[@actual-app/crdt]: Unused devDependencies
[@actual-app/crdt]: * protoc-gen-js
[@actual-app/crdt]: * ts-protoc-gen
[@actual-app/crdt]: Process exited (exit code 0), completed in 1s 720ms

[@actual-app/sync-server]: Process started
[@actual-app/sync-server]: Unused devDependencies
[@actual-app/sync-server]: * @types/babel__core
[@actual-app/sync-server]: * @types/bcrypt
[@actual-app/sync-server]: * @types/better-sqlite3
[@actual-app/sync-server]: * @types/convict
[@actual-app/sync-server]: * @types/express-actuator
[@actual-app/sync-server]: Process exited (exit code 0), completed in 1s 943ms

[@actual-app/web]: Process started
[@actual-app/web]: Unused devDependencies
[@actual-app/web]: * @codemirror/lang-javascript
[@actual-app/web]: * @swc/core
[@actual-app/web]: * @swc/helpers
[@actual-app/web]: * @types/react-modal
[@actual-app/web]: * cross-env
[@actual-app/web]: * react-modal
[@actual-app/web]: * xml2js
[@actual-app/web]: Missing dependencies
[@actual-app/web]: * virtual:pwa-register: ./src/browser-preload.js
[@actual-app/web]: Process exited (exit code 0), completed in 3s 904ms

[actual]: Process started
[actual]: Unused devDependencies
[actual]: * cross-env
[actual]: * eslint
[actual]: * eslint-plugin-perfectionist
[actual]: * eslint-plugin-typescript-paths
[actual]: * html-to-image
[actual]: Missing dependencies
[actual]: * vite: ./tsconfig.json
[actual]: Process exited (exit code 0), completed in 3s 507ms

[desktop-electron]: Process started
[desktop-electron]: Unused devDependencies
[desktop-electron]: * @electron/notarize
[desktop-electron]: * cross-env
[desktop-electron]: Missing dependencies
[desktop-electron]: * uuid: ./build/loot-core/migrations/1722804019000_create_dashboard_table.js
[desktop-electron]: Process exited (exit code 0), completed in 8s 730ms

[docs]: Process started
[docs]: Unused dependencies
[docs]: * @docusaurus/plugin-content-docs
[docs]: * @docusaurus/plugin-ideal-image
[docs]: * @docusaurus/preset-classic
[docs]: * @docusaurus/theme-mermaid
[docs]: * @r74tech/docusaurus-plugin-panzoom
[docs]: * clsx
[docs]: Unused devDependencies
[docs]: * @docusaurus/module-type-aliases
[docs]: Missing dependencies
[docs]: * @site/src: ./src/theme/MDXComponents.js
[docs]: * @theme-original/MDXComponents: ./src/theme/MDXComponents.js
[docs]: * @theme-original/Layout: ./src/theme/Layout/index.jsx
[docs]: * unist-util-visit-parents: ./src/remark/mentions.js
[docs]: * @docusaurus/Link: ./src/pages/index.jsx
[docs]: * @theme/Layout: ./src/pages/index.jsx
[docs]: * @theme/ThemedImage: ./src/pages/index.jsx
[docs]: * @theme/IdealImage: ./src/components/Image.jsx
[docs]: Process exited (exit code 0), completed in 1s 927ms

[eslint-plugin-actual]: Process started
[eslint-plugin-actual]: No depcheck issue
[eslint-plugin-actual]: Process exited (exit code 0), completed in 1s 669ms

[plugins-service]: Process started
[plugins-service]: Unused devDependencies
[plugins-service]: * cross-env
[plugins-service]: Process exited (exit code 0), completed in 1s 795ms
Done in 35s 459ms
Mac:actual:master%

Testing

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 12.94 MB → 12.93 MB (-177 B) -0.00%
loot-core 1 4.85 MB 0%
api 1 3.88 MB 0%
cli 1 7.91 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 12.94 MB → 12.93 MB (-177 B) -0.00%
Changeset
File Δ Size
package.json 📉 -177 B (-2.11%) 8.19 kB → 8.01 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 1.85 MB → 1.85 MB (-177 B) -0.01%

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 814.39 kB 0%
static/js/PayeeRuleCountLabel.js 52.12 kB 0%
static/js/ReportRouter.js 1.18 MB 0%
static/js/ScheduleEditForm.js 136.13 kB 0%
static/js/TransactionEdit.js 185.13 kB 0%
static/js/TransactionList.js 82.8 kB 0%
static/js/Value.js 4.34 MB 0%
static/js/ca.js 191.72 kB 0%
static/js/chart-theme.js 709.55 kB 0%
static/js/client.js 450.92 kB 0%
static/js/da.js 104.4 kB 0%
static/js/de.js 174.12 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.5 kB 0%
static/js/es.js 181.54 kB 0%
static/js/extends.js 486.5 kB 0%
static/js/fr.js 176.79 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.68 kB 0%
static/js/narrow.js 363.68 kB 0%
static/js/nb-NO.js 151.58 kB 0%
static/js/nl.js 108.66 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 193.49 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.91 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.28 kB 0%
static/js/useFormatList.js 9.86 kB 0%
static/js/wide.js 292 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 110.19 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.85 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BiN7Vxsx.js 4.85 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.88 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.91 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.91 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7528 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 4/16/2026 **Status:** ✅ Merged **Merged:** 4/16/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `deps/unused` --- ### 📝 Commits (4) - [`2f5da7b`](https://github.com/actualbudget/actual/commit/2f5da7bace98bf3a2158307ea45934cb54beadb7) remove unused deps - [`5ad2c8f`](https://github.com/actualbudget/actual/commit/5ad2c8f4d1e6f11655b62c4134a86d2ee6863cde) note - [`f590ddd`](https://github.com/actualbudget/actual/commit/f590ddd18d12561ba4babd416f167d6894594c1d) remove babel - [`2eeb2d2`](https://github.com/actualbudget/actual/commit/2eeb2d2df02b3c07dda72e999f5edc1579a3c547) fix lint ### 📊 Changes **8 files changed** (+15 additions, -265 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+0 -2) 📝 `packages/desktop-client/package.json` (+1 -7) 📝 `packages/docs/package.json` (+0 -1) 📝 `packages/loot-core/package.json` (+0 -2) ➖ `packages/sync-server/babel.config.json` (+0 -3) 📝 `packages/sync-server/package.json` (+0 -3) ➕ `upcoming-release-notes/7528.md` (+6 -0) 📝 `yarn.lock` (+8 -247) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> I'll put another couple of hours staring at dependencies on my timesheet... https://github.com/actualbudget/actual/pull/7519#issuecomment-4262137055 prompted me to go and look for this, because we've found a fair few in the past and that PR was kind of highlighting deps defined in the wrong package. I found most of these with depcheck, which gave a fair few false positives but some of them were accurate! Most are just unused in that workspace, but used somewhere else. Eg. `html-to-image` is used in desktop-client, but was defined in the root package too, `xml2js` is used in loot-core, but was also defined in desktop-client. ``` Mac:actual:master% yarn workspaces foreach -A exec sh -c "npx depcheck || true" [@actual-app/api]: Process started [@actual-app/api]: Unused dependencies [@actual-app/api]: * @actual-app/crdt [@actual-app/api]: * better-sqlite3 [@actual-app/api]: * uuid [@actual-app/api]: Process exited (exit code 0), completed in 1s 845ms [@actual-app/ci-actions]: Process started [@actual-app/ci-actions]: Unused devDependencies [@actual-app/ci-actions]: * extensionless [@actual-app/ci-actions]: Missing dependencies [@actual-app/ci-actions]: * @types/node: ./tsconfig.json [@actual-app/ci-actions]: Process exited (exit code 0), completed in 1s 680ms [@actual-app/cli]: Process started [@actual-app/cli]: No depcheck issue [@actual-app/cli]: Process exited (exit code 0), completed in 1s 674ms [@actual-app/components]: Process started [@actual-app/components]: Unused devDependencies [@actual-app/components]: * @chromatic-com/storybook [@actual-app/components]: * @storybook/addon-a11y [@actual-app/components]: * @storybook/addon-docs [@actual-app/components]: * eslint-plugin-storybook [@actual-app/components]: Missing dependencies [@actual-app/components]: * vite-plugin-peggy-loader: ./vitest.web.config.ts [@actual-app/components]: * @actual-app/components: ./src/Card.stories.tsx [@actual-app/components]: * @testing-library/react: ./src/InitialFocus.web.test.tsx [@actual-app/components]: * @babel/template: ./src/icons/add-attribute.ts [@actual-app/components]: * @babel/traverse: ./src/icons/add-attribute.ts [@actual-app/components]: * @babel/types: ./src/icons/add-attribute.ts [@actual-app/components]: * @svgr/core: ./src/icons/template.ts [@actual-app/components]: Process exited (exit code 0), completed in 2s 615ms [@actual-app/core]: Process started [@actual-app/core]: Unused devDependencies [@actual-app/core]: * @types/emscripten [@actual-app/core]: * assert [@actual-app/core]: * browserify-zlib [@actual-app/core]: * buffer [@actual-app/core]: * cross-env [@actual-app/core]: * crypto-browserify [@actual-app/core]: * path-browserify [@actual-app/core]: * stream-browserify [@actual-app/core]: * timers-browserify [@actual-app/core]: * util [@actual-app/core]: Process exited (exit code 0), completed in 2s 446ms [@actual-app/crdt]: Process started [@actual-app/crdt]: Unused devDependencies [@actual-app/crdt]: * protoc-gen-js [@actual-app/crdt]: * ts-protoc-gen [@actual-app/crdt]: Process exited (exit code 0), completed in 1s 720ms [@actual-app/sync-server]: Process started [@actual-app/sync-server]: Unused devDependencies [@actual-app/sync-server]: * @types/babel__core [@actual-app/sync-server]: * @types/bcrypt [@actual-app/sync-server]: * @types/better-sqlite3 [@actual-app/sync-server]: * @types/convict [@actual-app/sync-server]: * @types/express-actuator [@actual-app/sync-server]: Process exited (exit code 0), completed in 1s 943ms [@actual-app/web]: Process started [@actual-app/web]: Unused devDependencies [@actual-app/web]: * @codemirror/lang-javascript [@actual-app/web]: * @swc/core [@actual-app/web]: * @swc/helpers [@actual-app/web]: * @types/react-modal [@actual-app/web]: * cross-env [@actual-app/web]: * react-modal [@actual-app/web]: * xml2js [@actual-app/web]: Missing dependencies [@actual-app/web]: * virtual:pwa-register: ./src/browser-preload.js [@actual-app/web]: Process exited (exit code 0), completed in 3s 904ms [actual]: Process started [actual]: Unused devDependencies [actual]: * cross-env [actual]: * eslint [actual]: * eslint-plugin-perfectionist [actual]: * eslint-plugin-typescript-paths [actual]: * html-to-image [actual]: Missing dependencies [actual]: * vite: ./tsconfig.json [actual]: Process exited (exit code 0), completed in 3s 507ms [desktop-electron]: Process started [desktop-electron]: Unused devDependencies [desktop-electron]: * @electron/notarize [desktop-electron]: * cross-env [desktop-electron]: Missing dependencies [desktop-electron]: * uuid: ./build/loot-core/migrations/1722804019000_create_dashboard_table.js [desktop-electron]: Process exited (exit code 0), completed in 8s 730ms [docs]: Process started [docs]: Unused dependencies [docs]: * @docusaurus/plugin-content-docs [docs]: * @docusaurus/plugin-ideal-image [docs]: * @docusaurus/preset-classic [docs]: * @docusaurus/theme-mermaid [docs]: * @r74tech/docusaurus-plugin-panzoom [docs]: * clsx [docs]: Unused devDependencies [docs]: * @docusaurus/module-type-aliases [docs]: Missing dependencies [docs]: * @site/src: ./src/theme/MDXComponents.js [docs]: * @theme-original/MDXComponents: ./src/theme/MDXComponents.js [docs]: * @theme-original/Layout: ./src/theme/Layout/index.jsx [docs]: * unist-util-visit-parents: ./src/remark/mentions.js [docs]: * @docusaurus/Link: ./src/pages/index.jsx [docs]: * @theme/Layout: ./src/pages/index.jsx [docs]: * @theme/ThemedImage: ./src/pages/index.jsx [docs]: * @theme/IdealImage: ./src/components/Image.jsx [docs]: Process exited (exit code 0), completed in 1s 927ms [eslint-plugin-actual]: Process started [eslint-plugin-actual]: No depcheck issue [eslint-plugin-actual]: Process exited (exit code 0), completed in 1s 669ms [plugins-service]: Process started [plugins-service]: Unused devDependencies [plugins-service]: * cross-env [plugins-service]: Process exited (exit code 0), completed in 1s 795ms Done in 35s 459ms Mac:actual:master% ``` ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 12.94 MB → 12.93 MB (-177 B) | -0.00% loot-core | 1 | 4.85 MB | 0% api | 1 | 3.88 MB | 0% cli | 1 | 7.91 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 12.94 MB → 12.93 MB (-177 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `package.json` | 📉 -177 B (-2.11%) | 8.19 kB → 8.01 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.85 MB → 1.85 MB (-177 B) | -0.01% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 814.39 kB | 0% static/js/PayeeRuleCountLabel.js | 52.12 kB | 0% static/js/ReportRouter.js | 1.18 MB | 0% static/js/ScheduleEditForm.js | 136.13 kB | 0% static/js/TransactionEdit.js | 185.13 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/Value.js | 4.34 MB | 0% static/js/ca.js | 191.72 kB | 0% static/js/chart-theme.js | 709.55 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 104.4 kB | 0% static/js/de.js | 174.12 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.5 kB | 0% static/js/es.js | 181.54 kB | 0% static/js/extends.js | 486.5 kB | 0% static/js/fr.js | 176.79 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.68 kB | 0% static/js/narrow.js | 363.68 kB | 0% static/js/nb-NO.js | 151.58 kB | 0% static/js/nl.js | 108.66 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 193.49 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.91 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.28 kB | 0% static/js/useFormatList.js | 9.86 kB | 0% static/js/wide.js | 292 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.19 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.85 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BiN7Vxsx.js | 4.85 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.91 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:25:46 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41628