github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7476] [MERGED] [AI] Add Sankey report toggle to view values as percentages #41590

New Issue
Closed
opened 2026-04-23 14:23:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 14:23:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7476
Author: @emiltb
Created: 4/11/2026
Status: ✅ Merged
Merged: 4/13/2026
Merged by: @youngcw

Base: master ← Head: sankey-percentage

📝 Commits (6)

  • 60298dd Add Options button. Add toggle for showing values as percentages.
  • 0c54027 Add release note
  • 42439ff [autofix.ci] apply automated fixes
  • 5a09ca2 Ensure 0's are also reported as percentages for consistency
  • e071ece Shorten release note
  • cef99b0 Remove reduncant type assertions

📊 Changes

6 files changed (+128 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx (+9 -1)
📝 packages/desktop-client/src/components/reports/reports/Sankey.tsx (+61 -2)
📝 packages/desktop-client/src/components/reports/reports/SankeyCard.tsx (+7 -1)
📝 packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.ts (+44 -0)
📝 packages/loot-core/src/types/models/dashboard.ts (+1 -0)
➕ upcoming-release-notes/7476.md (+6 -0)

📄 Description

Description

Adds requested option to view values as percentages instead of absolute values. Each layer in the Sankey chart sums to 100%. In the anticipation, that more options for customization will be requested, the toggle for viewing as percentages has been placed behind an Options button, which leaves room for more toggles to be added later.

Related issue(s)

Relates to #1919.

Testing

Tested and verified that values can be viewed as percentages. The toggle option can be saved and takes effect on both the report and the card.

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 12.9 MB → 12.91 MB (+4.8 kB) +0.04%
loot-core 1 4.84 MB 0%
api 1 3.88 MB 0%
cli 1 7.89 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 12.9 MB → 12.91 MB (+4.8 kB) +0.04%
Changeset
File Δ Size
src/components/reports/reports/Sankey.tsx 📈 +3.37 kB (+13.36%) 25.21 kB → 28.58 kB
src/components/reports/spreadsheets/sankey-spreadsheet.ts 📈 +932 B (+7.06%) 12.9 kB → 13.81 kB
src/components/reports/graphs/SankeyGraph.tsx 📈 +367 B (+3.82%) 9.38 kB → 9.74 kB
src/components/reports/reports/SankeyCard.tsx 📈 +171 B (+2.30%) 7.26 kB → 7.43 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.17 MB → 1.18 MB (+4.8 kB) +0.40%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.32 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 852.77 kB 0%
static/js/TransactionList.js 82.49 kB 0%
static/js/Value.js 4.33 MB 0%
static/js/ca.js 191.98 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.38 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 175.89 kB 0%
static/js/es.js 181.8 kB 0%
static/js/extends.js 485.17 kB 0%
static/js/fr.js 177.08 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.95 kB 0%
static/js/narrow.js 363.02 kB 0%
static/js/nb-NO.js 151.85 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.44 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 179.3 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.6 kB 0%
static/js/wide.js 295 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 110.05 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.84 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.ddTTAQMt.js 4.84 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.88 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.89 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7476 **Author:** [@emiltb](https://github.com/emiltb) **Created:** 4/11/2026 **Status:** ✅ Merged **Merged:** 4/13/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `sankey-percentage` --- ### 📝 Commits (6) - [`60298dd`](https://github.com/actualbudget/actual/commit/60298dd65343555ef6856e398279326a3806a729) Add Options button. Add toggle for showing values as percentages. - [`0c54027`](https://github.com/actualbudget/actual/commit/0c54027c57ff7550c56691a48279ead9b5fb69b0) Add release note - [`42439ff`](https://github.com/actualbudget/actual/commit/42439fface536a468304f29c3b1716b25e491708) [autofix.ci] apply automated fixes - [`5a09ca2`](https://github.com/actualbudget/actual/commit/5a09ca21f9255d5ea64ab764320183d2ec5c695f) Ensure 0's are also reported as percentages for consistency - [`e071ece`](https://github.com/actualbudget/actual/commit/e071ece3c88df63d3079f37e458599d698b6c0ed) Shorten release note - [`cef99b0`](https://github.com/actualbudget/actual/commit/cef99b04cd396fd7d14634256eee9c2acf14735f) Remove reduncant type assertions ### 📊 Changes **6 files changed** (+128 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx` (+9 -1) 📝 `packages/desktop-client/src/components/reports/reports/Sankey.tsx` (+61 -2) 📝 `packages/desktop-client/src/components/reports/reports/SankeyCard.tsx` (+7 -1) 📝 `packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.ts` (+44 -0) 📝 `packages/loot-core/src/types/models/dashboard.ts` (+1 -0) ➕ `upcoming-release-notes/7476.md` (+6 -0) </details> ### 📄 Description ## Description Adds requested option to view values as percentages instead of absolute values. Each layer in the Sankey chart sums to 100%. In the anticipation, that more options for customization will be requested, the toggle for viewing as percentages has been placed behind an Options button, which leaves room for more toggles to be added later. ## Related issue(s) Relates to #1919. ## Testing Tested and verified that values can be viewed as percentages. The toggle option can be saved and takes effect on both the report and the card. ## Checklist - [X] Release notes added (see link above) - [X] No obvious regressions in affected areas - [X] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 12.9 MB → 12.91 MB (+4.8 kB) | +0.04% loot-core | 1 | 4.84 MB | 0% api | 1 | 3.88 MB | 0% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 12.9 MB → 12.91 MB (+4.8 kB) | +0.04% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/reports/Sankey.tsx` | 📈 +3.37 kB (+13.36%) | 25.21 kB → 28.58 kB `src/components/reports/spreadsheets/sankey-spreadsheet.ts` | 📈 +932 B (+7.06%) | 12.9 kB → 13.81 kB `src/components/reports/graphs/SankeyGraph.tsx` | 📈 +367 B (+3.82%) | 9.38 kB → 9.74 kB `src/components/reports/reports/SankeyCard.tsx` | 📈 +171 B (+2.30%) | 7.26 kB → 7.43 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.17 MB → 1.18 MB (+4.8 kB) | +0.40% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.32 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 852.77 kB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/Value.js | 4.33 MB | 0% static/js/ca.js | 191.98 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.38 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 175.89 kB | 0% static/js/es.js | 181.8 kB | 0% static/js/extends.js | 485.17 kB | 0% static/js/fr.js | 177.08 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.95 kB | 0% static/js/narrow.js | 363.02 kB | 0% static/js/nb-NO.js | 151.85 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.44 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 179.3 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.6 kB | 0% static/js/wide.js | 295 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.05 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.ddTTAQMt.js | 4.84 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:23:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41590
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?