[PR #7383] [MERGED] [AI] Add electron conditions to loot-core platform/server exports #41554

New Issue

GiteaMirror · 2026-04-23T14:20:39-05:00

GiteaMirror commented

2026-04-23 14:20:39 -05:00

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7383
Author: @MatissJanis
Created: 4/5/2026
Status: ✅ Merged
Merged: 4/7/2026
Merged by: @MatissJanis

Base: master ← Head: claude/add-electron-files-package-BdUx1

📝 Commits (10+)

af5c068 trim down some unused/unnecessary dependencies (#7350)
e1a4fde [Doc] More tour image (mostly) updates & a hotkey fix (#7328)
b756332 Implement Sankey report for spent and budgeted money (#7220)
e5bca59 Fix yarn generate:icons command (#7281)
b96eec5 Standardise ledger scrolling when using keyboard shortcuts (#7283)
2ccdf0f Fix updateTransaction corrupting split parents with partial updates (#7242)
238f861 [AI] Add electron conditions to loot-core platform/server exports and fix imports
db29f0c [AI] Convert remaining relative imports to subpath imports in electron files
faa7e72 Add release notes for PR #7383
d0f6302 [AI] Fix API build and test failures from conditional exports

📊 Changes

48 files changed (+184 additions, -102 deletions)

View changed files

📝 packages/api/tsconfig.json (+1 -0)
📝 packages/api/vite.config.ts (+6 -1)
📝 packages/loot-core/package.json (+73 -9)
📝 packages/loot-core/src/mocks/random.ts (+1 -1)
📝 packages/loot-core/src/mocks/setup.ts (+3 -3)
📝 packages/loot-core/src/platform/exceptions/index.ts (+1 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/index.electron.ts (+2 -2)
📝 packages/loot-core/src/platform/server/connection/index.electron.ts (+4 -4)
📝 packages/loot-core/src/platform/server/fetch/index.ts (+1 -1)
📝 packages/loot-core/src/platform/server/fs/index.test.ts (+2 -2)
📝 packages/loot-core/src/platform/server/fs/index.ts (+6 -7)
📝 packages/loot-core/src/platform/server/fs/shared.ts (+1 -1)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+2 -2)
📝 packages/loot-core/src/server/accounts/app.ts (+3 -3)
📝 packages/loot-core/src/server/accounts/sync.test.ts (+1 -1)
📝 packages/loot-core/src/server/accounts/sync.ts (+1 -1)
📝 packages/loot-core/src/server/admin/app.ts (+1 -1)
📝 packages/loot-core/src/server/api.ts (+2 -2)
📝 packages/loot-core/src/server/auth/app.ts (+1 -1)
📝 packages/loot-core/src/server/budget/actions.ts (+1 -1)

...and 28 more files

📄 Description

Yet another step toward de-tangling the cross-package depencies and imports..

This time: adding proper electron/api exports.

Bundle Stats

Bundle	Files count	Total bundle size	% Changed
desktop-client	27	12.4 MB	0%
loot-core	1	4.84 MB	0%
api	1	3.83 MB → 3.83 MB (+210 B)	+0.01%
cli	1	7.89 MB	0%

View detailed bundle stats

desktop-client

Total

Files count	Total bundle size	% Changed
27	12.4 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/index.js	3.31 MB	0%
static/js/BackgroundImage.js	121.09 kB	0%
static/js/FormulaEditor.js	852.77 kB	0%
static/js/ReportRouter.js	1.17 MB	0%
static/js/TransactionList.js	82.49 kB	0%
static/js/ca.js	190.11 kB	0%
static/js/da.js	104.66 kB	0%
static/js/de.js	174.79 kB	0%
static/js/en-GB.js	7.16 kB	0%
static/js/en.js	173.2 kB	0%
static/js/es.js	182.18 kB	0%
static/js/fr.js	177.47 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.46 kB	0%
static/js/it.js	166.25 kB	0%
static/js/narrow.js	363.02 kB	0%
static/js/nb-NO.js	152.2 kB	0%
static/js/nl.js	108.93 kB	0%
static/js/pl.js	88.34 kB	0%
static/js/pt-BR.js	177.84 kB	0%
static/js/resize-observer.js	18.06 kB	0%
static/js/th.js	179.94 kB	0%
static/js/theme.js	30.79 kB	0%
static/js/uk.js	213.14 kB	0%
static/js/useTransactionBatchActions.js	4.33 MB	0%
static/js/wide.js	295 B	0%
static/js/workbox-window.prod.es5.js	7.33 kB	0%
static/js/zh-Hans.js	94.19 kB	0%

loot-core

Total

Files count	Total bundle size	% Changed
1	4.84 MB	0%

View detailed bundle breakdown

Added

Asset	File Size	% Changed
kcab.worker.BkkdkSI8.js	0 B → 4.84 MB (+4.84 MB)	-

Removed

Asset	File Size	% Changed
kcab.worker.DBamn1E9.js	4.84 MB → 0 B (-4.84 MB)	-100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count	Total bundle size	% Changed
1	3.83 MB → 3.83 MB (+210 B)	+0.01%

Changeset

File	Δ	Size
`node_modules/uuid/dist/v4.js`	🆕 +758 B	0 B → 758 B
`node_modules/uuid/dist/stringify.js`	🆕 +727 B	0 B → 727 B
`node_modules/uuid/dist/rng.js`	🆕 +437 B	0 B → 437 B
`node_modules/uuid/dist/native.js`	🆕 +202 B	0 B → 202 B
`home/runner/work/actual/actual/packages/loot-core/src/server/encryption/encryption-internals.electron.ts`	📈 +14 B (+0.73%)	1.87 kB → 1.89 kB
`node_modules/uuid/dist-node/v4.js`	🔥 -763 B (-100%)	763 B → 0 B
`node_modules/uuid/dist-node/stringify.js`	🔥 -732 B (-100%)	732 B → 0 B
`node_modules/uuid/dist-node/rng.js`	🔥 -305 B (-100%)	305 B → 0 B
`node_modules/uuid/dist-node/native.js`	🔥 -128 B (-100%)	128 B → 0 B

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset	File Size	% Changed
index.js	3.83 MB → 3.83 MB (+210 B)	+0.01%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

cli

Total

Files count	Total bundle size	% Changed
1	7.89 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
cli.js	7.89 MB	0%

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7383 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/5/2026 **Status:** ✅ Merged **Merged:** 4/7/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/add-electron-files-package-BdUx1` --- ### 📝 Commits (10+) - [`af5c068`](https://github.com/actualbudget/actual/commit/af5c068991990ffb11de25f6c3866abfd45638d7) trim down some unused/unnecessary dependencies (#7350) - [`e1a4fde`](https://github.com/actualbudget/actual/commit/e1a4fde2f3b4fcfb47be168d0e4f0aad08ece5c7) [Doc] More tour image (mostly) updates & a hotkey fix (#7328) - [`b756332`](https://github.com/actualbudget/actual/commit/b75633258305cfa130e820dc21fa3dd938fb8bfe) Implement Sankey report for spent and budgeted money (#7220) - [`e5bca59`](https://github.com/actualbudget/actual/commit/e5bca59bc6642120c23cfe47f68e0f282dbea802) Fix yarn generate:icons command (#7281) - [`b96eec5`](https://github.com/actualbudget/actual/commit/b96eec51ca41c185475b54483daf55eaacfab190) Standardise ledger scrolling when using keyboard shortcuts (#7283) - [`2ccdf0f`](https://github.com/actualbudget/actual/commit/2ccdf0f6e8fd9658ed11c9df1b70a0770a82874d) Fix updateTransaction corrupting split parents with partial updates (#7242) - [`238f861`](https://github.com/actualbudget/actual/commit/238f861e8f205abf8f2cc7419eeac90b90f13ff0) [AI] Add electron conditions to loot-core platform/server exports and fix imports - [`db29f0c`](https://github.com/actualbudget/actual/commit/db29f0cc90adabe310a1451f2807dea049bd33cf) [AI] Convert remaining relative imports to subpath imports in electron files - [`faa7e72`](https://github.com/actualbudget/actual/commit/faa7e727ff90276e803dcd7267b2fc9f67766dff) Add release notes for PR #7383 - [`d0f6302`](https://github.com/actualbudget/actual/commit/d0f6302df1a34a7c481ad8ea0d4eb180caca3543) [AI] Fix API build and test failures from conditional exports ### 📊 Changes **48 files changed** (+184 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/tsconfig.json` (+1 -0) 📝 `packages/api/vite.config.ts` (+6 -1) 📝 `packages/loot-core/package.json` (+73 -9) 📝 `packages/loot-core/src/mocks/random.ts` (+1 -1) 📝 `packages/loot-core/src/mocks/setup.ts` (+3 -3) 📝 `packages/loot-core/src/platform/exceptions/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.electron.ts` (+2 -2) 📝 `packages/loot-core/src/platform/server/connection/index.electron.ts` (+4 -4) 📝 `packages/loot-core/src/platform/server/fetch/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/fs/index.test.ts` (+2 -2) 📝 `packages/loot-core/src/platform/server/fs/index.ts` (+6 -7) 📝 `packages/loot-core/src/platform/server/fs/shared.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+2 -2) 📝 `packages/loot-core/src/server/accounts/app.ts` (+3 -3) 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+1 -1) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+1 -1) 📝 `packages/loot-core/src/server/admin/app.ts` (+1 -1) 📝 `packages/loot-core/src/server/api.ts` (+2 -2) 📝 `packages/loot-core/src/server/auth/app.ts` (+1 -1) 📝 `packages/loot-core/src/server/budget/actions.ts` (+1 -1) _...and 28 more files_ </details> ### 📄 Description Yet another step toward de-tangling the cross-package depencies and imports.. This time: adding proper electron/api exports.  <hr />  ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.4 MB | 0% loot-core | 1 | 4.84 MB | 0% api | 1 | 3.83 MB → 3.83 MB (+210 B) | +0.01% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.4 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.31 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 852.77 kB | 0% static/js/ReportRouter.js | 1.17 MB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/ca.js | 190.11 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.79 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 173.2 kB | 0% static/js/es.js | 182.18 kB | 0% static/js/fr.js | 177.47 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 166.25 kB | 0% static/js/narrow.js | 363.02 kB | 0% static/js/nb-NO.js | 152.2 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.84 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/useTransactionBatchActions.js | 4.33 MB | 0% static/js/wide.js | 295 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 94.19 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.84 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BkkdkSI8.js | 0 B → 4.84 MB (+4.84 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DBamn1E9.js | 4.84 MB → 0 B (-4.84 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.83 MB → 3.83 MB (+210 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `node_modules/uuid/dist/v4.js` | 🆕 +758 B | 0 B → 758 B `node_modules/uuid/dist/stringify.js` | 🆕 +727 B | 0 B → 727 B `node_modules/uuid/dist/rng.js` | 🆕 +437 B | 0 B → 437 B `node_modules/uuid/dist/native.js` | 🆕 +202 B | 0 B → 202 B `home/runner/work/actual/actual/packages/loot-core/src/server/encryption/encryption-internals.electron.ts` | 📈 +14 B (+0.73%) | 1.87 kB → 1.89 kB `node_modules/uuid/dist-node/v4.js` | 🔥 -763 B (-100%) | 763 B → 0 B `node_modules/uuid/dist-node/stringify.js` | 🔥 -732 B (-100%) | 732 B → 0 B `node_modules/uuid/dist-node/rng.js` | 🔥 -305 B (-100%) | 305 B → 0 B `node_modules/uuid/dist-node/native.js` | 🔥 -128 B (-100%) | 128 B → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.83 MB → 3.83 MB (+210 B) | +0.01% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-23 14:20:39 -05:00

GiteaMirror closed this issue

2026-04-23 14:20:42 -05:00

Sign in to join this conversation.

Branches Tags

master

claude/hide-default-categories-1cwBZ

matiss/crdt-source-loading

youngcw/unlock-duplicates

matiss/crdt-protobuf

release/26.5.0

claude/update-issue-template-ykMNn

claude/fix-issue-7667-DPXi3

cursor/formula-feedback-improvements-4223

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

jfdoming/api-tokens-part-3

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-1

claude/speed-up-vrt-workflow-ZAyI5

claude/crdt-version-auto-publish-Ph1BH

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

worktree-mellow-strolling-dawn

matiss/browser-api

claude/api-consumer-verification-kfz1K

feature/enable-banking

cursor/transaction-table-rewrite-f077

pr-7454

claude/fix-issue-7410-LLLQ4

release/v100.0.0

revert-7350-trim-deps

revert-7220-sankey-report

revert-7242-fix/split-parent-update-corruption

revert-7281-generate-icons

claude/electron-to-tauri-migration-LjBN8

worktree-remotion

release/vv26.4.0-pre

claude/browser-compatible-api-QbhHh

claude/improve-cli-transactions-waTUY

claude/publish-react-native-ios-j8qoT

js-proxy

claude/fix-flaky-ci-job-5gDdz

react-query-rules

react-query-useSchedules

claude/nightly-theme-validation-scan-DzOGD

claude/debug-simplefin-error-ZuKzB

matiss/desktop-client-subpath-imports

claude/fix-simplefin-ssrf-T31gX

claude/release-notes-validation-X7rvR

add-claude-github-actions-1772738270730

cursor/sync-performance-notification-9899

react-query-prefs

matiss/chunked-sync-and-progress-ux

v26.2.1

copilot/sub-pr-6880

fix-react-query-clear-on-close-budget

copilot/sub-pr-6140

feat/auto-note

feat/scoped-bank-sync

cursor/desktop-transactions-react-table-1d0c

fix-exhaustive-deps-App

copilot/fix-find-replace-bug

release/v26.2.0-pre

matiss/browser-tests

mobile-fix-drag-and-drop-across-groups

budget-table-v2

PayeeAutocomplete2

pglite

bugfix/plugins/fix-plugins-sw

feat/plugins/plugins-core-package

prerelease

matiss/unicode-minus-fix

cursor/fix-actual-github-issue-6206-gemini-3-pro-preview-9c37

TransactionFormPage

cursor/implement-mortgage-and-loan-account-type-78ca

tests-update-fill-with-pressSequentially

mobile/link-modal

deps/25.11

cursor/fix-update-vrt-apply-ci-job-dispatch-b324

sync-server-plugins

cursor/propose-patch-for-github-issue-5680-2a18

fix/compiler-preserve-inner-dollar-escapes

cursor/analyze-actual-budget-issue-and-propose-fix-5b70

coderabbitai/docstrings/0c070e5

cursor/add-wip-prefix-and-comment-to-prs-d78d

jfdoming/08-21-auto-focus-on-navigate-in-all-browsers

show-totals-on-mobile-budget-banners

allow-child-transactions-make-transfer

mobile-calculator-keyboard

payee-geolocation

enhance/restore_scroll_position

dm-fix-second-click-on-mobile-new-transaction-2

scrollToLocationBudget

alert-autofix-38

tsconfig-composite

mobile-fix-uncategorized-transactions-on-tracking-budgets

server-budget-handlers

fix-sql-injection-in-cleanup-template

non-chrome-draggable-workaround

mobile-budget-page-swipe-navigation

ts-db-all

stable

dark-theme-with-brand-colors

fix-mobile-delete-group

ts-db-select

UnderKoen/reconcile-context-menu

master-before-server-merge

v25.2.1

ts-runQuery

rename-redux-hooks

UnderKoen/3557-persist-state-in-history

remove-redux-CLOSE_BUDGET

fix-exhaustive-deps-errors-FinancesApp

redux-toolkit-createSlice-backup

accounts-function-component

ts-useSplitsExpanded

loot-core-server-package

useTransactios-in-TransactionEdit

react-aria-input

move-redux-to-desktop-client

QueryState-type

fix-themes-applied-late

mobile-vrts

revert-3295-spendingCardFix

react-aria-button-4

split-payee-on-mobile

twk3/pin-apis-crdt

notes-tag-autocomplete

ts-LoadBackup

dnd-kit

package-upgrades

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#41554