github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7296] [MERGED] Fix Net Worth graph not showing correct number of intervals #41499

New Issue
Closed
opened 2026-04-23 14:17:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 14:17:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7296
Author: @emiltb
Created: 3/26/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @youngcw

Base: master ← Head: net-worth-change-value

📝 Commits (9)

  • 226c67a Fix Net Worth graph showing N-1 intervals, resulting in inconsistent totalChange value.
  • 408db12 Fix starting date being wrong for 'daily' and 'weekly'
  • edc3532 Linting
  • c40c71c Add release note
  • dd6d8a0 Update VRT screenshots
  • 35c3af6 Remove manipulation of startDate for 'yearly'
  • 17cf324 Merge branch 'net-worth-change-value' of github.com:emiltb/actual into net-worth-change-value
  • 840b85d Remove empty datapoint at beginning when start equals earliest transaction
  • 5f5069a Merge branch 'master' into net-worth-change-value

📊 Changes

11 files changed (+47 additions, -3 deletions)

View changed files

📝 packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/net-worth-spreadsheet.ts (+41 -3)
➕ upcoming-release-notes/7296.md (+6 -0)

📄 Description

Description

The Net Worth graphs Total Change value was calculated correctly, but did not agree with the line on the graphs start- and endpoints. When a N month interval was chosen, in reality only N-1 months was shown. This could lead to weird cases, where the end point was clearly lower than the starting point, even though a positive Total Change was reported.

Related issue(s)

Fixes #7120, which was introduced due to a previous bug #6962 (fixed in #6968).

Testing

Verified by visual confirmation, that the graph now reflects the actual total change in the time period. I have verified that this change works for both monthly, daily and weekly intervals, and that there is no regression from the previous fix (i.e. the change value still appears correctly for the first point on the graph).

2026-03-26T23:09:39,451253605+01:00

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 12.09 MB → 12.09 MB (+779 B) +0.01%
loot-core 1 4.83 MB 0%
api 4 4.06 MB 0%
cli 1 7.88 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 12.09 MB → 12.09 MB (+779 B) +0.01%
Changeset
File Δ Size
src/components/reports/spreadsheets/net-worth-spreadsheet.ts 📈 +694 B (+13.56%) 5 kB → 5.68 kB
locale/es.json 📈 +85 B (+0.05%) 182.09 kB → 182.18 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.02 MB → 1.02 MB (+694 B) +0.06%
static/js/es.js 182.09 kB → 182.18 kB (+85 B) +0.05%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.23 MB 0%
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 846.44 kB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 182.91 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.79 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 170.76 kB 0%
static/js/fr.js 177.47 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 166.25 kB 0%
static/js/narrow.js 354.5 kB 0%
static/js/nb-NO.js 152.2 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.84 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/sv.js 80.58 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/useTransactionBatchActions.js 4.29 MB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.83 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.CwpE34S5.js 4.83 MB 0%

api

Total

Files count Total bundle size % Changed
4 4.06 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.84 MB 0%
from-Bl-Hslp4.js 167.73 kB 0%
multipart-parser-BnDysoMr.js 8.1 kB 0%
src-iMkUmuwR.js 43.64 kB 0%

cli

Total

Files count Total bundle size % Changed
1 7.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.88 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7296 **Author:** [@emiltb](https://github.com/emiltb) **Created:** 3/26/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `net-worth-change-value` --- ### 📝 Commits (9) - [`226c67a`](https://github.com/actualbudget/actual/commit/226c67a2adfa1a06f190e9dd0e38b2c1437f0166) Fix Net Worth graph showing N-1 intervals, resulting in inconsistent totalChange value. - [`408db12`](https://github.com/actualbudget/actual/commit/408db1265611f19b3f9b179c633a7abcba416d56) Fix starting date being wrong for 'daily' and 'weekly' - [`edc3532`](https://github.com/actualbudget/actual/commit/edc3532087eea02c915db49289b9270b8f6e5eb3) Linting - [`c40c71c`](https://github.com/actualbudget/actual/commit/c40c71cb30440b05ad1dcca1b4ace2d1ba138c5d) Add release note - [`dd6d8a0`](https://github.com/actualbudget/actual/commit/dd6d8a08f224aac3a2adf5803c911162c66dd680) Update VRT screenshots - [`35c3af6`](https://github.com/actualbudget/actual/commit/35c3af6cfa79fdb0f397cb86e731c6ea8d8aa101) Remove manipulation of startDate for 'yearly' - [`17cf324`](https://github.com/actualbudget/actual/commit/17cf32471aa001b481b255bd369b6d916500745c) Merge branch 'net-worth-change-value' of github.com:emiltb/actual into net-worth-change-value - [`840b85d`](https://github.com/actualbudget/actual/commit/840b85dd92e207e16db055404ca80e0745dbb1db) Remove empty datapoint at beginning when start equals earliest transaction - [`5f5069a`](https://github.com/actualbudget/actual/commit/5f5069a19d220f75478483d38d552aa49d98a266) Merge branch 'master' into net-worth-change-value ### 📊 Changes **11 files changed** (+47 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/command-bar.test.ts-snapshots/Command-bar-Check-the-command-bar-search-works-correctly-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/net-worth-spreadsheet.ts` (+41 -3) ➕ `upcoming-release-notes/7296.md` (+6 -0) </details> ### 📄 Description ## Description The Net Worth graphs Total Change value was calculated correctly, but did not agree with the line on the graphs start- and endpoints. When a N month interval was chosen, in reality only N-1 months was shown. This could lead to weird cases, where the end point was clearly lower than the starting point, even though a positive Total Change was reported. ## Related issue(s) Fixes #7120, which was introduced due to a previous bug #6962 (fixed in #6968). ## Testing Verified by visual confirmation, that the graph now reflects the actual total change in the time period. I have verified that this change works for both monthly, daily and weekly intervals, and that there is no regression from the previous fix (i.e. the change value still appears correctly for the first point on the graph). <img width="841" height="366" alt="2026-03-26T23:09:39,451253605+01:00" src="https://github.com/user-attachments/assets/f0f83f52-fee6-495f-992b-14b6e01a656c" /> ## Checklist - [X] Release notes added (see link above) - [X] No obvious regressions in affected areas - [X] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.09 MB → 12.09 MB (+779 B) | +0.01% loot-core | 1 | 4.83 MB | 0% api | 4 | 4.06 MB | 0% cli | 1 | 7.88 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.09 MB → 12.09 MB (+779 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/spreadsheets/net-worth-spreadsheet.ts` | 📈 +694 B (+13.56%) | 5 kB → 5.68 kB `locale/es.json` | 📈 +85 B (+0.05%) | 182.09 kB → 182.18 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.02 MB → 1.02 MB (+694 B) | +0.06% static/js/es.js | 182.09 kB → 182.18 kB (+85 B) | +0.05% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.23 MB | 0% static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 846.44 kB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 182.91 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.79 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 170.76 kB | 0% static/js/fr.js | 177.47 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 166.25 kB | 0% static/js/narrow.js | 354.5 kB | 0% static/js/nb-NO.js | 152.2 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.84 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/sv.js | 80.58 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/useTransactionBatchActions.js | 4.29 MB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.83 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CwpE34S5.js | 4.83 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 4 | 4.06 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB | 0% from-Bl-Hslp4.js | 167.73 kB | 0% multipart-parser-BnDysoMr.js | 8.1 kB | 0% src-iMkUmuwR.js | 43.64 kB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.88 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:17:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41499
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?