github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #7225] [AI] Fix batchMessages losing nested batch messages on outer failure #41450

New Issue
Open
opened 2026-04-23 14:14:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 14:14:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7225
Author: @dearlordylord
Created: 3/17/2026
Status: 🔄 Open

Base: master ← Head: fix/batch-messages-concurrency

📝 Commits (4)

  • 293d8c4 [AI] fix batchMessages losing nested batch messages on outer failure
  • 943f7af [AI] fix lint errors and add release notes
  • b024ec1 [AI] use lint suppress instead of dummy Error allocation
  • 5101dad [AI] use Error | undefined instead of unknown

📊 Changes

3 files changed (+179 additions, -3 deletions)

View changed files

➕ packages/loot-core/src/server/sync/batchMessages.test.ts (+147 -0)
📝 packages/loot-core/src/server/sync/index.ts (+26 -3)
➕ upcoming-release-notes/7225.md (+6 -0)

📄 Description

Description

batchMessages uses module-level globals IS_BATCHING and _BATCHED shared across async operations. When two async callers interleave (cooperative scheduling via await), a nested batch's messages get silently lost if the outer batch throws - the catch block ran before _sendMessages, discarding everything in _BATCHED.

Fix moves _sendMessages call outside try/catch so accumulated messages are always sent regardless of whether func() threw.

Related issue(s)

None (found via code audit)

Testing

Added batchMessages.test.ts with two tests:

  • Outer batch fails after inner completes - verifies inner messages are preserved
  • Both batches succeed - positive control

Both tests use promise-based yield control to deterministically reproduce the interleaving.

Checklist

  • Release notes added
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 26 11.81 MB 0%
loot-core 1 4.83 MB → 4.83 MB (+259 B) +0.01%
api 4 4.05 MB → 4.05 MB (+250 B) +0.01%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
26 11.81 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.21 MB 0%
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 716.38 kB 0%
static/js/ReportRouter.js 1002.19 kB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 185.62 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 177.63 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 169.27 kB 0%
static/js/es.js 172.13 kB 0%
static/js/fr.js 177.63 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.97 kB 0%
static/js/narrow.js 353.32 kB 0%
static/js/nb-NO.js 154.72 kB 0%
static/js/nl.js 111.58 kB 0%
static/js/pl.js 88.31 kB 0%
static/js/pt-BR.js 180.55 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/useTransactionBatchActions.js 4.27 MB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.83 MB → 4.83 MB (+259 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/sync/index.ts 📈 +259 B (+1.84%) 13.74 kB → 14 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BYOYYYBz.js 0 B → 4.83 MB (+4.83 MB) -

Removed

Asset File Size % Changed
kcab.worker.Bu63xj1l.js 4.83 MB → 0 B (-4.83 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
4 4.05 MB → 4.05 MB (+250 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/sync/index.ts 📈 +250 B (+1.83%) 13.35 kB → 13.6 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.83 MB → 3.83 MB (+250 B) +0.01%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
from-Bl-Hslp4.js 167.73 kB 0%
multipart-parser-BnDysoMr.js 8.1 kB 0%
src-iMkUmuwR.js 43.64 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7225 **Author:** [@dearlordylord](https://github.com/dearlordylord) **Created:** 3/17/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/batch-messages-concurrency` --- ### 📝 Commits (4) - [`293d8c4`](https://github.com/actualbudget/actual/commit/293d8c4ed07da6f4b409c3ae6897dea480a996fd) [AI] fix batchMessages losing nested batch messages on outer failure - [`943f7af`](https://github.com/actualbudget/actual/commit/943f7af9f3c99d05a903ae75ddffce2f6d7115c4) [AI] fix lint errors and add release notes - [`b024ec1`](https://github.com/actualbudget/actual/commit/b024ec13c5fa0a0e3275ad0b48e493378e578c32) [AI] use lint suppress instead of dummy Error allocation - [`5101dad`](https://github.com/actualbudget/actual/commit/5101dad43860ce94dab7f486469dbcf5ce360ba3) [AI] use Error | undefined instead of unknown ### 📊 Changes **3 files changed** (+179 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `packages/loot-core/src/server/sync/batchMessages.test.ts` (+147 -0) 📝 `packages/loot-core/src/server/sync/index.ts` (+26 -3) ➕ `upcoming-release-notes/7225.md` (+6 -0) </details> ### 📄 Description ## Description `batchMessages` uses module-level globals `IS_BATCHING` and `_BATCHED` shared across async operations. When two async callers interleave (cooperative scheduling via await), a nested batch's messages get silently lost if the outer batch throws - the catch block ran before `_sendMessages`, discarding everything in `_BATCHED`. Fix moves `_sendMessages` call outside try/catch so accumulated messages are always sent regardless of whether `func()` threw. ## Related issue(s) None (found via code audit) ## Testing Added `batchMessages.test.ts` with two tests: - Outer batch fails after inner completes - verifies inner messages are preserved - Both batches succeed - positive control Both tests use promise-based yield control to deterministically reproduce the interleaving. ## Checklist - [ ] Release notes added - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 26 | 11.81 MB | 0% loot-core | 1 | 4.83 MB → 4.83 MB (+259 B) | +0.01% api | 4 | 4.05 MB → 4.05 MB (+250 B) | +0.01% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 26 | 11.81 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.21 MB | 0% static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 716.38 kB | 0% static/js/ReportRouter.js | 1002.19 kB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 185.62 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 177.63 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 169.27 kB | 0% static/js/es.js | 172.13 kB | 0% static/js/fr.js | 177.63 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.97 kB | 0% static/js/narrow.js | 353.32 kB | 0% static/js/nb-NO.js | 154.72 kB | 0% static/js/nl.js | 111.58 kB | 0% static/js/pl.js | 88.31 kB | 0% static/js/pt-BR.js | 180.55 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/useTransactionBatchActions.js | 4.27 MB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.83 MB → 4.83 MB (+259 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/sync/index.ts` | 📈 +259 B (+1.84%) | 13.74 kB → 14 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BYOYYYBz.js | 0 B → 4.83 MB (+4.83 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Bu63xj1l.js | 4.83 MB → 0 B (-4.83 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 4 | 4.05 MB → 4.05 MB (+250 B) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/sync/index.ts` | 📈 +250 B (+1.83%) | 13.35 kB → 13.6 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.83 MB → 3.83 MB (+250 B) | +0.01% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- from-Bl-Hslp4.js | 167.73 kB | 0% multipart-parser-BnDysoMr.js | 8.1 kB | 0% src-iMkUmuwR.js | 43.64 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:14:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?