github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7168] [MERGED] lint: promote no-floating-promises and require-array-sort-compare to error and fix violations #41415

New Issue
Closed
opened 2026-04-23 14:12:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 14:12:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7168
Author: @MatissJanis
Created: 3/10/2026
Status: ✅ Merged
Merged: 3/12/2026
Merged by: @MatissJanis

Base: master ← Head: matiss/oxlint-no-floating-promises-require-array-sort-compare

📝 Commits (4)

  • 6445180 lint: promote no-floating-promises and require-array-sort-compare to error and fix violations
  • 1216a2e refactor: update sorting functions to use two-argument comparator
  • bed293f Update index.ts
  • f8fa751 Merge remote-tracking branch 'origin/master' into matiss/oxlint-no-floating-promises-require-array-sort-compare

📊 Changes

16 files changed (+74 additions, -31 deletions)

View changed files

📝 .oxlintrc.json (+2 -2)
📝 packages/crdt/src/crdt/merkle.ts (+2 -2)
📝 packages/desktop-client/src/components/budget/BudgetSummaries.tsx (+2 -2)
📝 packages/desktop-client/src/components/filters/FiltersMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/ActionableGridListItem.tsx (+3 -3)
📝 packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (+4 -4)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useScheduleEdit.ts (+5 -3)
📝 packages/desktop-electron/index.ts (+4 -2)
📝 packages/loot-core/src/server/aql/exec.test.ts (+6 -2)
📝 packages/loot-core/src/server/budget/category-template-context.ts (+3 -1)
📝 packages/loot-core/src/server/budget/goal-template.ts (+1 -1)
📝 packages/loot-core/src/server/main.test.ts (+9 -3)
📝 packages/loot-core/src/shared/transactions.test.ts (+24 -3)
📝 packages/sync-server/src/migrations.ts (+1 -1)
➕ upcoming-release-notes/7168.md (+6 -0)

📄 Description

Description

Fix two more lint issues and convert them to "error"

Related issue(s)

N/A

Testing

N/A

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.92 MB → 14.92 MB (-369 B) -0.00%
loot-core 1 5.83 MB → 5.83 MB (+106 B) +0.00%
api 1 4.44 MB → 4.44 MB (+98 B) +0.00%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.92 MB → 14.92 MB (-369 B) -0.00%
Changeset
File Δ Size
src/components/filters/FiltersMenu.tsx 📈 +71 B (+0.38%) 18.29 kB → 18.36 kB
locale/en.json 📈 +353 B (+0.20%) 170.86 kB → 171.21 kB
src/hooks/useScheduleEdit.ts 📈 +12 B (+0.11%) 10.55 kB → 10.56 kB
src/components/mobile/transactions/TransactionEdit.tsx 📈 +5 B (+0.01%) 65.99 kB → 66 kB
locale/th.json 📉 -40 B (-0.02%) 181.58 kB → 181.54 kB
locale/nl.json 📉 -29 B (-0.03%) 113.06 kB → 113.03 kB
locale/pt-BR.json 📉 -74 B (-0.04%) 182.89 kB → 182.82 kB
locale/pl.json 📉 -38 B (-0.04%) 89.65 kB → 89.61 kB
locale/nb-NO.json 📉 -67 B (-0.04%) 156.8 kB → 156.74 kB
locale/it.json 📉 -74 B (-0.04%) 170.98 kB → 170.91 kB
locale/de.json 📉 -78 B (-0.04%) 179.89 kB → 179.82 kB
locale/fr.json 📉 -78 B (-0.04%) 179.41 kB → 179.34 kB
locale/ca.json 📉 -82 B (-0.04%) 187.93 kB → 187.85 kB
locale/uk.json 📉 -94 B (-0.04%) 215.35 kB → 215.25 kB
locale/es.json 📉 -82 B (-0.05%) 174.37 kB → 174.29 kB
locale/da.json 📉 -74 B (-0.07%) 106.2 kB → 106.13 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/en.js 170.86 kB → 171.21 kB (+353 B) +0.20%
static/js/index.js 9.57 MB → 9.57 MB (+88 B) +0.00%

Smaller

Asset File Size % Changed
static/js/uk.js 215.35 kB → 215.25 kB (-94 B) -0.04%
static/js/ca.js 187.93 kB → 187.85 kB (-82 B) -0.04%
static/js/es.js 174.37 kB → 174.29 kB (-82 B) -0.05%
static/js/de.js 179.89 kB → 179.82 kB (-78 B) -0.04%
static/js/fr.js 179.41 kB → 179.34 kB (-78 B) -0.04%
static/js/da.js 106.2 kB → 106.13 kB (-74 B) -0.07%
static/js/it.js 170.98 kB → 170.91 kB (-74 B) -0.04%
static/js/pt-BR.js 182.89 kB → 182.82 kB (-74 B) -0.04%
static/js/nb-NO.js 156.8 kB → 156.74 kB (-67 B) -0.04%
static/js/th.js 181.58 kB → 181.54 kB (-40 B) -0.02%
static/js/pl.js 89.65 kB → 89.61 kB (-38 B) -0.04%
static/js/nl.js 113.06 kB → 113.03 kB (-29 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.16 MB 0%
static/js/narrow.js 638.11 kB 0%
static/js/TransactionList.js 106.48 kB 0%
static/js/wide.js 164.15 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.57 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.83 MB → 5.83 MB (+106 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/crdt/src/crdt/merkle.ts 📈 +56 B (+2.35%) 2.33 kB → 2.39 kB
home/runner/work/actual/actual/packages/loot-core/src/server/budget/goal-template.ts 📈 +15 B (+0.21%) 7.01 kB → 7.02 kB
home/runner/work/actual/actual/packages/loot-core/src/server/budget/category-template-context.ts 📈 +35 B (+0.15%) 23.49 kB → 23.52 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.BXBUG0oo.js 0 B → 5.83 MB (+5.83 MB) -

Removed

Asset File Size % Changed
kcab.worker.BJYv72EV.js 5.83 MB → 0 B (-5.83 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
1 4.44 MB → 4.44 MB (+98 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/crdt/src/crdt/merkle.ts 📈 +56 B (+2.71%) 2.02 kB → 2.07 kB
src/server/budget/goal-template.ts 📈 +15 B (+0.24%) 6.17 kB → 6.19 kB
src/server/budget/category-template-context.ts 📈 +27 B (+0.13%) 20.99 kB → 21.02 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
bundle.api.js 4.44 MB → 4.44 MB (+98 B) +0.00%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7168 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/10/2026 **Status:** ✅ Merged **Merged:** 3/12/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/oxlint-no-floating-promises-require-array-sort-compare` --- ### 📝 Commits (4) - [`6445180`](https://github.com/actualbudget/actual/commit/6445180974a0252743acb8bd8b6a849a550dbd14) lint: promote no-floating-promises and require-array-sort-compare to error and fix violations - [`1216a2e`](https://github.com/actualbudget/actual/commit/1216a2e3f7686cc3a1b365cdb20b0b505967d1d1) refactor: update sorting functions to use two-argument comparator - [`bed293f`](https://github.com/actualbudget/actual/commit/bed293f5fb78063ed5ac57bcfb6c9ab23448271e) Update index.ts - [`f8fa751`](https://github.com/actualbudget/actual/commit/f8fa7514e27a2e24e084b4cbac6a55d63a0816a0) Merge remote-tracking branch 'origin/master' into matiss/oxlint-no-floating-promises-require-array-sort-compare ### 📊 Changes **16 files changed** (+74 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+2 -2) 📝 `packages/crdt/src/crdt/merkle.ts` (+2 -2) 📝 `packages/desktop-client/src/components/budget/BudgetSummaries.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/ActionableGridListItem.tsx` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/MobileNavTabs.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useScheduleEdit.ts` (+5 -3) 📝 `packages/desktop-electron/index.ts` (+4 -2) 📝 `packages/loot-core/src/server/aql/exec.test.ts` (+6 -2) 📝 `packages/loot-core/src/server/budget/category-template-context.ts` (+3 -1) 📝 `packages/loot-core/src/server/budget/goal-template.ts` (+1 -1) 📝 `packages/loot-core/src/server/main.test.ts` (+9 -3) 📝 `packages/loot-core/src/shared/transactions.test.ts` (+24 -3) 📝 `packages/sync-server/src/migrations.ts` (+1 -1) ➕ `upcoming-release-notes/7168.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description Fix two more lint issues and convert them to "error" ## Related issue(s) N/A ## Testing N/A ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.92 MB → 14.92 MB (-369 B) | -0.00% loot-core | 1 | 5.83 MB → 5.83 MB (+106 B) | +0.00% api | 1 | 4.44 MB → 4.44 MB (+98 B) | +0.00% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.92 MB → 14.92 MB (-369 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/filters/FiltersMenu.tsx` | 📈 +71 B (+0.38%) | 18.29 kB → 18.36 kB `locale/en.json` | 📈 +353 B (+0.20%) | 170.86 kB → 171.21 kB `src/hooks/useScheduleEdit.ts` | 📈 +12 B (+0.11%) | 10.55 kB → 10.56 kB `src/components/mobile/transactions/TransactionEdit.tsx` | 📈 +5 B (+0.01%) | 65.99 kB → 66 kB `locale/th.json` | 📉 -40 B (-0.02%) | 181.58 kB → 181.54 kB `locale/nl.json` | 📉 -29 B (-0.03%) | 113.06 kB → 113.03 kB `locale/pt-BR.json` | 📉 -74 B (-0.04%) | 182.89 kB → 182.82 kB `locale/pl.json` | 📉 -38 B (-0.04%) | 89.65 kB → 89.61 kB `locale/nb-NO.json` | 📉 -67 B (-0.04%) | 156.8 kB → 156.74 kB `locale/it.json` | 📉 -74 B (-0.04%) | 170.98 kB → 170.91 kB `locale/de.json` | 📉 -78 B (-0.04%) | 179.89 kB → 179.82 kB `locale/fr.json` | 📉 -78 B (-0.04%) | 179.41 kB → 179.34 kB `locale/ca.json` | 📉 -82 B (-0.04%) | 187.93 kB → 187.85 kB `locale/uk.json` | 📉 -94 B (-0.04%) | 215.35 kB → 215.25 kB `locale/es.json` | 📉 -82 B (-0.05%) | 174.37 kB → 174.29 kB `locale/da.json` | 📉 -74 B (-0.07%) | 106.2 kB → 106.13 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/en.js | 170.86 kB → 171.21 kB (+353 B) | +0.20% static/js/index.js | 9.57 MB → 9.57 MB (+88 B) | +0.00% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/uk.js | 215.35 kB → 215.25 kB (-94 B) | -0.04% static/js/ca.js | 187.93 kB → 187.85 kB (-82 B) | -0.04% static/js/es.js | 174.37 kB → 174.29 kB (-82 B) | -0.05% static/js/de.js | 179.89 kB → 179.82 kB (-78 B) | -0.04% static/js/fr.js | 179.41 kB → 179.34 kB (-78 B) | -0.04% static/js/da.js | 106.2 kB → 106.13 kB (-74 B) | -0.07% static/js/it.js | 170.98 kB → 170.91 kB (-74 B) | -0.04% static/js/pt-BR.js | 182.89 kB → 182.82 kB (-74 B) | -0.04% static/js/nb-NO.js | 156.8 kB → 156.74 kB (-67 B) | -0.04% static/js/th.js | 181.58 kB → 181.54 kB (-40 B) | -0.02% static/js/pl.js | 89.65 kB → 89.61 kB (-38 B) | -0.04% static/js/nl.js | 113.06 kB → 113.03 kB (-29 B) | -0.03% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.16 MB | 0% static/js/narrow.js | 638.11 kB | 0% static/js/TransactionList.js | 106.48 kB | 0% static/js/wide.js | 164.15 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.57 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.83 MB → 5.83 MB (+106 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/crdt/src/crdt/merkle.ts` | 📈 +56 B (+2.35%) | 2.33 kB → 2.39 kB `home/runner/work/actual/actual/packages/loot-core/src/server/budget/goal-template.ts` | 📈 +15 B (+0.21%) | 7.01 kB → 7.02 kB `home/runner/work/actual/actual/packages/loot-core/src/server/budget/category-template-context.ts` | 📈 +35 B (+0.15%) | 23.49 kB → 23.52 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BXBUG0oo.js | 0 B → 5.83 MB (+5.83 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BJYv72EV.js | 5.83 MB → 0 B (-5.83 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.44 MB → 4.44 MB (+98 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/crdt/src/crdt/merkle.ts` | 📈 +56 B (+2.71%) | 2.02 kB → 2.07 kB `src/server/budget/goal-template.ts` | 📈 +15 B (+0.24%) | 6.17 kB → 6.19 kB `src/server/budget/category-template-context.ts` | 📈 +27 B (+0.13%) | 20.99 kB → 21.02 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.44 MB → 4.44 MB (+98 B) | +0.00% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:12:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41415
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?