mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 07:04:23 -05:00
Closed
opened 2026-04-23 14:09:53 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
dependabot/npm_and_yarn/npm_and_yarn-cd62b4b37a
api-browser-custom-data-dir
tabedzki/feat/replacing-month-picker-with-day-picker
delay-initial-sync-until-loaded
jfdoming/mobile-app-build
cross-version-sync-compat
jfdoming/api-tokens-part-1
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-3
jfdoming/mobile-app-updates
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/react-table-library-research-afx83z
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
release
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
depot-migrate-secrets-1781296330308
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#41366
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/7093
Author: @c-yco
Created: 2/27/2026
Status: ❌ Closed
Base:
master← Head:master📝 Commits (10+)
a210e86[AI] Add Enable Banking integrationd2f7573Update redirect URL handling and modify createSession parameters for banking integrationd572fa1[AI] Add Enable Banking service tests and test Docker build workflow9e0d749[AI] Fix TypeScript errors in enablebanking-service by typing request() return value1414473Merge remote-tracking branch 'upstream/master'e4bde08[AI] Enable Banking: use popup + postMessage for OAuth callback7207125[AI] Enable Banking: fix completeSession - code from OAuth callback IS the session_id1c29776[AI] Enable Banking: fix lint - wrap strings with Trans, fix formatting48c001dEnable Banking: wrap static strings with Trans for localization supportb82f418[AI] Enable Banking: fix completeSession flow and transaction/balance field mapping📊 Changes
29 files changed (+2269 additions, -18 deletions)
View changed files
➕
.github/workflows/docker-test-build.yml(+47 -0)📝
packages/desktop-client/src/accounts/mutations.ts(+43 -0)📝
packages/desktop-client/src/components/App.tsx(+11 -2)➕
packages/desktop-client/src/components/EnableBankingCallbackPage.tsx(+89 -0)📝
packages/desktop-client/src/components/Modals.tsx(+16 -0)📝
packages/desktop-client/src/components/banksync/index.tsx(+1 -0)📝
packages/desktop-client/src/components/mobile/banksync/MobileBankSyncPage.tsx(+1 -0)📝
packages/desktop-client/src/components/modals/CreateAccountModal.tsx(+137 -1)➕
packages/desktop-client/src/components/modals/EnableBankingExternalMsgModal.tsx(+417 -0)➕
packages/desktop-client/src/components/modals/EnableBankingInitialiseModal.tsx(+171 -0)📝
packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.tsx(+44 -7)➕
packages/desktop-client/src/hooks/useEnableBankingStatus.ts(+33 -0)📝
packages/desktop-client/src/modals/modalsSlice.ts(+23 -0)📝
packages/loot-core/src/server/accounts/app.ts(+210 -1)📝
packages/loot-core/src/server/accounts/sync.ts(+47 -0)📝
packages/loot-core/src/server/db/types/index.ts(+1 -1)📝
packages/loot-core/src/server/server-config.ts(+2 -0)📝
packages/loot-core/src/shared/platform.ts(+11 -4)📝
packages/loot-core/src/types/models/account.ts(+5 -1)📝
packages/loot-core/src/types/models/bank-sync.ts(+5 -1)...and 9 more files
📄 Description
Description
This pull request introduces Enable Banking as a new bank synchronization provider for Actual Budget. This acts as an alternative to SimpleFIN and GoCardless, giving users in supported European regions another option for linking their financial institutions seamlessly.
Please be aware that this is a duplicate of https://github.com/actualbudget/actual/pull/5570, but as the other PR is open for quite a while and the proposed changes are not ready for a merge and kind of a mess, I decided to try how far I get with Github copilot when starting from fresh.
I am totally fine if you decide to to work further on the other PR. I just wanted to start using actual and wanted to use the bank sync so badly :)
Key Features & Changes
Core Integration: Added the app-enablebanking service into the sync server to handle communication with the Enable Banking API (fetching banks, sessions, balances, and transactions).
UI & Modals:
Updated CreateAccountModal to include Enable Banking as an option.
Added EnableBankingInitialiseModal and EnableBankingExternalMsgModal to handle bank selection and authorization instructions.
Extracted external API errors into scrollable, user-selectable text boxes making it easier for users to report or troubleshoot routing issues.
OAuth Callback Flow:
Implemented EnableBankingCallbackPage using a popup window and postMessage architecture to cleanly return the authorization code back to the main app without navigating away from Actual.
Transaction & Sync Mapping:
Properly mapped API responses into Actual's format: fetching ISO20022 specific balance types (XPCD, CLBD, CLAV, ITAV), capturing creditor/debtor names precisely, filtering out pending (PDNG) transactions, and correctly negating debit (DBIT) transactions.
Localization:
Wrapped static UI strings inside components following the project's i18n requirements.
Testing:
Added extensive unit tests (enablebanking-service.spec.ts) to validate the new service, as well as a GitHub Action workflow routine (docker-test-build.yml) for the test docker build.
Related issue(s)
https://github.com/actualbudget/actual/pull/5570
https://github.com/actualbudget/actual/issues/5505
Testing
I did test the complete flow with two german banks including importing new transactions from them.
If wanted I could also add a short documentation.
Checklist
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
src/components/modals/EnableBankingExternalMsgModal.tsxsrc/components/modals/EnableBankingInitialiseModal.tsxsrc/components/EnableBankingCallbackPage.tsxsrc/hooks/useEnableBankingStatus.tshome/runner/work/actual/actual/packages/loot-core/src/shared/platform.tssrc/components/modals/CreateAccountModal.tsxsrc/components/App.tsxsrc/accounts/mutations.tssrc/components/Modals.tsxsrc/components/modals/SelectLinkedAccountsModal.tsxsrc/components/banksync/index.tsxsrc/components/mobile/banksync/MobileBankSyncPage.tsxsrc/components/util/localeToCountry.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/shared/platform.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/server-config.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
Changeset
src/shared/platform.tssrc/server/accounts/app.tssrc/server/server-config.tssrc/server/accounts/sync.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.