github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2115] [MERGED] ESLint no-default-exports 1 #4126

New Issue
Closed
opened 2026-02-28 20:51:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:51:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2115
Author: @joel-jeremy
Created: 12/22/2023
Status: ✅ Merged
Merged: 1/6/2024
Merged by: @joel-jeremy

Base: master ← Head: eslint-no-default-imports

📝 Commits (4)

📊 Changes

68 files changed (+161 additions, -110 deletions)

View changed files

📝 .eslintrc.js (+48 -0)
📝 packages/api/app/query.js (+1 -1)
📝 packages/api/methods.js (+1 -1)
📝 packages/desktop-client/src/components/AnimatedRefresh.tsx (+1 -1)
📝 packages/desktop-client/src/components/App.tsx (+12 -14)
📝 packages/desktop-client/src/components/AppBackground.tsx (+5 -4)
📝 packages/desktop-client/src/components/Background.tsx (+1 -1)
📝 packages/desktop-client/src/components/BankSyncStatus.tsx (+2 -2)
📝 packages/desktop-client/src/components/DevelopmentTopBar.tsx (+1 -1)
📝 packages/desktop-client/src/components/FatalError.tsx (+1 -3)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+9 -9)
📝 packages/desktop-client/src/components/FixedSizeList.tsx (+1 -1)
📝 packages/desktop-client/src/components/GlobalKeys.ts (+1 -1)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+1 -1)
📝 packages/desktop-client/src/components/ManageRules.tsx (+1 -1)
📝 packages/desktop-client/src/components/ManageRulesPage.tsx (+1 -1)
📝 packages/desktop-client/src/components/MobileBackButton.tsx (+1 -1)
📝 packages/desktop-client/src/components/MobileWebMessage.tsx (+1 -1)
📝 packages/desktop-client/src/components/Modals.tsx (+1 -1)
📝 packages/desktop-client/src/components/Notes.tsx (+1 -1)

...and 48 more files

📄 Description

I've been encountering lots of flaky behavior in VSCode lately related to default imports. Navigating to default exports doesn't work most of the time and it makes it hard to focus on the change being worked on. Using default exports is generally a bad idea especially when it comes to IDE/developer experience that's why I'd like to propose implementing an ESLint to prevent usage of default exports.

Like the other recently implemented ESLint rules, I will be making the changes in batches for easier review.

https://basarat.gitbook.io/typescript/main-1/defaultisbad

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2115 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 12/22/2023 **Status:** ✅ Merged **Merged:** 1/6/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `eslint-no-default-imports` --- ### 📝 Commits (4) - [`d9d7431`](https://github.com/actualbudget/actual/commit/d9d743146b3a8efa658d505a79e789f3891361f8) ESLint no-default-imports part 1 - [`2b484c1`](https://github.com/actualbudget/actual/commit/2b484c1bb91f3b2f77e698b5a7861813785b6243) Release notes - [`5778f39`](https://github.com/actualbudget/actual/commit/5778f397616dc867bcd7391f8b2a8ef9a6e2acf3) Remove Notes.tsx default export - [`b752721`](https://github.com/actualbudget/actual/commit/b7527210e053d2ca6f6d1053f9cd378c9ede8948) Fix Notes imports ### 📊 Changes **68 files changed** (+161 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+48 -0) 📝 `packages/api/app/query.js` (+1 -1) 📝 `packages/api/methods.js` (+1 -1) 📝 `packages/desktop-client/src/components/AnimatedRefresh.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/App.tsx` (+12 -14) 📝 `packages/desktop-client/src/components/AppBackground.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/Background.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/BankSyncStatus.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/DevelopmentTopBar.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/FatalError.tsx` (+1 -3) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+9 -9) 📝 `packages/desktop-client/src/components/FixedSizeList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/GlobalKeys.ts` (+1 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/ManageRulesPage.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/MobileBackButton.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/MobileWebMessage.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Modals.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Notes.tsx` (+1 -1) _...and 48 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> I've been encountering lots of flaky behavior in VSCode lately related to default imports. Navigating to default exports doesn't work most of the time and it makes it hard to focus on the change being worked on. Using default exports is generally a bad idea especially when it comes to IDE/developer experience that's why I'd like to propose implementing an ESLint to prevent usage of default exports. Like the other recently implemented ESLint rules, I will be making the changes in batches for easier review. https://basarat.gitbook.io/typescript/main-1/defaultisbad --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:51:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?