github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6931] [MERGED] Address feedback on adding default data to usePayees #41257

New Issue
Closed
opened 2026-04-23 14:03:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 14:03:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6931
Author: @Copilot
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @joel-jeremy

Base: react-query-payees ← Head: copilot/sub-pr-6880

📝 Commits (2)

  • acadee2 Initial plan
  • 3c4f0ff Add default data to usePayees usages using inline destructuring

📊 Changes

17 files changed (+22 additions, -21 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/payees/MobilePayeeEditPage.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/payees/MobilePayeesPage.tsx (+2 -2)
📝 packages/desktop-client/src/components/mobile/schedules/MobileSchedulesPage.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/PayeeAutocompleteModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/payees/ManagePayeesWithData.tsx (+5 -4)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx (+1 -1)
📝 packages/desktop-client/src/components/rules/ScheduleValue.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts (+1 -1)
📝 packages/desktop-client/src/hooks/useDisplayPayee.tsx (+1 -1)
📝 packages/desktop-client/src/payees/queries.ts (+1 -1)

📄 Description

  • Add fallback using inline destructuring to usePayees usage in PayeeAutocompleteModal.tsx
  • Add fallback using inline destructuring to usePayees usage in PayeeAutocomplete.tsx
  • Add fallback using inline destructuring to usePayees usage in ManagePayeesWithData.tsx
  • Add fallback using inline destructuring to usePayees usage in MergeUnusedPayeesModal.tsx
  • Add fallback using inline destructuring to usePayees usage in MobilePayeesPage.tsx
  • Add fallback using inline destructuring to usePayees usage in MobilePayeeEditPage.tsx
  • Add fallback using inline destructuring to usePayees usage in TransactionEdit.tsx
  • Add fallback using inline destructuring to usePayees usage in TransactionList.tsx
  • Add fallback using inline destructuring to usePayees usage in Calendar.tsx
  • Add fallback using inline destructuring to usePayees usage in CustomReport.tsx
  • Add fallback using inline destructuring to usePayees usage in CustomReportListCards.tsx
  • Add fallback using inline destructuring to usePayees usage in useAccountPreviewTransactions.ts
  • Add fallback using inline destructuring to usePayeesById usage in ScheduleValue.tsx
  • Add fallback using inline destructuring to usePayees usage in MobileSchedulesPage.tsx
  • Add fallback using inline destructuring to usePayees usage in Account.tsx
  • Add fallback using inline destructuring to usePayeesById usage in useDisplayPayee.tsx
  • Fix getPayeesById to handle undefined payees in queries.ts
  • Run typecheck to validate changes
  • Run linter to ensure code quality
  • Request code review
  • Run CodeQL security check

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6931 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `react-query-payees` ← **Head:** `copilot/sub-pr-6880` --- ### 📝 Commits (2) - [`acadee2`](https://github.com/actualbudget/actual/commit/acadee2a5ca299bcf190ee6c7cd4aedfc138972f) Initial plan - [`3c4f0ff`](https://github.com/actualbudget/actual/commit/3c4f0fff588d3671dd106101a36a8f6bbb836f1e) Add default data to usePayees usages using inline destructuring ### 📊 Changes **17 files changed** (+22 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/payees/MobilePayeeEditPage.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/payees/MobilePayeesPage.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/mobile/schedules/MobileSchedulesPage.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/MergeUnusedPayeesModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/PayeeAutocompleteModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/payees/ManagePayeesWithData.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/rules/ScheduleValue.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useAccountPreviewTransactions.ts` (+1 -1) 📝 `packages/desktop-client/src/hooks/useDisplayPayee.tsx` (+1 -1) 📝 `packages/desktop-client/src/payees/queries.ts` (+1 -1) </details> ### 📄 Description - [x] Add fallback using inline destructuring to usePayees usage in PayeeAutocompleteModal.tsx - [x] Add fallback using inline destructuring to usePayees usage in PayeeAutocomplete.tsx - [x] Add fallback using inline destructuring to usePayees usage in ManagePayeesWithData.tsx - [x] Add fallback using inline destructuring to usePayees usage in MergeUnusedPayeesModal.tsx - [x] Add fallback using inline destructuring to usePayees usage in MobilePayeesPage.tsx - [x] Add fallback using inline destructuring to usePayees usage in MobilePayeeEditPage.tsx - [x] Add fallback using inline destructuring to usePayees usage in TransactionEdit.tsx - [x] Add fallback using inline destructuring to usePayees usage in TransactionList.tsx - [x] Add fallback using inline destructuring to usePayees usage in Calendar.tsx - [x] Add fallback using inline destructuring to usePayees usage in CustomReport.tsx - [x] Add fallback using inline destructuring to usePayees usage in CustomReportListCards.tsx - [x] Add fallback using inline destructuring to usePayees usage in useAccountPreviewTransactions.ts - [x] Add fallback using inline destructuring to usePayeesById usage in ScheduleValue.tsx - [x] Add fallback using inline destructuring to usePayees usage in MobileSchedulesPage.tsx - [x] Add fallback using inline destructuring to usePayees usage in Account.tsx - [x] Add fallback using inline destructuring to usePayeesById usage in useDisplayPayee.tsx - [x] Fix getPayeesById to handle undefined payees in queries.ts - [x] Run typecheck to validate changes - [x] Run linter to ensure code quality - [x] Request code review - [x] Run CodeQL security check <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/actualbudget/actual/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:03:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?