github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6866] [MERGED] Apply tag colors to YNAB flag tags #41216

New Issue
Closed
opened 2026-04-23 14:01:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 14:01:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6866
Author: @StephenBrown2
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/5/2026
Merged by: @youngcw

Base: master ← Head: push-wyqsxkknslnl

📝 Commits (10+)

  • d0355c7 Apply tag colors to match YNAB flags
  • dfdfa4c Update tag colors to match YNAB, add description on import
  • 56626a1 Tighten types
  • 5eb22d8 Use custom colors
  • 20f2854 Use Actual palette equivalents for tag colors
  • 121df95 Nitpick fixes
  • 24ee126 Fix nitpick 'fix'
  • fccf395 Handle YNAB flag tag conflicts
  • 32a8dd8 Handle YNAB flag tag conflicts without creating separate color tags
  • 9f0adb6 Simplify

📊 Changes

4 files changed (+493 additions, -361 deletions)

View changed files

📝 packages/desktop-client/e2e/data/ynab5-demo-budget.json (+13 -7)
📝 packages/loot-core/src/server/importers/ynab5-types.ts (+4 -4)
📝 packages/loot-core/src/server/importers/ynab5.ts (+470 -350)
➕ upcoming-release-notes/6866.md (+6 -0)

📄 Description

I wanted to enhance tag creation for nYNAB imports since I noticed that Actual and YNAB both support coloring tags/flags, and didn't get it in before @youngcw merged #6844

This PR:

  • maps nYNAB flag colors to Actual tag colors during import and creates tags up front
  • keeps flag name/hashtag handling consistent for imported notes
  • updates demo nYNAB budget data for flag coverage

Screenshots

YNAB's Flag application popup:
Screenshot_2026-02-05_09-01-46

YNAB Flag editing popup:
Screenshot_2026-02-05_09-07-23

YNAB Flag naming:
Screenshot_2026-02-05_09-07-58

Actual imported tags (Palette colors):
Screenshot_2026-02-05_12-29-29

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 14.55 MB 0%
loot-core 1 5.85 MB → 5.86 MB (+3.03 kB) +0.05%
api 1 4.39 MB → 4.39 MB (+2.67 kB) +0.06%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 14.55 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.31 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 178.39 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 164.16 kB 0%
static/js/es.js 173.83 kB 0%
static/js/fr.js 179.62 kB 0%
static/js/it.js 171.44 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 106.65 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 146.51 kB 0%
static/js/ru.js 106.97 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.11 MB 0%
static/js/narrow.js 640.46 kB 0%
static/js/TransactionList.js 105.97 kB 0%
static/js/wide.js 160.07 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.85 MB → 5.86 MB (+3.03 kB) +0.05%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts 📈 +3.03 kB (+12.08%) 25.09 kB → 28.13 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.CiaHZEop.js 0 B → 5.86 MB (+5.86 MB) -

Removed

Asset File Size % Changed
kcab.worker.C30497Fh.js 5.85 MB → 0 B (-5.85 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
1 4.39 MB → 4.39 MB (+2.67 kB) +0.06%
Changeset
File Δ Size
src/server/importers/ynab5.ts 📈 +2.67 kB (+11.90%) 22.47 kB → 25.14 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
bundle.api.js 4.39 MB → 4.39 MB (+2.67 kB) +0.06%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6866 **Author:** [@StephenBrown2](https://github.com/StephenBrown2) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/5/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `push-wyqsxkknslnl` --- ### 📝 Commits (10+) - [`d0355c7`](https://github.com/actualbudget/actual/commit/d0355c7c6f00ae28aee81d854109fd2eb1ef1c3f) Apply tag colors to match YNAB flags - [`dfdfa4c`](https://github.com/actualbudget/actual/commit/dfdfa4c00d1048917725ce358e57e011551b9847) Update tag colors to match YNAB, add description on import - [`56626a1`](https://github.com/actualbudget/actual/commit/56626a199241abd5f9823c9059461a99f08308f2) Tighten types - [`5eb22d8`](https://github.com/actualbudget/actual/commit/5eb22d8669e5bad6fdc43591cae0b3716adfbc20) Use custom colors - [`20f2854`](https://github.com/actualbudget/actual/commit/20f2854c906b63f97e4cfd0eadbedc65c550a6b8) Use Actual palette equivalents for tag colors - [`121df95`](https://github.com/actualbudget/actual/commit/121df958be6fb803c2fe11c930ea613784cc43d8) Nitpick fixes - [`24ee126`](https://github.com/actualbudget/actual/commit/24ee1260c32d849c88200c9616bad6a99181075b) Fix nitpick 'fix' - [`fccf395`](https://github.com/actualbudget/actual/commit/fccf3953719096a64e30fc490d2ed2d50cd5981e) Handle YNAB flag tag conflicts - [`32a8dd8`](https://github.com/actualbudget/actual/commit/32a8dd8588df35b66cb30cf24ce756c263d255a5) Handle YNAB flag tag conflicts without creating separate color tags - [`9f0adb6`](https://github.com/actualbudget/actual/commit/9f0adb69dd9270e27056d7380698d2d7cfd6abee) Simplify ### 📊 Changes **4 files changed** (+493 additions, -361 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/data/ynab5-demo-budget.json` (+13 -7) 📝 `packages/loot-core/src/server/importers/ynab5-types.ts` (+4 -4) 📝 `packages/loot-core/src/server/importers/ynab5.ts` (+470 -350) ➕ `upcoming-release-notes/6866.md` (+6 -0) </details> ### 📄 Description I wanted to enhance tag creation for nYNAB imports since I noticed that Actual and YNAB both support coloring tags/flags, and didn't get it in before @youngcw merged #6844 This PR: - maps nYNAB flag colors to Actual tag colors during import and creates tags up front - keeps flag name/hashtag handling consistent for imported notes - updates demo nYNAB budget data for flag coverage ### Screenshots YNAB's Flag application popup: <img width="250" height="356" alt="Screenshot_2026-02-05_09-01-46" src="https://github.com/user-attachments/assets/060fc3ba-80c0-4606-a6ad-10dcd21f511a" /> YNAB Flag editing popup: <img width="426" height="441" alt="Screenshot_2026-02-05_09-07-23" src="https://github.com/user-attachments/assets/fe8fc61e-f6f4-4e6a-9d0b-f302492a504a" /> YNAB Flag naming: <img width="426" height="441" alt="Screenshot_2026-02-05_09-07-58" src="https://github.com/user-attachments/assets/6799499c-4c39-4d45-a0f2-44868d1e33c1" /> Actual imported tags (Palette colors): <img width="430" height="350" alt="Screenshot_2026-02-05_12-29-29" src="https://github.com/user-attachments/assets/6f03ad3f-e1c6-452f-9012-74b324e2bf6c" /> <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 14.55 MB | 0% loot-core | 1 | 5.85 MB → 5.86 MB (+3.03 kB) | +0.05% api | 1 | 4.39 MB → 4.39 MB (+2.67 kB) | +0.06% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 14.55 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.31 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 178.39 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 164.16 kB | 0% static/js/es.js | 173.83 kB | 0% static/js/fr.js | 179.62 kB | 0% static/js/it.js | 171.44 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 106.65 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 146.51 kB | 0% static/js/ru.js | 106.97 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.11 MB | 0% static/js/narrow.js | 640.46 kB | 0% static/js/TransactionList.js | 105.97 kB | 0% static/js/wide.js | 160.07 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.85 MB → 5.86 MB (+3.03 kB) | +0.05% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts` | 📈 +3.03 kB (+12.08%) | 25.09 kB → 28.13 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CiaHZEop.js | 0 B → 5.86 MB (+5.86 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C30497Fh.js | 5.85 MB → 0 B (-5.85 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.39 MB → 4.39 MB (+2.67 kB) | +0.06% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/server/importers/ynab5.ts` | 📈 +2.67 kB (+11.90%) | 22.47 kB → 25.14 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.39 MB → 4.39 MB (+2.67 kB) | +0.06% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:01:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?