[PR #6858] [MERGED] [FIX] Update DesktopLinkedNotes so links stay inline #41209

Closed
opened 2026-04-23 14:00:44 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6858
Author: @Juulz
Created: 2/4/2026
Status: Merged
Merged: 2/10/2026
Merged by: @youngcw

Base: masterHead: notes-link-wrap


📝 Commits (10+)

  • 8ad1bfa Update DesktopLinkedNotes.tsx
  • 379bde4 Update DesktopLinkedNotes.tsx
  • 273c7fe Update DesktopLinkedNotes so links stay inline
  • c4554fd Update TransactionsTable.tsx
  • 58928e8 [autofix.ci] apply automated fixes
  • b42b200 Update DesktopLinkedNotes.tsx
  • 7de45f4 Update TransactionsTable.tsx
  • c340227 Update DesktopLinkedNotes.tsx
  • f5aed8f Update NotesTagFormatter.tsx trial
  • 24ce681 Update DesktopLinkedNotes.tsx

📊 Changes

2 files changed (+25 additions, -11 deletions)

View changed files

📝 packages/desktop-client/src/notes/DesktopLinkedNotes.tsx (+19 -11)
upcoming-release-notes/6858.md (+6 -0)

📄 Description

Use link.tsx instead of button or text or span. Fixes #6842

Before
Screenshot 2026-02-04 100123

After
Screenshot 2026-02-04 154539


Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.48 MB → 14.48 MB (+222 B) +0.00%
loot-core 1 5.86 MB 0%
api 1 4.39 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.48 MB → 14.48 MB (+222 B) +0.00%
Changeset
File Δ Size
src/notes/DesktopLinkedNotes.tsx 📈 +222 B (+13.16%) 1.65 kB → 1.86 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 9.33 MB → 9.33 MB (+222 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 178.39 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 164.55 kB 0%
static/js/es.js 173.83 kB 0%
static/js/fr.js 179.62 kB 0%
static/js/it.js 171.44 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 106.65 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 154.57 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.12 MB 0%
static/js/narrow.js 640.46 kB 0%
static/js/TransactionList.js 105.97 kB 0%
static/js/wide.js 160.07 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.86 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BmGAOUic.js 5.86 MB 0%

api

Total

Files count Total bundle size % Changed
1 4.39 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
bundle.api.js 4.39 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6858 **Author:** [@Juulz](https://github.com/Juulz) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `notes-link-wrap` --- ### 📝 Commits (10+) - [`8ad1bfa`](https://github.com/actualbudget/actual/commit/8ad1bfa872e6c58ea4c217fc130a41b2f974f41f) Update DesktopLinkedNotes.tsx - [`379bde4`](https://github.com/actualbudget/actual/commit/379bde4a4df7db110ddd3f14fc9d8dddb48f3910) Update DesktopLinkedNotes.tsx - [`273c7fe`](https://github.com/actualbudget/actual/commit/273c7fe27d74b308956f2e5b97bcc0e8f11eab08) Update DesktopLinkedNotes so links stay inline - [`c4554fd`](https://github.com/actualbudget/actual/commit/c4554fd39b54f75b9a2d178eb69ac03a6b0ba968) Update TransactionsTable.tsx - [`58928e8`](https://github.com/actualbudget/actual/commit/58928e86e83764f4f38bf374c328bf22139e7e58) [autofix.ci] apply automated fixes - [`b42b200`](https://github.com/actualbudget/actual/commit/b42b2006df84d367a786c02ff14e78e50b087eed) Update DesktopLinkedNotes.tsx - [`7de45f4`](https://github.com/actualbudget/actual/commit/7de45f4ead303991ccc0fe5dd6a0fb7e3aff73ae) Update TransactionsTable.tsx - [`c340227`](https://github.com/actualbudget/actual/commit/c340227a90488bfb5b253d623c62f0eae166c179) Update DesktopLinkedNotes.tsx - [`f5aed8f`](https://github.com/actualbudget/actual/commit/f5aed8fc12c2e1bfd87aa4ca7cec40df70156c45) Update NotesTagFormatter.tsx trial - [`24ce681`](https://github.com/actualbudget/actual/commit/24ce681e9b89766a8820af00ed54b75d38eddbad) Update DesktopLinkedNotes.tsx ### 📊 Changes **2 files changed** (+25 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/notes/DesktopLinkedNotes.tsx` (+19 -11) ➕ `upcoming-release-notes/6858.md` (+6 -0) </details> ### 📄 Description Use link.tsx instead of button or text or span. Fixes #6842 Before <img width="556" height="96" alt="Screenshot 2026-02-04 100123" src="https://github.com/user-attachments/assets/c5049df5-288f-4256-941f-bc8380fbe123" /> After <img width="591" height="86" alt="Screenshot 2026-02-04 154539" src="https://github.com/user-attachments/assets/85989744-1139-4095-bd0c-8e9479401b37" /> <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.48 MB → 14.48 MB (+222 B) | +0.00% loot-core | 1 | 5.86 MB | 0% api | 1 | 4.39 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.48 MB → 14.48 MB (+222 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/notes/DesktopLinkedNotes.tsx` | 📈 +222 B (+13.16%) | 1.65 kB → 1.86 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.33 MB → 9.33 MB (+222 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 178.39 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 164.55 kB | 0% static/js/es.js | 173.83 kB | 0% static/js/fr.js | 179.62 kB | 0% static/js/it.js | 171.44 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 106.65 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 154.57 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.12 MB | 0% static/js/narrow.js | 640.46 kB | 0% static/js/TransactionList.js | 105.97 kB | 0% static/js/wide.js | 160.07 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.86 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BmGAOUic.js | 5.86 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.39 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.39 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 14:00:44 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41209