github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6680] [MERGED] lint: add perfectionist/sort-named-imports rule #41098

New Issue
Closed
opened 2026-04-23 13:54:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:54:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6680
Author: @MatissJanis
Created: 1/16/2026
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @matt-fidd

Base: master ← Head: matiss/update-components

📝 Commits (2)

  • 23e0a2c Apply import sorting with perfectionist/sort-named-imports rule
  • 96eb891 Add release notes for linting updates on named imports

📊 Changes

409 files changed (+836 additions, -824 deletions)

View changed files

📝 .oxlintrc.json (+6 -0)
📝 packages/ci-actions/src/versions/get-next-package-version.test.js (+1 -1)
📝 packages/component-library/src/AlignedText.tsx (+1 -1)
📝 packages/component-library/src/Button.tsx (+1 -1)
📝 packages/component-library/src/Card.tsx (+1 -1)
📝 packages/component-library/src/ColorPicker.tsx (+5 -5)
📝 packages/component-library/src/FormError.tsx (+1 -1)
📝 packages/component-library/src/InitialFocus.ts (+2 -2)
📝 packages/component-library/src/Input.tsx (+1 -1)
📝 packages/component-library/src/Label.tsx (+1 -1)
📝 packages/component-library/src/Menu.tsx (+4 -4)
📝 packages/component-library/src/Popover.tsx (+1 -1)
📝 packages/component-library/src/Text.tsx (+2 -2)
📝 packages/component-library/src/icons/Loading.tsx (+1 -1)
📝 packages/desktop-client/e2e/page-models/edit-rule-modal.ts (+1 -1)
📝 packages/desktop-client/e2e/page-models/mobile-balance-menu-modal.ts (+1 -1)
📝 packages/desktop-client/e2e/page-models/schedule-edit-modal.ts (+1 -1)
📝 packages/desktop-client/src/accounts/accountsSlice.ts (+4 -4)
📝 packages/desktop-client/src/components/AppBackground.tsx (+1 -1)
📝 packages/desktop-client/src/components/BankSyncStatus.tsx (+1 -1)

...and 80 more files

📄 Description

Quite a big PR (apologies).

But the jist of it is.. we are now sorting named imports. The auto-fixer for this works too so people should not need to do this manually. It happens auto-magically via pre-commit hook.

We go from..

import {
   type FC,
   useState,
   useEffect,
   type ComponentProps,
} from 'react';

to

import {
   useEffect,
   useState,
   type ComponentProps,
   type FC,
} from 'react';

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6680 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `matiss/update-components` --- ### 📝 Commits (2) - [`23e0a2c`](https://github.com/actualbudget/actual/commit/23e0a2c06d063441eeab16df4dc078c46ef258b4) Apply import sorting with perfectionist/sort-named-imports rule - [`96eb891`](https://github.com/actualbudget/actual/commit/96eb8911cb77ea3259daf881ed090ca1ab5c50ce) Add release notes for linting updates on named imports ### 📊 Changes **409 files changed** (+836 additions, -824 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+6 -0) 📝 `packages/ci-actions/src/versions/get-next-package-version.test.js` (+1 -1) 📝 `packages/component-library/src/AlignedText.tsx` (+1 -1) 📝 `packages/component-library/src/Button.tsx` (+1 -1) 📝 `packages/component-library/src/Card.tsx` (+1 -1) 📝 `packages/component-library/src/ColorPicker.tsx` (+5 -5) 📝 `packages/component-library/src/FormError.tsx` (+1 -1) 📝 `packages/component-library/src/InitialFocus.ts` (+2 -2) 📝 `packages/component-library/src/Input.tsx` (+1 -1) 📝 `packages/component-library/src/Label.tsx` (+1 -1) 📝 `packages/component-library/src/Menu.tsx` (+4 -4) 📝 `packages/component-library/src/Popover.tsx` (+1 -1) 📝 `packages/component-library/src/Text.tsx` (+2 -2) 📝 `packages/component-library/src/icons/Loading.tsx` (+1 -1) 📝 `packages/desktop-client/e2e/page-models/edit-rule-modal.ts` (+1 -1) 📝 `packages/desktop-client/e2e/page-models/mobile-balance-menu-modal.ts` (+1 -1) 📝 `packages/desktop-client/e2e/page-models/schedule-edit-modal.ts` (+1 -1) 📝 `packages/desktop-client/src/accounts/accountsSlice.ts` (+4 -4) 📝 `packages/desktop-client/src/components/AppBackground.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/BankSyncStatus.tsx` (+1 -1) _...and 80 more files_ </details> ### 📄 Description Quite a big PR (apologies). But the jist of it is.. we are now sorting named imports. The auto-fixer for this works too so people should not need to do this manually. It happens auto-magically via pre-commit hook. We go from.. ``` import { type FC, useState, useEffect, type ComponentProps, } from 'react'; ``` to ``` import { useEffect, useState, type ComponentProps, type FC, } from 'react'; ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:54:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?