github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6645] [MERGED] fix HyperFormula custom functions and add FIXED formula #41078

New Issue
Closed
opened 2026-04-23 13:53:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:53:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6645
Author: @matt-fidd
Created: 1/14/2026
Status: ✅ Merged
Merged: 1/19/2026
Merged by: @matt-fidd

Base: master ← Head: fixed-formula

📝 Commits (4)

📊 Changes

7 files changed (+67 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/formula/codeMirror-excelLanguage.tsx (+1 -0)
📝 packages/desktop-client/src/components/formula/queryModeFunctions.ts (+8 -0)
📝 packages/desktop-client/src/components/formula/transactionModeFunctions.ts (+8 -0)
📝 packages/desktop-client/src/hooks/useFormulaExecution.ts (+3 -1)
📝 packages/loot-core/src/server/rules/action.ts (+12 -3)
📝 packages/loot-core/src/server/rules/customFunctions.ts (+29 -0)
➕ upcoming-release-notes/6645.md (+6 -0)

📄 Description

This PR is double barrelled, when adding FIXED I found that the custom functions weren't working at all because there were no translations defined. I cleaned that up and forced the language to US (default is enGB) first. They're actually equivalent but it makes sense to keep ourselves consistent and use US

https://github.com/handsontable/hyperformula/blob/master/src/i18n/languages/enUS.ts

Error before this PR:

index.ts:26 Formula execution error: Error: Formula error: Function name INTEGER_TO_AMOUNT not recognized.
    at Action.executeFormulaSync (action.ts:307:15)
    at Action.exec (action.ts:89:33)
    at rule.ts:16:36
    at Array.forEach (<anonymous>)
    at execNonSplitActions (rule.ts:16:11)
    at execActions (rule.ts:98:26)
    at transaction-rules.ts:706:31
    at Array.flatMap (<anonymous>)
    at applyActions (transaction-rules.ts:705:40)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6645 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 1/14/2026 **Status:** ✅ Merged **Merged:** 1/19/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fixed-formula` --- ### 📝 Commits (4) - [`aa6f209`](https://github.com/actualbudget/actual/commit/aa6f2095c63385d8da51277f01fe275cc7291045) fix custom HyperFormula functions - [`140522a`](https://github.com/actualbudget/actual/commit/140522a42b866d7e681091dfabe002091ca14c24) add FIXED formula - [`c1824d6`](https://github.com/actualbudget/actual/commit/c1824d6b892e07934452911fdf701b73566ba425) note - [`8c60a7e`](https://github.com/actualbudget/actual/commit/8c60a7e929ded88ba6525b0b972f084cdbab7d4c) [autofix.ci] apply automated fixes ### 📊 Changes **7 files changed** (+67 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/formula/codeMirror-excelLanguage.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/formula/queryModeFunctions.ts` (+8 -0) 📝 `packages/desktop-client/src/components/formula/transactionModeFunctions.ts` (+8 -0) 📝 `packages/desktop-client/src/hooks/useFormulaExecution.ts` (+3 -1) 📝 `packages/loot-core/src/server/rules/action.ts` (+12 -3) 📝 `packages/loot-core/src/server/rules/customFunctions.ts` (+29 -0) ➕ `upcoming-release-notes/6645.md` (+6 -0) </details> ### 📄 Description This PR is double barrelled, when adding `FIXED` I found that the custom functions weren't working at all because there were no translations defined. I cleaned that up and forced the language to US (default is enGB) first. They're actually equivalent but it makes sense to keep ourselves consistent and use US https://github.com/handsontable/hyperformula/blob/master/src/i18n/languages/enUS.ts Error before this PR: ``` index.ts:26 Formula execution error: Error: Formula error: Function name INTEGER_TO_AMOUNT not recognized. at Action.executeFormulaSync (action.ts:307:15) at Action.exec (action.ts:89:33) at rule.ts:16:36 at Array.forEach (<anonymous>) at execNonSplitActions (rule.ts:16:11) at execActions (rule.ts:98:26) at transaction-rules.ts:706:31 at Array.flatMap (<anonymous>) at applyActions (transaction-rules.ts:705:40) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:53:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41078
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?