github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6636] [MERGED] Update linting rules and replace @ts-ignore with @ts-expect-error #41073

New Issue
Closed
opened 2026-04-23 13:52:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:52:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6636
Author: @MatissJanis
Created: 1/12/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @MatissJanis

Base: master ← Head: matiss/linting-improvements

📝 Commits (6)

  • d8e4b10 Update linting rules and replace @ts-ignore with @ts-expect-error
  • e8f9521 Add release notes for PR #6636
  • d9ee6b3 Fix TypeScript linting issue by adding @ts-ignore for electron types in server start message
  • c04f797 Merge branch 'matiss/linting-improvements' of github.com:actualbudget/actual into matiss/linting-improvements
  • 3275db1 Merge branch 'master' into matiss/linting-improvements
  • cea3d10 Change category to Maintenance and update linting rules

📊 Changes

13 files changed (+22 additions, -20 deletions)

View changed files

📝 .oxlintrc.json (+3 -9)
📝 packages/api/index.ts (+1 -0)
📝 packages/api/utils.ts (+1 -0)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+1 -1)
📝 packages/desktop-client/src/components/filters/PayeeFilter.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionList.tsx (+2 -2)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+1 -1)
📝 packages/eslint-plugin-actual/lib/rules/typography.js (+2 -1)
📝 packages/loot-core/src/server/budget/category-template-context.test.ts (+0 -1)
📝 packages/loot-core/src/server/polyfills.ts (+1 -2)
📝 packages/loot-core/src/shared/schedules.ts (+2 -2)
📝 packages/sync-server/src/app.ts (+1 -0)
➕ upcoming-release-notes/6636.md (+6 -0)

📄 Description

Changes

  • Updated oxlint configuration:

    • Removed TODO comments from config
    • Enabled rule with multi-line and consistent options
    • Simplified rule configuration

  • TypeScript improvements:

    • Replaced with throughout the codebase (better practice as it will error if the issue is fixed)
    • Added comments where needed for legitimate cases

  • Code formatting fixes:

    • Added missing curly braces in typography.js rule
    • Removed unnecessary comments that were no longer needed

This improves code quality and makes it easier to track type errors that need to be addressed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6636 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/12/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/linting-improvements` --- ### 📝 Commits (6) - [`d8e4b10`](https://github.com/actualbudget/actual/commit/d8e4b104dda49c83b3c5d2f63166d2d2a928c9e6) Update linting rules and replace @ts-ignore with @ts-expect-error - [`e8f9521`](https://github.com/actualbudget/actual/commit/e8f95214da0f6728a9dc08acef8a045dd0933e2d) Add release notes for PR #6636 - [`d9ee6b3`](https://github.com/actualbudget/actual/commit/d9ee6b323a1b181198b2a08d916d9b5dc30908f9) Fix TypeScript linting issue by adding @ts-ignore for electron types in server start message - [`c04f797`](https://github.com/actualbudget/actual/commit/c04f7974e56fa3aedde5e40ab7770ace8ed57411) Merge branch 'matiss/linting-improvements' of github.com:actualbudget/actual into matiss/linting-improvements - [`3275db1`](https://github.com/actualbudget/actual/commit/3275db1ebaf166eac2becb56faff50ab54c3d759) Merge branch 'master' into matiss/linting-improvements - [`cea3d10`](https://github.com/actualbudget/actual/commit/cea3d10c5dfad0a1d59258ecc934101d8b44ba02) Change category to Maintenance and update linting rules ### 📊 Changes **13 files changed** (+22 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+3 -9) 📝 `packages/api/index.ts` (+1 -0) 📝 `packages/api/utils.ts` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/filters/PayeeFilter.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionList.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+1 -1) 📝 `packages/eslint-plugin-actual/lib/rules/typography.js` (+2 -1) 📝 `packages/loot-core/src/server/budget/category-template-context.test.ts` (+0 -1) 📝 `packages/loot-core/src/server/polyfills.ts` (+1 -2) 📝 `packages/loot-core/src/shared/schedules.ts` (+2 -2) 📝 `packages/sync-server/src/app.ts` (+1 -0) ➕ `upcoming-release-notes/6636.md` (+6 -0) </details> ### 📄 Description ## Changes - **Updated oxlint configuration:** - Removed TODO comments from config - Enabled rule with multi-line and consistent options - Simplified rule configuration - **TypeScript improvements:** - Replaced with throughout the codebase (better practice as it will error if the issue is fixed) - Added comments where needed for legitimate cases - **Code formatting fixes:** - Added missing curly braces in typography.js rule - Removed unnecessary comments that were no longer needed This improves code quality and makes it easier to track type errors that need to be addressed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:52:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#41073
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?