[PR #6415] [CLOSED] Fix data table group row coloring when horizontally scrolled #40937

Closed
opened 2026-04-23 13:44:12 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6415
Author: @plsdev89
Created: 12/15/2025
Status: Closed

Base: masterHead: fix/6374-report-table-coloring


📝 Commits (6)

  • 3c1dca5 Fix report table group row coloring on horizontal scroll
  • ad80f44 Add release note for #6374
  • 61bad12 [autofix.ci] apply automated fixes
  • b3134b5 Rename release note to PR number
  • c90f9fe Merge branch 'master' into fix/6374-report-table-coloring
  • d719435 Update VRT screenshots

📊 Changes

32 files changed (+12 additions, -0 deletions)

View changed files

📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png (+0 -0)

...and 12 more files

📄 Description

Fixes #6374
Ensures list rows expand to max-content width so group-row background coloring renders correctly for columns that were initially off-screen.
Tests: yarn typecheck, yarn lint:fix


Note

Make report table list rows expand to max-content width so group-row background coloring remains correct when horizontally scrolled.

  • Reports UI:
    • In packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx, conditionally set list rows (isListRow) to minWidth: '100%' and width: 'max-content' on Row to maintain correct group-row background when horizontally scrolled.
  • Release Notes:
    • Add upcoming-release-notes/6415.md noting the bugfix for group row coloring during horizontal scroll.

Written by Cursor Bugbot for commit d71943516d. This will update automatically on new commits. Configure here.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6415 **Author:** [@plsdev89](https://github.com/plsdev89) **Created:** 12/15/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/6374-report-table-coloring` --- ### 📝 Commits (6) - [`3c1dca5`](https://github.com/actualbudget/actual/commit/3c1dca5f10730478c62d4f7ffd4046a997eb0c40) Fix report table group row coloring on horizontal scroll - [`ad80f44`](https://github.com/actualbudget/actual/commit/ad80f44fde948f34a2569a59a7d8c9407062acfe) Add release note for #6374 - [`61bad12`](https://github.com/actualbudget/actual/commit/61bad1256a3f9b892d45e5624c42683ffd9a6ccc) [autofix.ci] apply automated fixes - [`b3134b5`](https://github.com/actualbudget/actual/commit/b3134b51bedd15fa47abac84e435d356e790f305) Rename release note to PR number - [`c90f9fe`](https://github.com/actualbudget/actual/commit/c90f9fe0be9d4fdb46283f7843e0e05e35bd96dd) Merge branch 'master' into fix/6374-report-table-coloring - [`d719435`](https://github.com/actualbudget/actual/commit/d71943516d65a1cc314500dbf445216eda2600bb) Update VRT screenshots ### 📊 Changes **32 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png` (+0 -0) _...and 12 more files_ </details> ### 📄 Description Fixes #6374 Ensures list rows expand to max-content width so group-row background coloring renders correctly for columns that were initially off-screen. Tests: yarn typecheck, yarn lint:fix <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Make report table list rows expand to max-content width so group-row background coloring remains correct when horizontally scrolled. > > - **Reports UI**: > - In `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx`, conditionally set list rows (`isListRow`) to `minWidth: '100%'` and `width: 'max-content'` on `Row` to maintain correct group-row background when horizontally scrolled. > - **Release Notes**: > - Add `upcoming-release-notes/6415.md` noting the bugfix for group row coloring during horizontal scroll. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d71943516d65a1cc314500dbf445216eda2600bb. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:44:12 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40937