github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 04:49:45 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6371] [MERGED] Fix detection of crossover point for low expense months #40901

New Issue
Closed
opened 2026-04-23 13:42:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:42:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6371
Author: @jonner
Created: 12/11/2025
Status: ✅ Merged
Merged: 12/11/2025
Merged by: @youngcw

Base: master ← Head: crossover-low-expenses

📝 Commits (2)

  • 6674e84 Fix detection of crossover point for low expense months
  • 7203296 Update VRT screenshots

📊 Changes

3 files changed (+11 additions, -6 deletions)

View changed files

📝 packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Line-Graph-and-checks-the-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/crossover-spreadsheet.ts (+5 -6)
➕ upcoming-release-notes/6371.md (+6 -0)

📄 Description

Always compute the expense projection and calculate the crossover point based on the projection instead of individual historical expense data because otherwise a low expense month can incorrectly trigger a false crossover point detection.

See comment at https://github.com/actualbudget/actual/issues/6134#issuecomment-3608140098 for more information.

Note

Determine crossover only from projected expenses and always run projections, preventing false positives from low historical expense months.

  • Reports:
    • Update packages/desktop-client/src/components/reports/spreadsheets/crossover-spreadsheet.ts:
      • Stop detecting crossover in historical data; detect only via projected expenses/income.
      • Always execute projection by removing crossoverIndex gate in the projection block.
  • Release Notes:
    • Add upcoming-release-notes/6371.md noting the bugfix for incorrect crossover detection on low-expense months.

Written by Cursor Bugbot for commit 72032963a2. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6371 **Author:** [@jonner](https://github.com/jonner) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 12/11/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `crossover-low-expenses` --- ### 📝 Commits (2) - [`6674e84`](https://github.com/actualbudget/actual/commit/6674e846fba9366b6fb08c78f8290ca7c42abe2e) Fix detection of crossover point for low expense months - [`7203296`](https://github.com/actualbudget/actual/commit/72032963a22334594d397ed96034298a6fc55e1a) Update VRT screenshots ### 📊 Changes **3 files changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/reports.test.ts-snapshots/Reports-custom-reports-Switches-to-Line-Graph-and-checks-the-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/crossover-spreadsheet.ts` (+5 -6) ➕ `upcoming-release-notes/6371.md` (+6 -0) </details> ### 📄 Description Always compute the expense projection and calculate the crossover point based on the projection instead of individual historical expense data because otherwise a low expense month can incorrectly trigger a false crossover point detection. See comment at https://github.com/actualbudget/actual/issues/6134#issuecomment-3608140098 for more information. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Determine crossover only from projected expenses and always run projections, preventing false positives from low historical expense months. > > - **Reports**: > - Update `packages/desktop-client/src/components/reports/spreadsheets/crossover-spreadsheet.ts`: > - Stop detecting crossover in historical data; detect only via projected expenses/income. > - Always execute projection by removing `crossoverIndex` gate in the projection block. > - **Release Notes**: > - Add `upcoming-release-notes/6371.md` noting the bugfix for incorrect crossover detection on low-expense months. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 72032963a22334594d397ed96034298a6fc55e1a. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:42:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?