github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #6175] [MERGED] Fix rule edit page crashing #40803

New Issue
Closed
opened 2026-04-23 13:36:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:36:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6175
Author: @MatissJanis
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/19/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-schedule-type-safety

📝 Commits (6)

  • b56b050 Fix schedule type safety and remove ts-expect-error comments
  • f8ae092 Update RuleEditor to set default value as an empty string; refactor ScheduleEditForm to use 'repeats' instead of isRecurConfig; remove unused isRecurConfig function from schedules module.
  • a4faa05 Update VRT screenshots
  • 4da4fca Merge branch 'master' into matiss/fix-schedule-type-safety
  • 34437a9 Update VRT screenshots
  • ff53872 Merge branch 'master' into matiss/fix-schedule-type-safety

📊 Changes

5 files changed (+18 additions, -4 deletions)

View changed files

📝 packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/rules/RuleEditor.tsx (+1 -1)
📝 packages/loot-core/src/shared/schedules.ts (+10 -2)
📝 packages/loot-core/src/types/models/schedule.ts (+1 -1)
➕ upcoming-release-notes/6175.md (+6 -0)

📄 Description

Reproduction:

  1. Open rule edit page
  2. Click "+" to add more "actions"
  3. Keep clicking "+"
  4. Eventually the page will crash (on edge, but not here)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6175 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/19/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-schedule-type-safety` --- ### 📝 Commits (6) - [`b56b050`](https://github.com/actualbudget/actual/commit/b56b050af9edf3f98e78ff811f33efd437a6e54f) Fix schedule type safety and remove ts-expect-error comments - [`f8ae092`](https://github.com/actualbudget/actual/commit/f8ae092098a3dd47c60d4a8d7d4e582e57dcc8fd) Update RuleEditor to set default value as an empty string; refactor ScheduleEditForm to use 'repeats' instead of isRecurConfig; remove unused isRecurConfig function from schedules module. - [`a4faa05`](https://github.com/actualbudget/actual/commit/a4faa0576906010dd50a64e6cc21b9750dcc768f) Update VRT screenshots - [`4da4fca`](https://github.com/actualbudget/actual/commit/4da4fca3802680943433b8d0943d65a30e7f92ab) Merge branch 'master' into matiss/fix-schedule-type-safety - [`34437a9`](https://github.com/actualbudget/actual/commit/34437a94fc8b224822340c5cd9e8679507d7e435) Update VRT screenshots - [`ff53872`](https://github.com/actualbudget/actual/commit/ff53872d6fe858361960687e895bf00dd9ec8db7) Merge branch 'master' into matiss/fix-schedule-type-safety ### 📊 Changes **5 files changed** (+18 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/payees.test.ts-snapshots/Payees-checks-the-payees-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/rules/RuleEditor.tsx` (+1 -1) 📝 `packages/loot-core/src/shared/schedules.ts` (+10 -2) 📝 `packages/loot-core/src/types/models/schedule.ts` (+1 -1) ➕ `upcoming-release-notes/6175.md` (+6 -0) </details> ### 📄 Description Reproduction: 1. Open rule edit page 2. Click "+" to add more "actions" 3. Keep clicking "+" 4. Eventually the page will crash (on edge, but not here) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:36:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40803
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?