github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #2025] [MERGED] [Maintenance] Adding Aria labels for accessibility #4074

New Issue
Closed
opened 2026-02-28 20:51:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:51:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2025
Author: @MikesGlitch
Created: 12/3/2023
Status: ✅ Merged
Merged: 12/4/2023
Merged by: @MatissJanis

Base: master ← Head: maintenance/adding-aria-labels

📝 Commits (9)

  • 7a96025 adding some aria labels for accessibility
  • 409332e adding release notes
  • 1202f86 view notes instead of view since there's not much context
  • 8b353b4 changing aria label for... Reasons.
  • 42776f8 Update packages/desktop-client/src/components/accounts/Header.js
  • ab25ba9 Update packages/desktop-client/src/components/Titlebar.tsx
  • 0ab7113 better labels
  • b341050 going with sentence case
  • e28abda missed one

📊 Changes

17 files changed (+36 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/NotesButton.tsx (+1 -0)
📝 packages/desktop-client/src/components/Notifications.tsx (+1 -0)
📝 packages/desktop-client/src/components/ThemeSelector.tsx (+1 -0)
📝 packages/desktop-client/src/components/Titlebar.tsx (+2 -0)
📝 packages/desktop-client/src/components/UpdateNotification.tsx (+1 -0)
📝 packages/desktop-client/src/components/accounts/Header.js (+1 -0)
📝 packages/desktop-client/src/components/budget/BudgetTotals.tsx (+1 -0)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+5 -0)
📝 packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx (+2 -1)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx (+2 -1)
📝 packages/desktop-client/src/components/manager/BudgetList.js (+2 -0)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+1 -0)
📝 packages/desktop-client/src/components/select/RecurringSchedulePicker.js (+2 -0)
📝 packages/desktop-client/src/components/sidebar/ToggleButton.tsx (+6 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+1 -0)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+1 -0)
➕ upcoming-release-notes/2025.md (+6 -0)

📄 Description

Adding aria-labels to some buttons to improve accessibility score.

Notes:

  • There's still loads of issues left - I've only tackled a few here
  • Color contrast is a common issue across pages
  • Might want to start adding data-test-id to elements to make the Puppeteer tests more resilient

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2025 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 12/3/2023 **Status:** ✅ Merged **Merged:** 12/4/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `maintenance/adding-aria-labels` --- ### 📝 Commits (9) - [`7a96025`](https://github.com/actualbudget/actual/commit/7a9602593b9fe98c41598114a8242532a51fae68) adding some aria labels for accessibility - [`409332e`](https://github.com/actualbudget/actual/commit/409332e472af02aa8c2e280df838e1cc6d2e1de9) adding release notes - [`1202f86`](https://github.com/actualbudget/actual/commit/1202f863549be27bac75552d8dea16998a815041) view notes instead of view since there's not much context - [`8b353b4`](https://github.com/actualbudget/actual/commit/8b353b4b25930991c7e611004448c501e1ae5dfb) changing aria label for... Reasons. - [`42776f8`](https://github.com/actualbudget/actual/commit/42776f8029bf0c2c391ba6290bede752156f35f7) Update packages/desktop-client/src/components/accounts/Header.js - [`ab25ba9`](https://github.com/actualbudget/actual/commit/ab25ba98788ff3ccc884130298b6f88676badbeb) Update packages/desktop-client/src/components/Titlebar.tsx - [`0ab7113`](https://github.com/actualbudget/actual/commit/0ab7113f016413eedaaad65fc239140ba6b1ebc4) better labels - [`b341050`](https://github.com/actualbudget/actual/commit/b34105098a84dc855c2fcd9676f074263f3a6d3c) going with sentence case - [`e28abda`](https://github.com/actualbudget/actual/commit/e28abda81e529362cfb4b3ec4720e0ed800286c0) missed one ### 📊 Changes **17 files changed** (+36 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/ThemeSelector.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/UpdateNotification.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+1 -0) 📝 `packages/desktop-client/src/components/budget/BudgetTotals.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+5 -0) 📝 `packages/desktop-client/src/components/budget/report/budgetsummary/BudgetSummary.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/manager/BudgetList.js` (+2 -0) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/select/RecurringSchedulePicker.js` (+2 -0) 📝 `packages/desktop-client/src/components/sidebar/ToggleButton.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+1 -0) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+1 -0) ➕ `upcoming-release-notes/2025.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Adding aria-labels to some buttons to improve accessibility score. Notes: - There's still loads of issues left - I've only tackled a few here - Color contrast is a common issue across pages - Might want to start adding data-test-id to elements to make the Puppeteer tests more resilient --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:51:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4074
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?