github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6061] [MERGED] fix: openId.issuer config not loading from env vars #40734

New Issue
Closed
opened 2026-04-23 13:33:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:33:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6061
Author: @lwschan
Created: 11/3/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @matt-fidd

Base: master ← Head: master

📝 Commits (7)

  • 3daaa29 fix: openId.issuer config loading from env vars
  • 593cf19 add release note
  • 8c9fc87 [autofix.ci] apply automated fixes
  • 5ff8dfa remove unused directive
  • 1f553d3 move test to the right place
  • a065c20 [autofix.ci] apply automated fixes
  • 713571f Merge branch 'master' into master

📊 Changes

4 files changed (+36 additions, -3 deletions)

View changed files

📝 packages/sync-server/src/app.ts (+0 -1)
📝 packages/sync-server/src/load-config.js (+1 -2)
📝 packages/sync-server/src/load-config.test.js (+29 -0)
➕ upcoming-release-notes/6061.md (+6 -0)

📄 Description

Fixes #5349

It seems like convict ignores nested keys if the format is set to object, so it needs to be removed, alongside the default

e4964f2784/packages/convict/src/main.js (L157)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6061 **Author:** [@lwschan](https://github.com/lwschan) **Created:** 11/3/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`3daaa29`](https://github.com/actualbudget/actual/commit/3daaa29b2338023e6d300b3f38899e1ad07f44fb) fix: openId.issuer config loading from env vars - [`593cf19`](https://github.com/actualbudget/actual/commit/593cf1982a730df131b75f201c70abb3e450b23d) add release note - [`8c9fc87`](https://github.com/actualbudget/actual/commit/8c9fc87e7c2680d83f581234efd7fe06fc1533a7) [autofix.ci] apply automated fixes - [`5ff8dfa`](https://github.com/actualbudget/actual/commit/5ff8dfad29c63143cd342df38fcb6589b7905e42) remove unused directive - [`1f553d3`](https://github.com/actualbudget/actual/commit/1f553d3922e227ef6fe8897dcb3967d73413108b) move test to the right place - [`a065c20`](https://github.com/actualbudget/actual/commit/a065c20a6c5e07c223635dde9d6ad7958da6e1fe) [autofix.ci] apply automated fixes - [`713571f`](https://github.com/actualbudget/actual/commit/713571fdefd059d7acea9b0b8b11461164293e2c) Merge branch 'master' into master ### 📊 Changes **4 files changed** (+36 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/sync-server/src/app.ts` (+0 -1) 📝 `packages/sync-server/src/load-config.js` (+1 -2) 📝 `packages/sync-server/src/load-config.test.js` (+29 -0) ➕ `upcoming-release-notes/6061.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Fixes #5349 It seems like `convict` ignores nested keys if the format is set to `object`, so it needs to be removed, alongside the `default` https://github.com/mozilla/node-convict/blob/e4964f278458809e475369b2bec6467317ef5a9c/packages/convict/src/main.js#L157 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:33:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?