github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5874] [MERGED] Add edit payee functionality to mobile page #40611

New Issue
Closed
opened 2026-04-23 13:26:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:26:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5874
Author: @MatissJanis
Created: 10/6/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/add-edit-payee-functionality-to-mobile-page-f4f8

📝 Commits (10+)

  • b3f4da3 feat: Add ability to edit payees on mobile
  • 6028335 Fix: Update payee list item styling for better visibility
  • f41010d Fix: Update payee rename notification string interpolation
  • 6437ff0 Enhance ActionableGridListItem to support function-based actions and remove unnecessary state from MobilePayeesPage and PayeesList components
  • a6546d3 Refactor MobilePayeesPage and PayeesList components for improved layout and dependency management
  • 18598e2 Refactor ActionableGridListItem and PayeesList components for improved functionality and state management
  • d64304b feat: Add edit payee functionality for mobile payees
  • 44dab62 refactor: Integrate Virtualizer into PayeesList for improved performance and layout
  • 447e1e4 Merge branch 'master' into cursor/add-edit-payee-functionality-to-mobile-page-f4f8
  • a85d873 Merge branch 'master' into cursor/add-edit-payee-functionality-to-mobile-page-f4f8

📊 Changes

14 files changed (+242 additions, -19 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/mobile-payees-page.ts (+1 -1)
📝 packages/desktop-client/e2e/payees.mobile.test.ts (+11 -3)
➕ packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-payee-edit-page-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-payee-edit-page-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-payee-edit-page-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+8 -0)
📝 packages/desktop-client/src/components/mobile/ActionableGridListItem.tsx (+13 -2)
➕ packages/desktop-client/src/components/mobile/payees/MobilePayeeEditPage.tsx (+152 -0)
📝 packages/desktop-client/src/components/mobile/payees/MobilePayeesPage.tsx (+8 -0)
📝 packages/desktop-client/src/components/mobile/payees/PayeesList.tsx (+3 -0)
📝 packages/desktop-client/src/components/mobile/payees/PayeesListItem.tsx (+36 -13)
📝 packages/desktop-client/src/components/responsive/narrow.ts (+2 -0)
📝 packages/desktop-client/src/components/responsive/wide.ts (+2 -0)
➕ upcoming-release-notes/5874.md (+6 -0)

📄 Description

Add an 'Edit' button to mobile payee list items, allowing users to rename payees via a modal.

Open in Cursor Open in Web

Note

Adds a mobile payee edit page with routing and rename support, updates list item swipe actions/navigation, and adjusts tests and release notes.

  • Mobile Payees:
    • Edit Page: Add MobilePayeeEditPage (/payees/:id) to rename payees via payees-batch-change, with undo notification and error handling.
    • Routing/Exports: Wire route in FinancesApp and export PayeeEdit in responsive/narrow and responsive/wide.
    • List & Actions:
      • Tapping a payee now navigates to the edit page.
      • PayeesList/PayeesListItem: add onPayeeRuleAction; swipe actions now show "View/Create rule" and "Delete".
      • ActionableGridListItem: actions can be a function receiving { close }; support wider actionsWidth and close-on-action behavior.
  • E2E:
    • Update tests and page model to navigate to /payees/:id and assert edit form elements.
  • Release Notes:
    • Add enhancement entry for mobile payee editing.

Written by Cursor Bugbot for commit 6a699250db. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5874 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/add-edit-payee-functionality-to-mobile-page-f4f8` --- ### 📝 Commits (10+) - [`b3f4da3`](https://github.com/actualbudget/actual/commit/b3f4da304ee171c31e6d326a97b6e147ce43e09e) feat: Add ability to edit payees on mobile - [`6028335`](https://github.com/actualbudget/actual/commit/6028335a3d2f2b2fbc3891ca1dfccea697fa32a0) Fix: Update payee list item styling for better visibility - [`f41010d`](https://github.com/actualbudget/actual/commit/f41010dbe9b13c92598dc0e4d931afd4aa668696) Fix: Update payee rename notification string interpolation - [`6437ff0`](https://github.com/actualbudget/actual/commit/6437ff05586de66f9fb040e7a2ae7b9b5e21e4ec) Enhance ActionableGridListItem to support function-based actions and remove unnecessary state from MobilePayeesPage and PayeesList components - [`a6546d3`](https://github.com/actualbudget/actual/commit/a6546d3d824978c67dc07877702239d3d60e8c54) Refactor MobilePayeesPage and PayeesList components for improved layout and dependency management - [`18598e2`](https://github.com/actualbudget/actual/commit/18598e2b1ee46ecad711c1b740638d12343750ac) Refactor ActionableGridListItem and PayeesList components for improved functionality and state management - [`d64304b`](https://github.com/actualbudget/actual/commit/d64304b795e8c39d38bf2357e1babc3af5010832) feat: Add edit payee functionality for mobile payees - [`44dab62`](https://github.com/actualbudget/actual/commit/44dab6266eac3bc79532d9dcda3ea1fc864b5bf8) refactor: Integrate Virtualizer into PayeesList for improved performance and layout - [`447e1e4`](https://github.com/actualbudget/actual/commit/447e1e42d946322a1b1a7d40466d879ec8d012ff) Merge branch 'master' into cursor/add-edit-payee-functionality-to-mobile-page-f4f8 - [`a85d873`](https://github.com/actualbudget/actual/commit/a85d873f18e0425ea7aa1b8dd279de5ec115cb83) Merge branch 'master' into cursor/add-edit-payee-functionality-to-mobile-page-f4f8 ### 📊 Changes **14 files changed** (+242 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/mobile-payees-page.ts` (+1 -1) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts` (+11 -3) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-payee-edit-page-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-payee-edit-page-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-clicking-on-a-payee-opens-payee-edit-page-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+8 -0) 📝 `packages/desktop-client/src/components/mobile/ActionableGridListItem.tsx` (+13 -2) ➕ `packages/desktop-client/src/components/mobile/payees/MobilePayeeEditPage.tsx` (+152 -0) 📝 `packages/desktop-client/src/components/mobile/payees/MobilePayeesPage.tsx` (+8 -0) 📝 `packages/desktop-client/src/components/mobile/payees/PayeesList.tsx` (+3 -0) 📝 `packages/desktop-client/src/components/mobile/payees/PayeesListItem.tsx` (+36 -13) 📝 `packages/desktop-client/src/components/responsive/narrow.ts` (+2 -0) 📝 `packages/desktop-client/src/components/responsive/wide.ts` (+2 -0) ➕ `upcoming-release-notes/5874.md` (+6 -0) </details> ### 📄 Description Add an 'Edit' button to mobile payee list items, allowing users to rename payees via a modal. --- <a href="https://cursor.com/background-agent?bcId=bc-62d5d0b1-f2e2-4958-a95a-68ee8dade58d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-62d5d0b1-f2e2-4958-a95a-68ee8dade58d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a mobile payee edit page with routing and rename support, updates list item swipe actions/navigation, and adjusts tests and release notes. > > - **Mobile Payees**: > - **Edit Page**: Add `MobilePayeeEditPage` (`/payees/:id`) to rename payees via `payees-batch-change`, with undo notification and error handling. > - **Routing/Exports**: Wire route in `FinancesApp` and export `PayeeEdit` in `responsive/narrow` and `responsive/wide`. > - **List & Actions**: > - Tapping a payee now navigates to the edit page. > - `PayeesList`/`PayeesListItem`: add `onPayeeRuleAction`; swipe actions now show "View/Create rule" and "Delete". > - `ActionableGridListItem`: `actions` can be a function receiving `{ close }`; support wider `actionsWidth` and close-on-action behavior. > - **E2E**: > - Update tests and page model to navigate to `/payees/:id` and assert edit form elements. > - **Release Notes**: > - Add enhancement entry for mobile payee editing. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6a699250db2de6be8d7fbfe6f304af2758a01662. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:26:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?