github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5845] [CLOSED] fix(#5840): transaction view with ? #40591

New Issue
Closed
opened 2026-04-23 13:25:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:25:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5845
Author: @shantanugupta2004
Created: 10/3/2025
Status: ❌ Closed

Base: master ← Head: fix/quick_search

📝 Commits (8)

  • c86fa97 fix(#5840): transaction view with ?
  • 7969b9d release notes added
  • f033f82 CI test fix
  • 38f15a6 escaping in search function
  • 5c03471 lint and other issues fixed
  • fc8cc25 fixed the issues of lint and other critical parts
  • 80cabde lint fix and case sensitive fix
  • 45c0cac Merge branch 'master' into fix/quick_search

📊 Changes

5 files changed (+57 additions, -9 deletions)

View changed files

📝 packages/desktop-client/src/queries/index.ts (+7 -5)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+1 -1)
📝 packages/loot-core/src/platform/server/sqlite/unicodeLike.ts (+1 -1)
📝 packages/loot-core/src/server/aql/compiler.ts (+42 -2)
➕ upcoming-release-notes/5845.md (+6 -0)

📄 Description

Fixes #5840
This PR fixes a bug where searching for a ? in the quick search would return all transactions instead of only the transactions containing a literal ?. The root cause of this issue was in the UNICODE_LIKE custom SQLite function, which was incorrectly treating ? as a single-character wildcard, similar to the _ character in SQL's LIKE operator. The fix involves modifying the unicodeLike function to no longer treat ? as a wildcard. Instead, it is now treated as a literal character. This is achieved by escaping the ? character when constructing the regular expression in the unicodeLike function.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5845 **Author:** [@shantanugupta2004](https://github.com/shantanugupta2004) **Created:** 10/3/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/quick_search` --- ### 📝 Commits (8) - [`c86fa97`](https://github.com/actualbudget/actual/commit/c86fa97a950800160219f401070c81a46fec9e7c) fix(#5840): transaction view with ? - [`7969b9d`](https://github.com/actualbudget/actual/commit/7969b9db7b0b23e1a0ea0841cabdb5fb06e043ed) release notes added - [`f033f82`](https://github.com/actualbudget/actual/commit/f033f8203599902c778db283de7fa596adbd3d28) CI test fix - [`38f15a6`](https://github.com/actualbudget/actual/commit/38f15a60d398a84d2d1383ef1628a0525d352c91) escaping in search function - [`5c03471`](https://github.com/actualbudget/actual/commit/5c0347130ca35025067f4b701e060edf3b893df6) lint and other issues fixed - [`fc8cc25`](https://github.com/actualbudget/actual/commit/fc8cc25d5dd3371d7fd228cbf539889e554fca18) fixed the issues of lint and other critical parts - [`80cabde`](https://github.com/actualbudget/actual/commit/80cabdee75ea1f64479bbcbb290d0b06f8028bee) lint fix and case sensitive fix - [`45c0cac`](https://github.com/actualbudget/actual/commit/45c0cac57d7ae239d2b08e0902a7d7b2c19db1be) Merge branch 'master' into fix/quick_search ### 📊 Changes **5 files changed** (+57 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/queries/index.ts` (+7 -5) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/sqlite/unicodeLike.ts` (+1 -1) 📝 `packages/loot-core/src/server/aql/compiler.ts` (+42 -2) ➕ `upcoming-release-notes/5845.md` (+6 -0) </details> ### 📄 Description Fixes #5840 This PR fixes a bug where searching for a ? in the quick search would return all transactions instead of only the transactions containing a literal `?`. The root cause of this issue was in the UNICODE_LIKE custom SQLite function, which was incorrectly treating `?` as a single-character wildcard, similar to the _ character in SQL's LIKE operator. The fix involves modifying the unicodeLike function to no longer treat `?` as a wildcard. Instead, it is now treated as a literal character. This is achieved by escaping the `?` character when constructing the regular expression in the unicodeLike function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:25:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40591
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?