github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5810] [MERGED] skip running the schedule service if the database is not loaded #40567

New Issue
Closed
opened 2026-04-23 13:24:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 13:24:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5810
Author: @matt-fidd
Created: 9/28/2025
Status: ✅ Merged
Merged: 9/29/2025
Merged by: @matt-fidd

Base: master ← Head: schedule-service-db

📝 Commits (2)

  • 9cb65c7 skip running schedule service if DB not available
  • 3ea8d84 note

📊 Changes

2 files changed (+12 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/schedules/app.ts (+6 -1)
➕ upcoming-release-notes/5810.md (+6 -0)

📄 Description

Prevents this nuisance error, which occurs roughly every 100 runs of the API. It's obviously some form of race but it's certainly not common, probably an edge case where the sync event finishes, runs the schedules service, and it doesn't finish before the sync is done and the db is closed. It'll just be run at the next chance so there's no issue skipping it - besides it would just fail otherwise.

/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:5534
        stmt = typeof sql === "string" ? db2.prepare(sql) : sql;
                                             ^
TypeError: Cannot read properties of null (reading 'prepare')
    at runQuery$1 (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:5534:46)
    at runQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:60261:16)
    at all (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:60290:12)
    at execQuery$1 (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14096:24)
    at runCompiledAqlQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14113:22)
    at compileAndRunAqlQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14129:24)
    at aqlQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14702:12)
    at advanceSchedulesService (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:79315:39)
    at /data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:79365:30
    at _runMutator (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:55808:12)

Node.js v22.17.0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5810 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 9/28/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `schedule-service-db` --- ### 📝 Commits (2) - [`9cb65c7`](https://github.com/actualbudget/actual/commit/9cb65c76a81b032fca0de6d493211b75d1f7d52c) skip running schedule service if DB not available - [`3ea8d84`](https://github.com/actualbudget/actual/commit/3ea8d8491fd34819b4074e9cc28ae5a07945aeba) note ### 📊 Changes **2 files changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/schedules/app.ts` (+6 -1) ➕ `upcoming-release-notes/5810.md` (+6 -0) </details> ### 📄 Description Prevents this nuisance error, which occurs roughly every 100 runs of the API. It's obviously some form of race but it's certainly not common, probably an edge case where the sync event finishes, runs the schedules service, and it doesn't finish before the sync is done and the db is closed. It'll just be run at the next chance so there's no issue skipping it - besides it would just fail otherwise. ``` /data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:5534 stmt = typeof sql === "string" ? db2.prepare(sql) : sql; ^ TypeError: Cannot read properties of null (reading 'prepare') at runQuery$1 (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:5534:46) at runQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:60261:16) at all (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:60290:12) at execQuery$1 (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14096:24) at runCompiledAqlQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14113:22) at compileAndRunAqlQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14129:24) at aqlQuery (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:14702:12) at advanceSchedulesService (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:79315:39) at /data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:79365:30 at _runMutator (/data/actual/node_modules/@actual-app/api/dist/app/bundle.api.js:55808:12) Node.js v22.17.0 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 13:24:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#40567
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?